From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5258 invoked by alias); 21 Jun 2002 14:40:00 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 5219 invoked from network); 21 Jun 2002 14:39:52 -0000 Received: from unknown (HELO cerbere.u-strasbg.fr) (130.79.112.250) by sources.redhat.com with SMTP; 21 Jun 2002 14:39:52 -0000 Received: from laocoon (laocoon.u-strasbg.fr [130.79.112.72]) by cerbere.u-strasbg.fr (Postfix) with ESMTP id DC226435; Fri, 21 Jun 2002 16:42:01 +0200 (CEST) Message-Id: <4.2.0.58.20020621162359.020aaba8@ics.u-strasbg.fr> X-Sender: muller@ics.u-strasbg.fr Date: Fri, 21 Jun 2002 07:40:00 -0000 To: Andrew Cagney From: Pierre Muller Subject: Re: [RFA] remove calls to fprintf in language parsers Cc: gdb-patches@sources.redhat.com In-Reply-To: <3D133498.1020708@cygnus.com> References: <4.2.0.58.20020620114119.01fb8ea8@ics.u-strasbg.fr> <4.2.0.58.20020621090032.00a45ed8@ics.u-strasbg.fr> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8bit X-SW-Source: 2002-06/txt/msg00420.txt.bz2 At 16:13 21/06/2002 , Andrew Cagney a écrit: >>At 02:49 21/06/2002 , Andrew Cagney a écrit: >> >>>>+/* Function used to avoid direct calls to fprintf >>>>+ in the code generated by the bison parser. */ >>>>+ >>>>+extern void parser_fprintf (FILE *, const char *, ...); >> >>> >>>Hmm, wonder if there is any benefit in adding ATTR_FORMAT(printf, 2, 3) to the declaration? >> >>I didn't even know this modifier :( > >BTW, attr_format was only added to error() (one of GDBs most important functions) a month or so ago. While the attribute has been around for a while, it is relativly new for GDB. > >>But it does look appropriate indeed. > >My only reservation was that bison/yacc could turn out to generate badly formatted printf statements. However, if that is happening then we need to know anyway. Isn't it the purpose of this modifer to check if the format and the parameter list match? >As for indentation. GNU indent doesn't handle ATTR_FORMAT() very well so any location is likely ok. > >>>Anyway, yes, >> >>Does this mean I can apply the patch? > >Yes, either way. Committed. >Andrew >(I'm just happy to see these fprintf() slowly disappearing :-) The only fprintf call remaining (at least for cygwin native GDB) is in tracepoint.c function tracepoint_save_command but this is directly to a disk file, so it shouldn't harm any program using GDB lib like Insight. Nevertheless for consistency, this FILE *fp local var should probably also be converted into a ui_file by using gdb_fopen instead of fopen, no? Pierre Muller Institut Charles Sadron 6,rue Boussingault F 67083 STRASBOURG CEDEX (France) mailto:muller@ics.u-strasbg.fr Phone : (33)-3-88-41-40-07 Fax : (33)-3-88-41-40-99