Re: Resend: [RFC] p-exp.y enhancements.

Michael Snyder
2002-05-03T17:40:42Z

Pierre Muller wrote:
>
> At 19:53 02/05/2002 , Michael Snyder a Ã©crit:
> >Pierre Muller wrote:
> > >
> > > (Second posting with the patch attached,
> > > this way you should have less problems to
> > > apply the patch).
> > >
> > > This patch has several benefits:
> > >
> > > 1) it adds support for S[exp] if S is a pascal string.
> > > I must admit that this only works for Free Pascal Compiler
> > > for now, because GPC uses BITSTRING type
> > > for the array containg the chars which confuses GDB.
> > > I informed the GPC developper team, but their answer
> > > seems to be that they didn't really directly change any code
> > > regarding debug information output for pascal...
> >
> >What will happen if a GPC user tries to do that?
>
> Well, before it gave an error that there is no [] operator,
> after it will give a different error.
> (
>
> > > 2) it adds support for case insensitive searches of record
> > > (pascal struct) fields.
> >
> >This seems like a good thing...
> >
> >
> > > 3) It prepares to a more simple RFC
> > > about the enhancement to the completer for
> > > structure field that I sent some time ago. See
> > > http://sources.redhat.com/ml/gdb-patches/2002-04/msg00774.html
> >
> >This seems like a good thing too, but is pretty
> >unrelated to the two above. Would you mind breaking
> >this patch down into functional units? Since I'm a
> >little rusty in both Pascal and Yacc, that will make
> >it considerably easier to review.
>
> No, it is clearly related because, in order to get
> a way to get the completer to work of struct fields,
> we need of course to know the current_type
> of a part of an expression, which is the core of this patch!

Sorry Pierre -- I was half asleep when I wrote this.
You don't need my approval for these patches anyway. ;-)