From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1715 invoked by alias); 26 Apr 2002 08:56:52 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 1627 invoked from network); 26 Apr 2002 08:56:45 -0000 Received: from unknown (HELO cerbere.u-strasbg.fr) (130.79.112.7) by sources.redhat.com with SMTP; 26 Apr 2002 08:56:45 -0000 Received: from laocoon (laocoon.u-strasbg.fr [130.79.112.72]) by cerbere.u-strasbg.fr (8.9.3/8.8.7) with ESMTP id KAA21771; Fri, 26 Apr 2002 10:56:34 +0200 Message-Id: <4.2.0.58.20020426102453.0233c338@ics.u-strasbg.fr> X-Sender: muller@ics.u-strasbg.fr Date: Fri, 26 Apr 2002 01:56:00 -0000 To: Andrew Cagney , Pierre Muller From: Pierre Muller Subject: [RFA 2nd] remote-*.c printf (stderr,... ->fprintf_unfiltered (gdb_stderr,... Cc: gdb-patches@sources.redhat.com In-Reply-To: <3CC83A34.4010809@cygnus.com> References: <4.2.0.58.20020424151836.01ee8d48@ics.u-strasbg.fr> <4.2.0.58.20020425183344.020b9a18@ics.u-strasbg.fr> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8bit X-SW-Source: 2002-04/txt/msg01077.txt.bz2 At 19:17 25/04/2002 , Andrew Cagney a écrit: >>These can also also be changed. gdb_stderr is defined in defs.h, so it is visible. >> >>Can I commit the whole together then? > >yep I send here a second version of the patch that also includes formatting to avoid lines longer than 80 chars. So this patch replaces [RFA/RFC] printf (stderr,... ->fprintf_unfiltered (gdb_stderr,... in remote*.c http://sources.redhat.com/ml/gdb-patches/2002-04/msg00931.html One important remark is that I don't even know how I should run configure in order to be able to compile these files :( Thus I couldn't test all of these files (some compiled, others not because of wrong configuration...) Andrew, can I commit this even without having compiled them? ChangeLog entry: 2002-04-24 Pierre Muller * remote-array.c (printf_monitor, write_monitor, array_insert_breakpoint, array_remove_breakpoint ): Replace fprintf (stderr,... with fprintf_unfiltered (gdb_stderr,.... * remote-es.c: Likewise. * remote-os9k.c: Likewise. * remote-st.c: Likewise. Index: remote-array.c =================================================================== RCS file: /cvs/src/src/gdb/remote-array.c,v retrieving revision 1.18 diff -u -p -r1.18 remote-array.c --- remote-array.c 19 Jan 2002 03:32:37 -0000 1.18 +++ remote-array.c 26 Apr 2002 08:23:57 -0000 @@ -193,7 +193,8 @@ printf_monitor (char *pattern,...) if (strlen (buf) > PBUFSIZ) error ("printf_monitor(): string too long"); if (serial_write (array_desc, buf, strlen (buf))) - fprintf (stderr, "serial_write failed: %s\n", safe_strerror (errno)); + fprintf_unfiltered (gdb_stderr, "serial_write failed: %s\n", + safe_strerror (errno)); } /* * write_monitor -- send raw data to monitor. @@ -202,7 +203,8 @@ static void write_monitor (char data[], int len) { if (serial_write (array_desc, data, len)) - fprintf (stderr, "serial_write failed: %s\n", safe_strerror (errno)); + fprintf_unfiltered (gdb_stderr, "serial_write failed: %s\n", + safe_strerror (errno)); *(data + len + 1) = '\0'; debuglogs (1, "write_monitor(), Sending: \"%s\".", data); @@ -1053,7 +1055,7 @@ array_insert_breakpoint (CORE_ADDR addr, } } - fprintf (stderr, "Too many breakpoints (> 16) for monitor\n"); + fprintf_unfiltered (gdb_stderr, "Too many breakpoints (> 16) for monitor\n"); return 1; } @@ -1078,8 +1080,9 @@ array_remove_breakpoint (CORE_ADDR addr, return 0; } } - fprintf (stderr, "Can't find breakpoint associated with 0x%s\n", - paddr_nz (addr)); + fprintf_unfiltered (gdb_stderr, + "Can't find breakpoint associated with 0x%s\n", + paddr_nz (addr)); return 1; } Index: remote-es.c =================================================================== RCS file: /cvs/src/src/gdb/remote-es.c,v retrieving revision 1.20 diff -u -p -r1.20 remote-es.c --- remote-es.c 19 Jan 2002 03:32:37 -0000 1.20 +++ remote-es.c 26 Apr 2002 08:23:57 -0000 @@ -1616,7 +1616,7 @@ send (char *string) { if (kiodebug) { - fprintf (stderr, "Sending: %s\n", string); + fprintf_unfiltered (gdb_stderr, "Sending: %s\n", string); } serial_write (es1800_desc, string, strlen (string)); } @@ -1663,7 +1663,7 @@ getmessage (char *buf, int len) if (kiodebug) { - fprintf (stderr, "message received :%s\n", buf); + fprintf_unfiltered (gdb_stderr, "message received :%s\n", buf); } } Index: remote-os9k.c =================================================================== RCS file: /cvs/src/src/gdb/remote-os9k.c,v retrieving revision 1.18 diff -u -p -r1.18 remote-os9k.c --- remote-os9k.c 19 Jan 2002 03:32:38 -0000 1.18 +++ remote-os9k.c 26 Apr 2002 08:23:58 -0000 @@ -101,7 +101,8 @@ printf_monitor (char *pattern,...) va_end (args); if (serial_write (monitor_desc, buf, strlen (buf))) - fprintf (stderr, "serial_write failed: %s\n", safe_strerror (errno)); + fprintf_unfiltered (gdb_stderr, "serial_write failed: %s\n", + safe_strerror (errno)); } /* Read a character from the remote system, doing all the fancy timeout stuff * / @@ -380,9 +381,9 @@ rombug_close (int quitting) if (log_file) { if (ferror (log_file)) - fprintf (stderr, "Error writing log file.\n"); + fprintf_unfiltered (gdb_stderr, "Error writing log file.\n"); if (fclose (log_file) != 0) - fprintf (stderr, "Error closing log file.\n"); + fprintf_unfiltered (gdb_stderr, "Error closing log file.\n"); log_file = 0; } } @@ -883,7 +884,7 @@ rombug_insert_breakpoint (CORE_ADDR addr return 0; } - fprintf (stderr, "Too many breakpoints (> 16) for monitor\n"); + fprintf_unfiltered (gdb_stderr, "Too many breakpoints (> 16) for monitor\n"); return 1; } @@ -908,7 +909,8 @@ rombug_remove_breakpoint (CORE_ADDR addr return 0; } - fprintf (stderr, "Can't find breakpoint associated with 0x%x\n", addr); + fprintf_unfiltered (gdb_stderr, + "Can't find breakpoint associated with 0x%x\n", addr); return 1; } @@ -949,7 +951,9 @@ rombug_load (char *arg) if (serial_write (monitor_desc, buf, bytes_read)) { - fprintf (stderr, "serial_write failed: (while downloading) %s\n", safe _strerror (errno)); + fprintf_unfiltered (gdb_stderr, + "serial_write failed: (while downloading) %s\n", + safe_strerror (errno)); break; } i = 0; Index: remote-st.c =================================================================== RCS file: /cvs/src/src/gdb/remote-st.c,v retrieving revision 1.16 diff -u -p -r1.16 remote-st.c --- remote-st.c 19 Jan 2002 03:32:39 -0000 1.16 +++ remote-st.c 26 Apr 2002 08:23:58 -0000 @@ -79,7 +79,8 @@ printf_stdebug (char *pattern,...) va_end (args); if (serial_write (st2000_desc, buf, strlen (buf))) - fprintf (stderr, "serial_write failed: %s\n", safe_strerror (errno)); + fprintf_unfiltered (gdb_stderr, "serial_write failed: %s\n", + safe_strerror (errno)); } /* Read a character from the remote system, doing all the fancy timeout @@ -324,9 +325,9 @@ st2000_close (int quitting) if (log_file) { if (ferror (log_file)) - fprintf (stderr, "Error writing log file.\n"); + fprintf_unfiltered (gdb_stderr, "Error writing log file.\n"); if (fclose (log_file) != 0) - fprintf (stderr, "Error closing log file.\n"); + fprintf_unfiltered (gdb_stderr, "Error closing log file.\n"); } #endif } @@ -616,7 +617,7 @@ st2000_insert_breakpoint (CORE_ADDR addr return 0; } - fprintf (stderr, "Too many breakpoints (> 16) for STDBUG\n"); + fprintf_unfiltered (gdb_stderr, "Too many breakpoints (> 16) for STDBUG\n"); return 1; } @@ -635,7 +636,8 @@ st2000_remove_breakpoint (CORE_ADDR addr return 0; } - fprintf (stderr, "Can't find breakpoint associated with 0x%x\n", addr); + fprintf_unfiltered (gdb_stderr, + "Can't find breakpoint associated with 0x%x\n", addr); return 1; } Pierre Muller Institut Charles Sadron 6,rue Boussingault F 67083 STRASBOURG CEDEX (France) mailto:muller@ics.u-strasbg.fr Phone : (33)-3-88-41-40-07 Fax : (33)-3-88-41-40-99