From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32031 invoked by alias); 25 Apr 2002 16:49:42 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 31857 invoked from network); 25 Apr 2002 16:48:25 -0000 Received: from unknown (HELO cerbere.u-strasbg.fr) (130.79.112.7) by sources.redhat.com with SMTP; 25 Apr 2002 16:48:25 -0000 Received: from laocoon (laocoon.u-strasbg.fr [130.79.112.72]) by cerbere.u-strasbg.fr (8.9.3/8.8.7) with ESMTP id SAA09630; Thu, 25 Apr 2002 18:48:01 +0200 Message-Id: <4.2.0.58.20020425183926.020b6350@ics.u-strasbg.fr> X-Sender: muller@ics.u-strasbg.fr Date: Thu, 25 Apr 2002 09:49:00 -0000 To: Andrew Cagney From: Pierre Muller Subject: [RFA]Use prev_lexptr in *-exp.y Cc: gdb-patches@sources.redhat.com In-Reply-To: <3CC820FE.8070403@cygnus.com> References: <4.2.0.58.20020425103344.024be7a8@ics.u-strasbg.fr> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8bit X-SW-Source: 2002-04/txt/msg01026.txt.bz2 At 17:30 25/04/2002 , Andrew Cagney a écrit: >>2002-04-25 Pierre Muller >>* p-exp.y: Also use new prev_lexptr variable >> to improve error reporting. Based on Michael Snyder >> 2002-04-24 dated patch to c-exp.y. > >Nice. Can I suggest creating bug report so we know that the others should be done. This is more work than fixing them directly! So what about that: ChangeLog entry: 2002-04-25 Pierre Muller * f-exp.y: Also use new prev_lexptr variable to improve error reporting. Based on Michael Snyder 2002-04-24 dated patch to c-exp.y. * jv-exp.y: Likewise. * m2-exp.y: Likewise. Index: f-exp.y =================================================================== RCS file: /cvs/src/src/gdb/f-exp.y,v retrieving revision 1.5 diff -u -p -r1.5 f-exp.y --- f-exp.y 6 Mar 2001 08:21:07 -0000 1.5 +++ f-exp.y 25 Apr 2002 16:45:29 -0000 @@ -924,7 +924,9 @@ yylex () char *tokstart; retry: - + + prev_lexptr = lexptr; + tokstart = lexptr; /* First of all, let us make sure we are not dealing with the @@ -1171,5 +1173,8 @@ void yyerror (msg) char *msg; { + if (prev_lexptr) + lexptr = prev_lexptr; + error ("A %s in expression, near `%s'.", (msg ? msg : "error"), lexptr); } Index: jv-exp.y =================================================================== RCS file: /cvs/src/src/gdb/jv-exp.y,v retrieving revision 1.5 diff -u -p -r1.5 jv-exp.y --- jv-exp.y 21 Feb 2002 02:54:46 -0000 1.5 +++ jv-exp.y 25 Apr 2002 16:45:29 -0000 @@ -862,6 +862,8 @@ yylex () retry: + prev_lexptr = lexptr; + tokstart = lexptr; /* See if it is a special token of length 3. */ for (i = 0; i < sizeof tokentab3 / sizeof tokentab3[0]; i++) @@ -1207,6 +1209,9 @@ void yyerror (msg) char *msg; { + if (prev_lexptr) + lexptr = prev_lexptr; + error ("A %s in expression, near `%s'.", (msg ? msg : "error"), lexptr); } Index: m2-exp.y =================================================================== RCS file: /cvs/src/src/gdb/m2-exp.y,v retrieving revision 1.3 diff -u -p -r1.3 m2-exp.y --- m2-exp.y 6 Mar 2001 08:21:09 -0000 1.3 +++ m2-exp.y 25 Apr 2002 16:45:29 -0000 @@ -821,6 +821,8 @@ yylex () retry: + prev_lexptr = lexptr; + tokstart = lexptr; @@ -1090,5 +1092,8 @@ void yyerror (msg) char *msg; { + if (prev_lexptr) + lexptr = prev_lexptr; + error ("A %s in expression, near `%s'.", (msg ? msg : "error"), lexptr); } Pierre Muller Institut Charles Sadron 6,rue Boussingault F 67083 STRASBOURG CEDEX (France) mailto:muller@ics.u-strasbg.fr Phone : (33)-3-88-41-40-07 Fax : (33)-3-88-41-40-99