From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21534 invoked by alias); 25 Apr 2002 16:35:24 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 21490 invoked from network); 25 Apr 2002 16:35:16 -0000 Received: from unknown (HELO cerbere.u-strasbg.fr) (130.79.112.7) by sources.redhat.com with SMTP; 25 Apr 2002 16:35:16 -0000 Received: from laocoon (laocoon.u-strasbg.fr [130.79.112.72]) by cerbere.u-strasbg.fr (8.9.3/8.8.7) with ESMTP id SAA09400; Thu, 25 Apr 2002 18:35:07 +0200 Message-Id: <4.2.0.58.20020425183221.020e44a8@ics.u-strasbg.fr> X-Sender: muller@ics.u-strasbg.fr Date: Thu, 25 Apr 2002 09:35:00 -0000 To: Andrew Cagney , Daniel Jacobowitz From: Pierre Muller Subject: Re: [RFA/RFC] printf (stderr,... ->fprintf_unfiltered (gdb_stderr,... in hpread.c Cc: Michael Snyder , gdb-patches@sources.redhat.com, Pierre Muller In-Reply-To: <3CC822F7.8010205@cygnus.com> References: <4.2.0.58.20020424151049.01eb0900@ics.u-strasbg.fr> <20020424102516.C6310@nevyn.them.org> <3CC6FE80.D2EC8A7E@redhat.com> <20020424152929.A20589@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8bit X-SW-Source: 2002-04/txt/msg01023.txt.bz2 At 17:38 25/04/2002 , Andrew Cagney a écrit: >>On Wed, Apr 24, 2002 at 11:50:40AM -0700, Michael Snyder wrote: >> >>>Daniel Jacobowitz wrote: >> >>> > > On Wed, Apr 24, 2002 at 03:16:16PM +0200, Pierre Muller wrote: >> >>> > > This is a second of the files that I listed in >>> > > http://sources.redhat.com/ml/gdb/2002-02/msg00212.html >>> > > as still having direct uses of stderr. >>> > > >>> > > I did not fix a 80 char overflow, because I didn't find a good way to do it: >>> > > If I try to align the string "Psymtab for %s already read in. Shouldn't happen.\n" >>> > > with gdb_stderr, I still get an overflow, how show I indent the args then? >>> > > Should I break the string constant? >> >>> > > Yes, I'd recommend: >>> > > - fprintf (stderr, "Psymtab for %s already read in. Shouldn't happen.\n", >>> > + fprintf_unfiltered (gdb_stderr, "Psymtab for %s already read in. " >>> > "Shouldn't happen.\n", > >The other is the more traditional: > > ..... "\ >Psymtab for ......\n\ >.......\n" > >(the ``\'' at the end of the line is needed. > >>> >>>I thought there was some kind of caveat against the use of >>>string concatenation ? >> >>Perhaps you're thinking of token concatenation, or stringification? Or >>multiline strings? I believe "a" "b" has worked even in K&R compilers. > >Some, not all. But yes string concatenation like the above is fine for GDB. > >(Pierre, yes, ok with a tweak). Sorry, but I din't understand which version of the modification I should use here... Pierre Muller Institut Charles Sadron 6,rue Boussingault F 67083 STRASBOURG CEDEX (France) mailto:muller@ics.u-strasbg.fr Phone : (33)-3-88-41-40-07 Fax : (33)-3-88-41-40-99