From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8770 invoked by alias); 24 Apr 2002 13:18:55 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 8659 invoked from network); 24 Apr 2002 13:18:20 -0000 Received: from unknown (HELO cerbere.u-strasbg.fr) (130.79.112.7) by sources.redhat.com with SMTP; 24 Apr 2002 13:18:20 -0000 Received: from laocoon (laocoon.u-strasbg.fr [130.79.112.72]) by cerbere.u-strasbg.fr (8.9.3/8.8.7) with ESMTP id PAA18787 for ; Wed, 24 Apr 2002 15:18:15 +0200 Message-Id: <4.2.0.58.20020424151049.01eb0900@ics.u-strasbg.fr> X-Sender: muller@ics.u-strasbg.fr Date: Wed, 24 Apr 2002 06:18:00 -0000 To: gdb-patches@sources.redhat.com From: Pierre Muller Subject: [RFA/RFC] printf (stderr,... ->fprintf_unfiltered (gdb_stderr,... in hpread.c Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" X-SW-Source: 2002-04/txt/msg00930.txt.bz2 This is a second of the files that I listed in http://sources.redhat.com/ml/gdb/2002-02/msg00212.html as still having direct uses of stderr. I did not fix a 80 char overflow, because I didn't find a good way to do it: If I try to align the string "Psymtab for %s already read in. Shouldn't happen.\n" with gdb_stderr, I still get an overflow, how show I indent the args then? Should I break the string constant? ChangeLog entry: 2002-04-24 Pierre Muller * hpread.c (hpread_psymtab_to_symtab_1, hpread_psymtab_to_symtab): Replace fprintf (stderr,... with fprintf_unfiltered (gdb_stderr,.... Index: hpread.c =================================================================== RCS file: /cvs/src/src/gdb/hpread.c,v retrieving revision 1.15 diff -u -p -r1.15 hpread.c --- hpread.c 15 Apr 2002 04:52:08 -0000 1.15 +++ hpread.c 24 Apr 2002 12:41:18 -0000 @@ -2693,7 +2693,7 @@ hpread_psymtab_to_symtab_1 (struct parti /* Complain if we've already read in this symbol table. */ if (pst->readin) { - fprintf (stderr, "Psymtab for %s already read in. Shouldn't happen.\n", + fprintf_unfiltered (gdb_stderr, "Psymtab for %s already read in. Shouldn't happen.\n", pst->filename); return; } @@ -2748,7 +2748,7 @@ hpread_psymtab_to_symtab (struct partial /* Sanity check. */ if (pst->readin) { - fprintf (stderr, "Psymtab for %s already read in. Shouldn't happen.\n", + fprintf_unfiltered (gdb_stderr, "Psymtab for %s already read in. Shouldn't happen.\n", pst->filename); return; }