Re: [PATCH RFC 3/5] Make index reading functions more modular

Simon Marchi
2018-05-10T21:04:38Z

On 2018-05-10 16:54, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@ericsson.com> writes:
>
> Simon> The read_gdb_index_from_section and
> read_debug_names_from_section
> Simon> functions read the index content, as their names state, from
> sections of
> Simon> object files. A following patch will make it possible to read
> index
> Simon> content from standalone files.
>
> Simon> This patch therefore decouples the code that reads the index
> content
> Simon> from object file sections from the code that processes that
> content.
> Simon> Functions dwarf2_read_gdb_index and dwarf2_read_debug_names
> receive
> Simon> callbacks that are responsible for providing the index contents
> (for
> Simon> both the main file and the potential dwz file).
>
> This callback style makes the code harder to read and understand; but
> other than that this seems fine.

Indeed, I'm open to suggestions :).

Simon