From: Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
To: Simon Marchi <simon.marchi@polymtl.ca>, gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb/testsuite] Add check-readmore
Date: Sat, 9 Oct 2021 18:54:03 +0200 [thread overview]
Message-ID: <3fbef6f9-226d-76e0-9057-c7256023beb2@suse.de> (raw)
In-Reply-To: <66c15d74-375d-6643-e692-3d636a7c7673@suse.de>
On 8/31/21 3:45 PM, Tom de Vries via Gdb-patches wrote:
> [ was: Re: [RFC][gdb/testsuite] Add check-readmore ]
>
> On 8/30/21 5:30 PM, Tom de Vries wrote:
>
>>> If not, I'd just go
>>> with the simplest. I could imagine a modified method 2 version where we
>>> read in a loop though, until we reached "count" bytes or the file
>>> descriptor has no more data to offer (still with a 10ms wait between
>>> each read, to give the writer time to produce more data).
>>
>> Agreed, there could be some benefit in doing this in a loop. It would
>> add a benefit similar to increasing the timeout, without the drawback of
>> waiting unnecessary while the buffer is already full.
>
> Implemented the loop approach.
>
I've committed this now.
Thanks,
- Tom
prev parent reply other threads:[~2021-10-09 16:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 7:24 [RFC][gdb/testsuite] " Tom de Vries
2021-08-26 3:09 ` Simon Marchi via Gdb-patches
2021-08-30 15:30 ` Tom de Vries via Gdb-patches
2021-08-31 13:45 ` [PATCH][gdb/testsuite] " Tom de Vries via Gdb-patches
2021-10-09 16:54 ` Tom de Vries via Gdb-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fbef6f9-226d-76e0-9057-c7256023beb2@suse.de \
--to=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox