From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 97534 invoked by alias); 4 Sep 2017 12:36:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 97321 invoked by uid 89); 4 Sep 2017 12:36:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 04 Sep 2017 12:36:14 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 518D43E2A1; Mon, 4 Sep 2017 12:36:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 518D43E2A1 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9717F8E79D; Mon, 4 Sep 2017 12:36:12 +0000 (UTC) Subject: Re: [PATCH 3/3] Add tests for loop_break and loop_continue commands To: Simon Marchi , gdb-patches@sourceware.org References: <1504388179-579-1-git-send-email-simon.marchi@ericsson.com> <1504388179-579-4-git-send-email-simon.marchi@ericsson.com> From: Pedro Alves Message-ID: <3fad43f4-0969-4d11-a361-1ba48d856c2e@redhat.com> Date: Mon, 04 Sep 2017 12:36:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1504388179-579-4-git-send-email-simon.marchi@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-09/txt/msg00039.txt.bz2 On 09/02/2017 10:36 PM, Simon Marchi wrote: > I grepped the testsuite for loop_break and loop_continue and didn't find > anything, so I wrote some simple tests for those. > > gdb/testsuite/ChangeLog: > > * gdb.base/commands.exp: Call the new procedures. > (loop_break_test, loop_continue_test): New procedures. LGTM, please push, and thanks for doing this. I do wonder whether we handle loop_break/loop_continue in nested loops correctly though, since the tests don't seem to exercise that. Thanks, Pedro Alves