From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simark@simark.ca>
Received: from simark.ca (simark.ca [158.69.221.121])
 by sourceware.org (Postfix) with ESMTPS id E68033865493
 for <gdb-patches@sourceware.org>; Mon, 13 Jul 2020 15:48:41 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E68033865493
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=simark.ca
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca
Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net
 [192.222.181.218])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id 37E371E792;
 Mon, 13 Jul 2020 11:48:41 -0400 (EDT)
Subject: Re: [PATCH v2 2/4] arc: Recognize registers available on Linux targets
To: Shahab Vahedi <shahab.vahedi@gmail.com>
Cc: Anton Kolesov <Anton.Kolesov@synopsys.com>,
 Shahab Vahedi <shahab@synopsys.com>, Tom Tromey <tom@tromey.com>,
 gdb-patches@sourceware.org, Francois Bedard <fbedard@synopsys.com>
References: <20200326125206.13120-1-shahab.vahedi@gmail.com>
 <20200428160437.1585-1-shahab.vahedi@gmail.com>
 <20200428160437.1585-3-shahab.vahedi@gmail.com>
 <cc2eb175-7545-ee0e-c62e-74163aee1912@simark.ca>
 <20200617154653.GA2284@gmail.com>
From: Simon Marchi <simark@simark.ca>
Message-ID: <3fa4330d-37b1-f9dd-54b5-a20669366af3@simark.ca>
Date: Mon, 13 Jul 2020 11:48:40 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20200617154653.GA2284@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: tl
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Jul 2020 15:48:42 -0000

On 2020-06-17 11:46 a.m., Shahab Vahedi via Gdb-patches wrote:
> *_register_names are static arrays. That should be why gdb_STATIC_assert
> is used as well. I believe this place in the code is OK for making that
> check.

I meant, could those gdb_static_assert "calls" be moved right next to where the
arrays are defined?

Simon