From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 106568 invoked by alias); 11 Oct 2017 13:05:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 106559 invoked by uid 89); 11 Oct 2017 13:05:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 11 Oct 2017 13:05:30 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 39F96356F6; Wed, 11 Oct 2017 13:05:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 39F96356F6 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 95DD668B3C; Wed, 11 Oct 2017 13:05:28 +0000 (UTC) Subject: Re: [PATCH] Use std::vector for symtab_fns To: Simon Marchi , gdb-patches@sourceware.org References: <1507665661-14742-1-git-send-email-simon.marchi@ericsson.com> From: Pedro Alves Message-ID: <3f6790bb-4a36-2439-dece-42fbaa25b55f@redhat.com> Date: Wed, 11 Oct 2017 13:05:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1507665661-14742-1-git-send-email-simon.marchi@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-10/txt/msg00288.txt.bz2 On 10/10/2017 09:01 PM, Simon Marchi wrote: > Simple replacement of VEC with std::vector. > > gdb/ChangeLog: > > * symfile.c (registered_sym_fns): Make struct, not typedef. > (DEF_VEC_O (registered_sym_fns)): Remove. > (symtab_fns): Change type to std::vector. > (add_symtab_fns): Adjust. > (find_sym_fns): Adjust. OK. > - for (i = 0; VEC_iterate (registered_sym_fns, symtab_fns, i, rsf); ++i) > - if (our_flavour == rsf->sym_flavour) > - return rsf->sym_fns; > + for (registered_sym_fns &rsf : symtab_fns) Small nit: could this be a const ref? I think it's a good rule to prefer const over non-const references if we can. > + if (our_flavour == rsf.sym_flavour) > + return rsf.sym_fns; > > error (_("I'm sorry, Dave, I can't do that. Symbol format `%s' unknown."), > bfd_get_target (abfd)); > Thanks, Pedro Alves