From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id CQ0+Aic+uGmmPywAWB0awg (envelope-from ) for ; Mon, 16 Mar 2026 13:30:15 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=Na5hzxcN; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 034151E08C; Mon, 16 Mar 2026 13:30:14 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 85E981E08C for ; Mon, 16 Mar 2026 13:30:14 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 1CEA84B9DB49 for ; Mon, 16 Mar 2026 17:30:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1CEA84B9DB49 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=Na5hzxcN Received: from YQZPR01CU011.outbound.protection.outlook.com (mail-canadaeastazlp170100000.outbound.protection.outlook.com [IPv6:2a01:111:f403:c104::]) by sourceware.org (Postfix) with ESMTPS id E917A4B9DB49 for ; Mon, 16 Mar 2026 17:29:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E917A4B9DB49 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E917A4B9DB49 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c104:: ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1773682187; cv=pass; b=uYTHexRU468lpEXsPxm1loncbDBjMTG1tjaMxtKFkWqsuHlk8XtTY7+7W0YkdtFnKhged/Sa0Vni0ADUdzfMWkhKMW2zFQLLsKycuMX+TxrXaNFBSZwYiEaA7DxoDCgeriApTpnU7wTTcFhTEBaU/xtRNvCD4O8FRZYZkJN05XA= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1773682187; c=relaxed/simple; bh=F1zdhd+EIPNP87c+hL8qYTvuq/B2/xClMj16AQA5spc=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=SGAKkbDGO4RmwxHO475i6n1NUOLzpm38FYilY8rFlkEYmgTXON/Vy6tBc3zkrTQhrgfIAolfQZ3kpGZ66LxAaxZ5e+aOUowJJkmk8XOjnf6QQhCHiGSvIqcLOY7uuxoEaQShVyoHSfV9WHwfs0WrIBXxmbwOAtH8nZV5OqM4VuY= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E917A4B9DB49 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qaRiufuwswnhD2me5pFBXd9e2XmI/QP2EAznGb1Gtu/oODxBiXegpopaQ8i+zXq21FVptguJpQci6fF8ADChfqY/WtsVYtJdMTFZzfzrBJ3MTXnk5xPeps9YSpPi75nGgvYajexLcho0VOvXQuiJD/oZ+irQwsB8qvsXVhc/jfzJ6moiHuutrSPbQQtMWgP85IVeeT8/n7xNe13zi8FnLG+wV1SK+i9dXqEMET1aovBhP7f0xS8VTwudqR8lP5p1e+Sfaez2S4iEW0EXM6m9j2cTKPHVSTKG/5Z/ymJ3Ym60clUhuYEUY6QbAim8VL7in2G7KnjcPYYpbIItmAtloA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7NsgRJUV42P5ufIckOg+4DFonakdk3k80UAf081aoXE=; b=ec6HkViewAmGcIby8tRNM2kRzAShIIIj2maNXSJZ34lf3o+Ve3vmRnrtd1nJx8OSmpRc2vrveIOyqdDKzsDrfL7/IM6nSRGw/w8v2A2HvSCT5O3aA5gVnHw7VXYE/jJU3YiNbqJZFJz6zB9ahkXa3cj7NBlp8dec+E1pIiPbo8ls6XHt39zWuPfFfvj9uwvjVKBxgZwyeIfMia80NduJWU71CuDd/Ws6mX6NjeAhia5wFQiFCm8x291usvXB6d/n5ZeiK/dmcg1HycO7IDnEuyrno+imV8wdOgFLd8Xfum3+5yiY+jUpPZ6XG6lRD8Rde8eAtLDW1FTWSSKCTv4fNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7NsgRJUV42P5ufIckOg+4DFonakdk3k80UAf081aoXE=; b=Na5hzxcNxeWpfH7IVtpVuAHAmt3ETRVFkKcY8NjcsnHbi+tF/ouZh6Oy3cmt6lHZVE+6TUXbsqAa7hU7QYS60Ku4my8kxVfYqt3wLEv55yiSAgpyUBscsMaE3Ca+zVpvvAb9FvwWg5hrJICLIdUWFyGSfykHPtIm/Fg7YbOBDdl6BHk7wixUYim8ReGG+Db+uWFfzPNQAkjB4fZaUCw8EBXsRrndqBr42AfIXPDBCOi/WZLYvoyvXsGJs1dUUV/nWlb5Ae0s2z+q6Q0LABaGJg4A7TZMAiPNjKZjC3HT42K3ykY+epp9Xyy8AhbbIN+e16KlAWFc1ewIiAWSf/W7Lg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2c::6) by YT3PR01MB8163.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:9c::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9700.25; Mon, 16 Mar 2026 17:29:44 +0000 Received: from YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM ([fe80::bbfa:179f:fdc8:b15d]) by YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM ([fe80::bbfa:179f:fdc8:b15d%5]) with mapi id 15.20.9700.024; Mon, 16 Mar 2026 17:29:42 +0000 Message-ID: <3f37c7de-b6e0-44e2-bd5e-55e1166f438b@efficios.com> Date: Mon, 16 Mar 2026 13:29:38 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb, gdbserver, gdbsupport: replace many uses of strcmp with streq To: Andrew Burgess , gdb-patches@sourceware.org References: <20260316152335.66981-1-simon.marchi@efficios.com> <87h5qf7kwk.fsf@redhat.com> Content-Language: fr From: Simon Marchi In-Reply-To: <87h5qf7kwk.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YT4PR01CA0337.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:fc::12) To YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2c::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YQXPR01MB5418:EE_|YT3PR01MB8163:EE_ X-MS-Office365-Filtering-Correlation-Id: ed044589-3256-4a5b-ab7d-08de83819a9b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|366016|56012099003|18002099003|22082099003|7053199007; X-Microsoft-Antispam-Message-Info: 2yXxfXkKQerWypcQr00caFWEtDw1+FxCOMUJzROfJ7U3rD0HtFd0t91147nlM7rnQl8hyn0ztjQ0jLnuX9+ShLTPPflKFKdiUd258WjbHnMOjSG4FJO44kIOvqGAedc/V/xclmo4yJHbmnaaeibHnPORCiEyWlrI1U8gM5QRU6QKoTiaEyn48PjYFu1ZdwavMlitpFhmuLtgyBLDAyObFPhsBYamq7cqzRN1x6Yw2tiomX8afPTdhfcsu+lQKqCb+sh8+/AqL+b0GaE4AUNo+5s2CnWjZTtEkhwzx3cZhIoOOCIRej6Dc9deF8+wkA8JsfMhswp5b7XoO2/yJJ/XCFp6Q7QumaRjypZ9wTt9xCMioU7UtrtU36uQ4yKEiP7cEj+mIUEnw8Lef7XaeOR3ReRvGXsLBHYMDHPshxEuqbgjxT7r6juqmFO1RkcIH4VvXNM+iLCyYjyrFGA6QrzWVn9PtuiS7/jhdh/iEu4xM+C21lhpexmjeAq4xZ9hLcEspoKsVUZ+KbPv+YaZGFaUnDUQcjrREENekH5Ivw6bVM2jfjjlKaCwR286CdYrat9IrgROdWhpRxCA/66+PnT3J58r+KJgYTtzrrs0FM4h8MUy6SXc5kocHnWEWDvCxOeA80TRowGqUb6nA1/4uKol4iU4kKklbVobve0USCMKkP/7pgJyODr6E7WJDu/lJkmrla9bBrQh7TBRCWvsWzBWGBZXn7GMqYnbDV87ZwalXGg= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016)(56012099003)(18002099003)(22082099003)(7053199007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dWliQUkyYmptMnZINURtUXRNbm0wMkJuNGZSaDhzMzFGYjk0OTc4bklRNW1Q?= =?utf-8?B?S21zSTNIYnI4YUlnYjVNZHpoeW5JUU9XTlFWMTErNUNiZjJxc2QyQ3BTVkR3?= =?utf-8?B?bHpYUFNqdTQ0YS9rOTRUamxrQjZVU2ovMVQ0Z1pqQ2EyNFlJTjF4S0RWOTgx?= =?utf-8?B?eGljT2RKTnZ0OHgxNmQ4NHhoK3p5Z1gzNGczVUdTSWE0Qm1sd2hJWTZyWEJw?= =?utf-8?B?OE1UenZDWVZUUkxjTHptS0phamIzenV0UCtkeGNCMWU5UDNuQ1o5Qjl0TXF4?= =?utf-8?B?SG1Oc09FelRHQk9CNmtVOHBhc2Zwc045OGxNM3hJUWxrUWN2Y1hVK05QYWkr?= =?utf-8?B?Y0I4V00yYnAvVGI1VG1xSFlPY0R5YlZZcDZWMHlSd1Zqa2d0UFhnRGphdXZy?= =?utf-8?B?U3FaS1Q4RVhUU1ZUSlRMc3ZRLzJYUUlpWVdJUTJsblNHMHpBWGplUHBvQ2Fz?= =?utf-8?B?TFhRWVJvSWxoVW9jYVNFQVhoMXNNbmhvb28rTm00L1M2VHZtUnpkakgycjJU?= =?utf-8?B?YzB1aFZRTm4xT3VDZk91Z3NYSjYvZkMwMkdzU2tLd0RwTDhQTmd2TGdZZHNi?= =?utf-8?B?UzFSVGppbm5HMkd3S0UrNVM4aHYyZ0NINWdnSXZCdjk2ck5HQVlNUlZMc2FU?= =?utf-8?B?NVBzN0ZMWGt2Y2hqTWR1SGgrS0o0ZzJPQ1NMaGswTnhxQXJxaTZCNzhieWs4?= =?utf-8?B?YjZ1SE5iRUxkZkcxRVB2aTZ3d3BPeS9HQ3g5OFczYWNCWEdTc241dy9iN01W?= =?utf-8?B?TGdLUnRZMElxcWxDTVpQaURhRWNwTTlSY3Z1RVJOVzFVVlBRNFlBdERuenU3?= =?utf-8?B?V25Gdkxrd2p5Q3ZIV1VMM09rM0hpd04xdldmenFNa2NYZ2RPaWxhSFJOc2hy?= =?utf-8?B?TVAreVlub25hNW55T2V0QS9iZE82RTRKanNJMU1pOXZrd2xZNWVWSHZuNXBT?= =?utf-8?B?TnIwS0pVcmhtcFc4RDZrekpaazRHRE9SaEZvTERmRGU4R0pyR3ZSWVdkMXVX?= =?utf-8?B?cVMxM0JIV0xtdmIyajhSQnJtL2tjNCtPeGRHaWJKRi9NdUd4T1FUNlAzbW9Q?= =?utf-8?B?NjlBVnc4enRSMk1Ua3RYS1VHbXU4YTRxUnRRZ2ZEdFZXUU9KZm9TQlBFWVNj?= =?utf-8?B?MGJ0Nndya3FHeVNnZHFGSDZpWTY5S1NzSzVmL0JjOXd3eWZUbFR1eXUwN1BZ?= =?utf-8?B?UU5ibXNUOGZnQUMxQzVSMDBEdmNOZllNUUwxdlloOWJOT2hkRCtBd2VCQ3pW?= =?utf-8?B?ZlNNd00yd0Mrc01jRHQ4ejRJeGpYZWJvWjVJYW9MRnJlTS9NdHpuNUUxdUJB?= =?utf-8?B?TmsyWldZdHVKQXFqN2g0UVZXS2R0UlFaR2NQQ212UE4vbWU4M3owY1l2RTE2?= =?utf-8?B?ZFdHbWRSclAxa2pWUEpEbHZSbm9wVUEwTW1mR0dBUGNPSGlVTHc4YklnUXRN?= =?utf-8?B?OUo5WWVqNit3ZmtKN2xiT3pEOEdBV0JQckRORStIdTU1bnJETzloaG54YWRr?= =?utf-8?B?YzJIRVJlOTVGVnlNQktXcG0wa2czWDMwZHROcW5QS3FKcG1SYlplSlNva3Vk?= =?utf-8?B?Y3V5RjliVEUxeXo5WndiY1ZlaHV4RFloUkxUemlVSTllNkt0QWR5RURPb2w5?= =?utf-8?B?RXdWLzN2QzliaE01dnJTbVBrRmhTTUVwMml5TmRpd0xHUEwrQTRNcWJHd0hJ?= =?utf-8?B?cmkxTXpzR25tWWVidzlhMjlsMUd2a2dHLzJNUlE0MTc4QkpMWmNkdXlGQTdv?= =?utf-8?B?OWZycUE0eXZ0dWRVRk01aHdaeG0vN2IxbWF1UXlwdHFCb2ZiQUY4UGZmNlNF?= =?utf-8?B?S2RaME90NXh1MTBxb0d5UDdXOXI5TUhLQzZCOEVQdUlqekJzaStqb3RiOHlN?= =?utf-8?B?cmJZQnQvSndRTDNLRmpEdG0xelQrcmdlQ1VzSGhRYURReVJqMXBKRWVoVTZo?= =?utf-8?B?dERnbjY2c0dTMTF1YjlpSjQ3dzF3Y0o0cEJBcGJtKzE3YUFmTWVHMmhwTXRU?= =?utf-8?B?cWttVEVoNkR0blpVSm41VFlDbU8yMkIyUmcwd2lYeXZleSs5WWxnNDJ2VGo0?= =?utf-8?B?am8yYXdLRDFNRkhPclloaUYwY3BjVXVoRVdqUi8wQmNaaVBlQUl1V0JCNDZD?= =?utf-8?B?c2NCNUtSbzdoaGZxNkd5TVNFVkhBcGpJcHE4cC9uS0p0UGlmQm9LK09wd3lZ?= =?utf-8?B?YzR5czFJb2dUVFJKajdmTkdDZ0ltTThEWUx0RGxYeGRTRlVNdUUwOGk2dHZG?= =?utf-8?B?S0FZUkpHMDEweFAwWXpMWGs5UCttKzdvSEJFemFmR0JmZ2JLc3Vha0NaZnhk?= =?utf-8?B?bGdNQWVOWWlHWURuOVYrRlpLWkhham1HUFdPTVBMdVhBa2QvMGRJUT09?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: ed044589-3256-4a5b-ab7d-08de83819a9b X-MS-Exchange-CrossTenant-AuthSource: YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2026 17:29:41.9452 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Dq8psFZ+PrNKi+MjAwXBP28X6QvnNoWBmt2GIywrJGF52N/sJf9eWjJJNftY9uVaZICxFj+pBTuaWFGUW88KCw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT3PR01MB8163 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 3/16/26 1:18 PM, Andrew Burgess wrote: > Simon Marchi writes: > >> Replace all occurrences of: >> >> strcmp (...) == 0 >> strcmp (...) != 0 >> !strcmp (...) >> 0 == strcmp (...) >> strcmp (...) directly used as a boolean predicate >> >> with the equivalent expression using streq. >> >> This is for consistency (we already use streq as some places in the >> testsuite) but also for clarity. I think that streq is clearer on the >> intent than strcmp. It's also a bit shorter. > > I haven't looked through every line of this patch, life's too short :) > But I took a random sampling and it all looked good. I agree with the > intent here, so: Thanks for checking. The change was very mechanical. I also had it reviewed by my buddy Claude Code, which would be good at spotting some silly mistake that would reverse the logic of a condition. > Approved-By: Andrew Burgess Thanks, pushed. Simon