From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30847 invoked by alias); 10 Oct 2017 19:10:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30838 invoked by uid 89); 10 Oct 2017 19:10:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 10 Oct 2017 19:09:59 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id v9AJ9q9D011936 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 10 Oct 2017 15:09:57 -0400 Received: by simark.ca (Postfix, from userid 112) id E535F1E53E; Tue, 10 Oct 2017 15:09:52 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 3FCCA1E523; Tue, 10 Oct 2017 15:09:52 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 10 Oct 2017 19:10:00 -0000 From: Simon Marchi To: Pedro Alves Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH] get_integer_valueof: Don't output value in test name In-Reply-To: References: <1507661462-32717-1-git-send-email-simon.marchi@ericsson.com> Message-ID: <3f236d6d5d260cb6124a02db0fa1122a@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.0 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 10 Oct 2017 19:09:53 +0000 X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00258.txt.bz2 On 2017-10-10 15:02, Pedro Alves wrote: > On 10/10/2017 07:51 PM, Simon Marchi wrote: >> The get_integer_valueof outputs the value it has read as part of the >> test name. This causes test names to vary from run to run, and adds >> some noise when diffing test results. e.g.: >> >> -PASS: gdb.threads/process-dies-while-detaching.exp: multi-process: >> continue: killed outside: get integer valueof "mypid" (28770) >> +PASS: gdb.threads/process-dies-while-detaching.exp: multi-process: >> continue: killed outside: get integer valueof "mypid" (32238) > > Ideally, test result diffing tools would be ignoring > " (foo)" at the end test names, because that part is > not considered a part of the test name itself. It's > extra info. That's where we write "(timeout)", "(eof)", > etc. So for instance: > > -PASS: gdb.threads/process-dies-while-detaching.exp: multi-process: > continue: killed outside: get integer valueof "mypid" > +FAIL: gdb.threads/process-dies-while-detaching.exp: multi-process: > continue: killed outside: get integer valueof "mypid" (timeout) > > ... this should be considered a regression, instead of a new FAIL and > a missing PASS. > > I think the buildbot diffing script is correctly ignoring that > tail end "(foo)"s. > > That said, I think it's still a good idea to make the gdb.sum output > more stable across passing runs, so that plain /usr/bin/diff also > works reasonable well. Right, that's the idea. >> >> This patch removes that, since it's probably not very useful. > > Since we can find the number in gdb.log if we need it, this > is fine with me. Thanks, I'm pushing it. Simon