From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id pzWkEcp/wl89bQAAWB0awg (envelope-from ) for ; Sat, 28 Nov 2020 11:50:18 -0500 Received: by simark.ca (Postfix, from userid 112) id 419131F0AC; Sat, 28 Nov 2020 11:50:18 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8F0C41E99A for ; Sat, 28 Nov 2020 11:50:17 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5D566384A030; Sat, 28 Nov 2020 16:50:16 +0000 (GMT) Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 249743858C27; Sat, 28 Nov 2020 16:50:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 249743858C27 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id C79C21E552; Sat, 28 Nov 2020 11:50:08 -0500 (EST) Subject: Re: [PATCH] GDB: Fix detection of ELF support when configuring with -Werror To: Tom Tromey , Alexander Richardson via Binutils References: <20201111092021.5428-1-Alexander.Richardson@cl.cam.ac.uk> <52dc77e4-ff34-be60-13af-f580d3cf77e7@simark.ca> <76418730-3d48-b0f1-b5cc-5626d3c2feae@redhat.com> <87r1oogh1n.fsf@tromey.com> From: Simon Marchi Message-ID: <3f21122f-d27d-ede3-a99f-f58352832859@simark.ca> Date: Sat, 28 Nov 2020 11:50:08 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <87r1oogh1n.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org, Alexander Richardson Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2020-11-20 10:54 a.m., Tom Tromey wrote: >>>>>> "Alex" == Alexander Richardson via Binutils writes: > > Alex> I was configuring GDB with -Werror=implicit-function-definition in > Alex> CFLAGS and the --disable-werror configure argument. > Alex> I've dropped that flag from my build scripts for now, but I would like > Alex> to add it again if this patch is accepted. > > It's kind of lame that we can't (AFAIK) specify one set of flags for > configure and another set for the build itself. Maybe this could be > added to the top-level Makefile somehow. I don't know, having multiple set of flags would make it even more confusing I think. And it would be risky to have configure take some decisions based on some set of flags and compile the code using some different set of flags. Anyhow, I've pushed Alexander's patch, since it can't really hurt and it fixes the problem for now. I adjusted the commit message a bit to mention explicitly that it was caused by -Wimplicit-function-declaration (it's mentioned in the compiler error message, but I think it's good to make it clear, in case someone tries to reproduce the problem). Simon