From: Luis Machado <lgustavo@codesourcery.com>
To: Pedro Alves <palves@redhat.com>, <gdb-patches@sourceware.org>
Cc: <sandra@codesourcery.com>
Subject: Re: [PATCH, v4] PR 20569, segv in follow_exec
Date: Tue, 25 Oct 2016 18:31:00 -0000 [thread overview]
Message-ID: <3ecde577-fd7b-78ed-3d41-2777301cd390@codesourcery.com> (raw)
In-Reply-To: <90c686ab-090e-fead-5a72-a5d507b50ab7@redhat.com>
On 10/25/2016 01:20 PM, Pedro Alves wrote:
> On 10/25/2016 07:15 PM, Luis Machado wrote:
>
>> Before i go ahead and adjust this even more, what's your plan and ETA
>> for the above?
>
> I'll try to post this today.
>
Sounds good.
>> This is disturbing more code as we try to consolidade
>> slightly different functions into a single one in order to make things a
>> bit more clean. But i'm afraid this is besides the point of the original
>> patch itself?
>>
>> I just want to understand what's the end goal, because the scope seems
>> to be changing slightly with each iteration. :-)
>
> No, the scope has not changed at all. Your original version duplicated
> a large chunk of code, and then the attempt to refactor things did it
> incorrectly. Still the same scope, but the patch as is, is buggy.
>
> Between accepted duplicated code, and fixing the patch, I take the latter.
Fine by me.
Thanks,
Luis
next prev parent reply other threads:[~2016-10-25 18:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-25 17:12 Luis Machado
2016-10-25 18:04 ` Pedro Alves
2016-10-25 18:16 ` Luis Machado
2016-10-25 18:20 ` Pedro Alves
2016-10-25 18:31 ` Luis Machado [this message]
2016-10-25 19:41 ` Luis Machado
2016-10-25 19:46 ` Pedro Alves
2016-10-25 19:50 ` Luis Machado
2016-10-25 23:40 ` [PATCH v5 2/2] " Pedro Alves
2016-10-26 14:28 ` Luis Machado
2016-10-26 16:05 ` Luis Machado
2016-10-27 14:09 ` Pedro Alves
2016-10-25 23:40 ` [PATCH v5 1/2] Make symfile_add_flags and objfile->flags strongly typed Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ecde577-fd7b-78ed-3d41-2777301cd390@codesourcery.com \
--to=lgustavo@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=sandra@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox