From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id CBDUHafGkmH5PAAAWB0awg (envelope-from ) for ; Mon, 15 Nov 2021 15:44:23 -0500 Received: by simark.ca (Postfix, from userid 112) id 779601F0C1; Mon, 15 Nov 2021 15:44:23 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_DYNAMIC, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id AC7861EDEE for ; Mon, 15 Nov 2021 15:44:22 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F0A9E385800A for ; Mon, 15 Nov 2021 20:44:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F0A9E385800A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1637009062; bh=qXY28ItnYEtcj1Z+3pfMlMjZD5lsphKzW67KbwpQvVE=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=vE0Fn3nHVaN9NNBt13PBb5QU/uBPbZOHMudpYSBXVB3zrfzjCsBXGnpaAy4rCvSJ4 iPCqYUCzzPyKH/9BVPNhySRQoNdEvjLq2cvJMlC/BYlfuns/OW1RPr2NaMDx/vXByS mVTxWGdkypcMF/9YIKtz5wQXGPle1dPvNO9ta2lM= Received: from mail.efficios.com (mail.efficios.com [167.114.26.124]) by sourceware.org (Postfix) with ESMTPS id 231163858018 for ; Mon, 15 Nov 2021 20:43:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 231163858018 Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id CE7F0398113; Mon, 15 Nov 2021 15:43:57 -0500 (EST) Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 1p30GiPwuwMk; Mon, 15 Nov 2021 15:43:57 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id 51DF2398111; Mon, 15 Nov 2021 15:43:57 -0500 (EST) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.efficios.com 51DF2398111 X-Virus-Scanned: amavisd-new at efficios.com Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id L6wmSj0a_TIi; Mon, 15 Nov 2021 15:43:57 -0500 (EST) Received: from [172.16.0.95] (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) by mail.efficios.com (Postfix) with ESMTPSA id 15F74398110; Mon, 15 Nov 2021 15:43:57 -0500 (EST) Subject: Re: [PATCH] gdb: fix gdbarch_tdep ODR violation To: will schmidt , Simon Marchi , Luis Machado , gdb-patches@sourceware.org, John Baldwin References: <20211112204233.4108340-1-simon.marchi@efficios.com> <6f000cddd5fa3bb69f7321667a3aab83225531e9.camel@vnet.ibm.com> Message-ID: <3eb3037d-2d40-d156-a8df-1c0447a9efaf@efficios.com> Date: Mon, 15 Nov 2021 15:43:56 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <6f000cddd5fa3bb69f7321667a3aab83225531e9.camel@vnet.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: tl Content-Transfer-Encoding: quoted-printable X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2021-11-15 3:42 p.m., will schmidt wrote: > On Mon, 2021-11-15 at 11:29 -0500, Simon Marchi wrote: >> On 2021-11-15 5:45 a.m., Luis Machado via Gdb-patches wrote: >>> LGTM >> >> Thanks to you and John for taking a look, I pushed the patch. >> >> Simon >> >=20 > Hi,=20 >=20 > I'm now seeing a build failure on powerpc. (specifically ppc64le, but > i'm not sure it will matter which powerpc variant).=20 >=20 > First failure is=20 >=20 > ... > CXX ppc-linux-nat.o > ppc-linux-nat.c: In function =E2=80=98int ppc_register_u_addr(gdbarch*,= int)=E2=80=99: > ppc-linux-nat.c:658:22: error: =E2=80=98struct gdbarch_tdep=E2=80=99 ha= s no member > named =E2=80=98ppc_gp0_regnum=E2=80=99 > 658 | if (regno >=3D tdep->ppc_gp0_regnum > ... >=20 >=20 > Assorted other no-such-member errors follow.=20 >=20 >=20 >=20 > Thanks, > -Will >=20 Yeah, I kind of forgot to look for uses of gdbarch_tdep in native files, which are not built by default on x86-64 :(. I'm working on a patch to fix all of them. Simon