From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8418 invoked by alias); 27 Feb 2018 00:07:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8384 invoked by uid 89); 27 Feb 2018 00:07:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=Palo, palo, blvd, Blvd X-Spam-User: qpsmtpd, 2 recipients X-HELO: homiemail-a122.g.dreamhost.com Received: from sub5.mail.dreamhost.com (HELO homiemail-a122.g.dreamhost.com) (208.113.200.129) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 Feb 2018 00:07:41 +0000 Received: from homiemail-a122.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a122.g.dreamhost.com (Postfix) with ESMTP id 9918C60001102; Mon, 26 Feb 2018 16:07:39 -0800 (PST) Received: from [192.168.20.41] (c-73-170-242-219.hsd1.ca.comcast.net [73.170.242.219]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: eager@eagerm.com) by homiemail-a122.g.dreamhost.com (Postfix) with ESMTPSA id B7E4260001B04; Mon, 26 Feb 2018 16:07:23 -0800 (PST) Subject: Re: [PATCH] [Microblaze]: PIC Data Text Relative To: Andrew Guirguis Cc: gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org, binutils@sourceware.org References: From: Michael Eager Message-ID: <3ea62194-f081-0d2e-13f4-5884f1615e37@eagerm.com> Date: Tue, 27 Feb 2018 00:07:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg00407.txt.bz2 On 02/25/2018 11:44 PM, Andrew Guirguis wrote: > Dears, > > Kindly find attached the patch bundle for Microblaze > '-mpic-data-text-relative' feature. > > Description of the feature in the following link: > https://github.com/andrewsadek/microblaze-pic-data-text-rel/blob/pic_data_text_rel/README.md > > > Bundle includes: > 1) Change logs for GCC, binutils > 2) GCC Test results and comparison with the original. > 3) New Test case (picdtr.c) > 4) The Patches (against current heads) Hi Andrew -- Thanks for the submission. I have the following recommendations: Submit each patch to the appropriate project mailing list. Only submit the patch for the specific project, without patches for other projects. Include a description of the changes with each patch as well as the changelog. Include the patch in your email or as an attachment. It isn't clear why you sent your submission to the gdb-patches mailing list, since there don't appear to be any GDB changes. Conversely, it is not clear why you did not include the binutils mailing list, since you include a patch to that project. Be sure to follow GNU coding conventions, Check brace placement, indent, maximum line length, if statements, etc. I noticed a number of places where these conventions are not followed in your patches. GCC regression tests should include all tests (e.g., gcc.dg), not just the limited number of MicroBlaze-specific tests. -- Michael Eager eager@eagerm.com 1960 Park Blvd., Palo Alto, CA 94306