From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 47122 invoked by alias); 13 Jun 2018 11:19:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 47107 invoked by uid 89); 13 Jun 2018 11:19:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.2 spammy=columns, H*RU:sk:NAM04-C X-HELO: sessmg23.ericsson.net Received: from sessmg23.ericsson.net (HELO sessmg23.ericsson.net) (193.180.251.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 13 Jun 2018 11:19:40 +0000 Received: from ESESSHC006.ericsson.se (Unknown_Domain [153.88.183.36]) by sessmg23.ericsson.net (Symantec Mail Security) with SMTP id 12.4F.22015.9CDF02B5; Wed, 13 Jun 2018 13:19:37 +0200 (CEST) Received: from ESESBMR502.ericsson.se (153.88.183.134) by ESESSHC006.ericsson.se (153.88.183.36) with Microsoft SMTP Server (TLS) id 14.3.382.0; Wed, 13 Jun 2018 13:19:36 +0200 Received: from ESESBMB504.ericsson.se (153.88.183.171) by ESESBMR502.ericsson.se (153.88.183.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Wed, 13 Jun 2018 13:19:36 +0200 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (153.88.183.157) by ESESBMB504.ericsson.se (153.88.183.171) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Wed, 13 Jun 2018 13:19:35 +0200 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [10.0.0.110] (192.222.164.54) by DM6PR15MB2395.namprd15.prod.outlook.com (2603:10b6:5:8d::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.863.14; Wed, 13 Jun 2018 11:19:33 +0000 Subject: Re: [RFA] Fix/improve on-line help of 'define' command. To: Philippe Waroquiers , References: <20180604213136.32395-1-philippe.waroquiers@skynet.be> From: Simon Marchi Message-ID: <3ea57d42-da87-c109-104f-9b2ac6db3fc8@ericsson.com> Date: Wed, 13 Jun 2018 11:19:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180604213136.32395-1-philippe.waroquiers@skynet.be> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YTXPR0101CA0039.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b00:1::16) To DM6PR15MB2395.namprd15.prod.outlook.com (2603:10b6:5:8d::29) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 42138896-9303-4061-0377-08d5d11f8a8d X-MS-TrafficTypeDiagnostic: DM6PR15MB2395: X-Exchange-Antispam-Report-Test: UriScan:(209352067349851)(235404470278024); X-MS-Exchange-SenderADCheck: 1 X-Forefront-PRVS: 07025866F6 Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2018 11:19:33.7418 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 42138896-9303-4061-0377-08d5d11f8a8d X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR15MB2395 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2018-06/txt/msg00325.txt.bz2 On 2018-06-04 05:31 PM, Philippe Waroquiers wrote: > While I was playing with 'define' to understand how some quoting was > done (or not done), I found an inconsistency between the doc > and the online help. > => the doc is correct, so fixing/improving the on-line help. > > 2018-06-04 Philippe Waroquiers > > * cli/cli-script.c (_initialize_cli_script): Fix online documentation > of 'define' command. > --- > gdb/cli/cli-script.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/gdb/cli/cli-script.c b/gdb/cli/cli-script.c > index 72de8ec1c7..8ceecdf435 100644 > --- a/gdb/cli/cli-script.c > +++ b/gdb/cli/cli-script.c > @@ -1602,7 +1602,8 @@ Define a new command name. Command name is argument.\n\ > Definition appears on following lines, one command per line.\n\ > End with a line of just \"end\".\n\ > Use the \"document\" command to give documentation for the new command.\n\ > -Commands defined in this way may have up to ten arguments.")); > +Commands defined in this way may accept an unlimited number of arguments\n\ > +accessed via $arg0 .. $argN. $argc tells how many arguments have been passed.")); Two spaces after period, keep the length <= 80 columns. Otherwise, LGTM. Simon