From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17207 invoked by alias); 9 Feb 2017 13:00:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13175 invoked by uid 89); 9 Feb 2017 13:00:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=sk:referen X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 09 Feb 2017 13:00:09 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EA31CC0740E3; Thu, 9 Feb 2017 13:00:09 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v19D08Bg009582; Thu, 9 Feb 2017 08:00:09 -0500 Subject: Re: [RFA 3/5] Introduce gdbpy_subclass and use it to simplify some logic To: Tom Tromey , gdb-patches@sourceware.org References: <20170115134253.24018-1-tom@tromey.com> <20170115134253.24018-4-tom@tromey.com> From: Pedro Alves Message-ID: <3e9558d8-466a-60e2-003b-aaaa485f1e94@redhat.com> Date: Thu, 09 Feb 2017 13:00:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170115134253.24018-4-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-02/txt/msg00221.txt.bz2 On 01/15/2017 01:42 PM, Tom Tromey wrote: > diff --git a/gdb/python/py-ref.h b/gdb/python/py-ref.h > index b2479bf..3430768 100644 > --- a/gdb/python/py-ref.h > +++ b/gdb/python/py-ref.h > @@ -1,6 +1,6 @@ > /* Python reference-holding class > > - Copyright (C) 2016 Free Software Foundation, Inc. > + Copyright (C) 2016, 2017 Free Software Foundation, Inc. No sure the end-year script converts this to a range automatically. Better write 2016-2017 from the get go. > /* A gdb::ref_ptr that has been specialized for Python objects. */ > -typedef gdb::ref_ptr gdbpy_ref; > +typedef gdb::ref_ptr > gdbpy_ref; No need for the space in "> >" in C++11. Other than the naming issue, this looks really nice to me. Thanks, Pedro Alves