From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id edKtIJJPr1/MCQAAWB0awg (envelope-from ) for ; Fri, 13 Nov 2020 22:31:30 -0500 Received: by simark.ca (Postfix, from userid 112) id 7E3181F08D; Fri, 13 Nov 2020 22:31:30 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.3 required=5.0 tests=MAILING_LIST_MULTI,RDNS_NONE, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 323F21EFBB for ; Fri, 13 Nov 2020 22:31:30 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7533A3857C5F; Sat, 14 Nov 2020 03:31:29 +0000 (GMT) Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id EFF673857C5F for ; Sat, 14 Nov 2020 03:31:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org EFF673857C5F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id A1E4F1E58D; Fri, 13 Nov 2020 22:31:27 -0500 (EST) Subject: Re: [PATCH 8/8] Move the frame data to the BFD when possible To: Tom Tromey , gdb-patches@sourceware.org References: <20200208152758.29385-1-tom@tromey.com> <20200208152758.29385-9-tom@tromey.com> From: Simon Marchi Message-ID: <3e954756-4ecc-7e86-e1c0-660bfaf7eaf8@simark.ca> Date: Fri, 13 Nov 2020 22:31:27 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200208152758.29385-9-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2020-02-08 10:27 a.m., Tom Tromey wrote: > Now that comp_unit and the remaining frame data are all independent of > the objfile, it can all be stored on the BFD and shared across > inferiors. > > As with other code doing this same thing, care must be taken to not > share the data when the objfile requires relocations. So, two keys > are used: one for the BFD and one for the objfile, and > gdb_bfd_requires_relocations is used to differentiate between the two > cases. FYI, there's a regression linked to this patch. https://sourceware.org/bugzilla/show_bug.cgi?id=26876 Simon