On 11-06-2020 15:55, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
> 
> Tom> This fix uses a load_lib override.
> 
> Tom> Any comments?
> 
> There was a report recently about gdb overrides like this breaking
> with a newer dejagnu.
> 

You're referring to this (
https://sourceware.org/pipermail/gdb/2020-June/048689.html ) ?

> Maybe we need a gdb_load or something like that, instead of
> monkey-patching dejagnu?  Or some other different approach.
> 
> I'm not really opposed to this FWIW.  It seems not likely to cause
> problems.  Though I thought that about the other override too, so..

OK, I dropped the load_lib overload.

Now the idiom is:
...
-load_lib tuiterm.exp
+tuiterm_env
...

I've also tried wrapping the test-case body using the tuiterm_env proc,
like this:
...
tuiterm_env {
  ...
}
...
but ran into curly-braces trouble in gdb.tui/new-layout.exp.

Committed.

Thanks,
- Tom