From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 55983 invoked by alias); 12 Feb 2020 03:36:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 55958 invoked by uid 89); 12 Feb 2020 03:36:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:636 X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Feb 2020 03:36:53 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 1C91F1ED42; Tue, 11 Feb 2020 22:36:52 -0500 (EST) Subject: Re: [PATCH 4/8] Store the comp_unit instead of the FDE table To: Tom Tromey , gdb-patches@sourceware.org References: <20200208152758.29385-1-tom@tromey.com> <20200208152758.29385-5-tom@tromey.com> From: Simon Marchi Message-ID: <3e7284ad-e16a-062a-1084-fad37550c27f@simark.ca> Date: Wed, 12 Feb 2020 03:36:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.2 MIME-Version: 1.0 In-Reply-To: <20200208152758.29385-5-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2020-02/txt/msg00435.txt.bz2 On 2020-02-08 10:27 a.m., Tom Tromey wrote: > @@ -2120,14 +2123,11 @@ dwarf2_build_frame_info (struct objfile *objfile) > const gdb_byte *frame_ptr; > dwarf2_cie_table cie_table; > dwarf2_fde_table fde_table; > - dwarf2_fde_table *fde_table2; > > /* Build a minimal decoding of the DWARF2 compilation unit. */ > - unit = XOBNEW (&objfile->objfile_obstack, comp_unit); > + unit = new comp_unit; Not mandatory, but I'd suggest using an std::unique_ptr here, to hold this variable, and then "release" it into the per-objfile map (since it can only hold bare pointers). Simon