From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id RUdIAGVfb2DVGgAAWB0awg (envelope-from ) for ; Thu, 08 Apr 2021 15:54:13 -0400 Received: by simark.ca (Postfix, from userid 112) id EE4E61EE0E; Thu, 8 Apr 2021 15:54:12 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,RDNS_DYNAMIC, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4D6551E590 for ; Thu, 8 Apr 2021 15:54:12 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D40A73955429; Thu, 8 Apr 2021 19:54:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D40A73955429 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1617911651; bh=DCIdbKzpycHQAS4Rr+HauD+zVh8SwNLc+6ShA2Fg4vk=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=sgh0vYuQZ+tZKAD3dqBJGzVEHgKFW8lz+1Th46hET9+ZwzgI3zR/oWaPsNNLIHTbA riWGHzuBIfjtg2Eo9b+1vYpwNc1d70wqdqtkkWdXkfCp8sVvndZEa4lB94tAufIVYp Xu29nFMj46ODKAl5L+OyqMAxqAYCJEiUbxf/BPec= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 654EA3955426 for ; Thu, 8 Apr 2021 19:54:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 654EA3955426 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 138Js1sO007904 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 8 Apr 2021 15:54:05 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 138Js1sO007904 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 2A03F1E590; Thu, 8 Apr 2021 15:54:01 -0400 (EDT) Subject: Re: [PATCH 3/3] [fix] Skip over WIFSTOPPED wait4 status To: Dominique Quatravaux , gdb-patches@sourceware.org References: <20210408191449.27434-1-dominique.quatravaux@epfl.ch> <20210408191449.27434-3-dominique.quatravaux@epfl.ch> Message-ID: <3e29a651-8aeb-0702-1ab9-e43627d63ee7@polymtl.ca> Date: Thu, 8 Apr 2021 15:54:00 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210408191449.27434-3-dominique.quatravaux@epfl.ch> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 8 Apr 2021 19:54:01 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2021-04-08 3:14 p.m., Dominique Quatravaux via Gdb-patches wrote: > On modern Darwin's, there appears to be a new circumstance in which a > MACH_NOTIFY_DEAD_NAME message can be received, and which was not > previously accounted for: to signal the WIFSTOPPED condition in the > debuggee. In that case the debuggee is not dead yet (and in fact, > counting it as dead would cause a zombie leak - A process in such a > state reparents to PID 1, but cannot be killed). > > - Read and ignore such messages (counting on the next exception > message to let us know of the inferior's new state again) > - Refactor logging so as to clearly distinguish between the three > MACH_NOTIFY_DEAD_NAME cases (WIFEXITED, WIFSTOPPED, signal) > --- > gdb/darwin-nat.c | 15 +++++++++++---- > 1 file changed, 11 insertions(+), 4 deletions(-) > > diff --git a/gdb/darwin-nat.c b/gdb/darwin-nat.c > index 9c6423ceb02..cbe36eba626 100644 > --- a/gdb/darwin-nat.c > +++ b/gdb/darwin-nat.c > @@ -1053,7 +1053,7 @@ darwin_nat_target::decode_message (mach_msg_header_t *hdr, > } > else if (hdr->msgh_id == 0x48) > { > - /* MACH_NOTIFY_DEAD_NAME: notification for exit. */ > + /* MACH_NOTIFY_DEAD_NAME: notification for exit *or* WIFSTOPPED. */ > int res; > > res = darwin_decode_notify_message (hdr, &inf); > @@ -1096,16 +1096,23 @@ darwin_nat_target::decode_message (mach_msg_header_t *hdr, > { > status->kind = TARGET_WAITKIND_EXITED; > status->value.integer = WEXITSTATUS (wstatus); > + inferior_debug (4, _("darwin_wait: pid=%d exit, status=0x%x\n"), > + res_pid, wstatus); > + } > + else if (WIFSTOPPED (wstatus)) > + { > + status->kind = TARGET_WAITKIND_IGNORE; > + inferior_debug (4, _("darwin_wait: pid %d received WIFSTOPPED\n"), res_pid); > + return minus_one_ptid; > } > else > { > status->kind = TARGET_WAITKIND_SIGNALLED; > status->value.sig = gdb_signal_from_host (WTERMSIG (wstatus)); > + inferior_debug (4, _("darwin_wait: pid=%d received signal %d\n"), > + res_pid, status->value.sig); > } > > - inferior_debug (4, _("darwin_wait: pid=%d exit, status=0x%x\n"), > - res_pid, wstatus); > - > return ptid_t (inf->pid); > } > else > Thanks, that LGTM. Let's just way until your copyright assigment is complete. Simon