From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id SZB4OyIljGrWwTsAWB0awg (envelope-from ) for ; Mon, 24 Aug 2026 07:04:03 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=FRmsCIVL; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id EE2151E0A3; Mon, 24 Aug 2026 07:04:02 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 31B6B1E033 for ; Mon, 24 Aug 2026 07:04:02 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5E91B4BA2E29 for ; Mon, 24 Aug 2026 11:04:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5E91B4BA2E29 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=FRmsCIVL Received: from mail-pj2-x09.google.com (mail-pj2-x09.google.com [IPv6:2607:f8b0:4864:39::9]) by sourceware.org (Postfix) with ESMTPS id 136BD4BA2E21 for ; Mon, 24 Aug 2026 11:03:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 136BD4BA2E21 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 136BD4BA2E21 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:39::9 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787569414; cv=none; b=iTmRL7RDEDvlz9/Jkq5qllxQEUu7xUkqwyqmQA82bwwuYFs7MoTFZw0mfKMkFep/Jxn/kd/u5/8EoaoijXYmXRmJHTo6feXivtLaMvwX3Hynh2+udbVvYqCVi5A2UvsObuLRVTo/Ln2Amq9qqxwW2PeeOtzyHad67sHRZiHEOWI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787569414; c=relaxed/simple; bh=InsT1kzvTgkWi/0V1hEoYsCBLuf8rmk/bmS2HUo02Wo=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=HzydPFxIRaHAyfrS9O0ScZVQc1riM/JNSE5PQbO3h9f270pvoJNn39m4bMrf28HHArJn+oob8l0qS6kcz9oUzhawu/eNx+7OY2BU01r+3fKYhqycS7aeLhn/1YksQGXXSBaHwWi4Kt1c6lTkw77Ww7tHScEnrSTrWcWidGJh3YA= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=FRmsCIVL DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 136BD4BA2E21 Received: by mail-pj2-x09.google.com with SMTP id 98e67ed59e1d1-38ed4d37526so1869659a91.1 for ; Mon, 24 Aug 2026 04:03:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787569413; x=1788174213; darn=sourceware.org; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:to:from:subject:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=F+LZ1k5R9VgJWMTwO+ARu+Wx40y8+uc0WMuuUosSFZw=; b=FRmsCIVLYDLbdsB1uXlPq6t9tAK39maAvIHI1R6sZ4lzqDluQhmflFHyKnd6LcE+gd 14jTYMKwEiD/4UIAOHyX45yLs1R13o+ozRe8Mnif59jO5XkaV8Fljj4w9MsmuHkZQEDf 5oJi0HPkIWynlvHU1W8OCfJs6oHdUEYvKmzeskt8UvR3qQJ34Rlmitkr3DKhzJxhCDCx K+IHP+Z9JyAf134I2itMFxXKEdP2ZTBYy4/H453alNsU4PFR+Ka6iQPG0Pfu0XRNxsY5 B+K+aDC6SG+zUg1ltjhwYJfKBaXWvcvJjKufUXvAG9LxKSf4AKXCYjByBfHTghQL+7Ci ugrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787569413; x=1788174213; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=F+LZ1k5R9VgJWMTwO+ARu+Wx40y8+uc0WMuuUosSFZw=; b=YhI/+jIz4+ReGpcJLM5Wlr0rDZDtVzR7ZDTpMGhJv8yLdcKDqQj4vrXsX40K114qcv Xi73ZpcC85ubYUlRqraF9nkTuN1GSblwQYqUJpRQ42/581DgrkyYtId1SQfBsyGdjriY Qtsr7Sg1WMk8lL25GwIYL/mmyF5ZwcuZT0aTlPWPte8pSUpV/k65U85TusF1S5iOlvHi 2vqPuZW3VptYjOHAlefw1oVH69i8OFQdGSxfj/b6C0G1d+o3ca5F3eN4a9ZRrp5017tw x/m1moco0WThhQMZfc/LAbYEsN7mtKFP6VO2+aDLsavzRCum4jMcpY4KKbAbNzAVFWvL 5Xsw== X-Forwarded-Encrypted: i=1; AHgh+RpT/cgXYrJL1ACxB3NKk+eL5miUsolDFvVjYZM06yG+xTsjVYqZRlSNTFZp0X6Xf56M4Cu0QV/vfzSkgw==@sourceware.org X-Gm-Message-State: AFuF++kl9H2A2ugWjSJViizbwPH547qRIwplvJ7yKw3I5bKoVj5Dt9Ln zXVfoWNx1+BTGeG/D7tNUtE1BwobH3trCjQSzDGQGoreobC7LNftjgSw X-Gm-Gg: AR+sD13YQLq+uRDPN9/Pp5KX9jNra2VcKGkxftQCKAQh+lFyingoFUXck+F/+/gSXzH fy3LpaT0cLg3Fw3yBiuSLw7lgqHVm1Fohz2c6XBHu8dWtK/CJ39pIJmdZkZQPjkjJmOldbXU6la ZP8nO90tg1X6W56r33y8YYxlz25vs0gpJDn/1P7/TD826c/Ic4jaY+dT2RHa44Meo5cLWwv+HEX vK5tywVaJ4hW3FveNej1l64mO9ZliJUvN0vYNA+DwHetjlXXGOmFbD+PzgfSpcOknQNIwDL3Ocz hGicWaEwfqxSb8Z69WuC2sHuGerhkZeMcK0MV2HU05MbGit+ldH8nJv9OCbum8RVoGJNBm9pI6x aaRMeAGiBKqYJHEiywVruk1vjVwLHN+uW+NjSR8aHIlSNDIKfYZfXN8SwdAYmPB4PGQbDxvguJq G3hDXhYeHYmLo5PYGhhEOy+fRFdkfrkpJ5CUCZgoMHtVjdY5vlYPVp+RMz0fYfRcO13y/Xxp9+/ fPr6QPK X-Received: by 2002:a17:90b:5790:b0:38e:9045:babe with SMTP id 98e67ed59e1d1-395deecf08fmr34162654a91.7.1787569412843; Mon, 24 Aug 2026 04:03:32 -0700 (PDT) Received: from localhost.localdomain ([2407:c800:3620:e800:7910:9280:8105:5a2]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-395e49e6f59sm9551676a91.12.2026.08.24.04.03.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Aug 2026 04:03:31 -0700 (PDT) Message-ID: <3e1fdbbd9bb63a214c4fe6fe743018a2e302a755.camel@gmail.com> Subject: Ping^1 Re: [SH] Check FPSCR.PR for fldi0, fldi1 insns in simulator From: Oleg Endo To: Simon Marchi , gdb-patches@sourceware.org Date: Mon, 24 Aug 2026 20:03:30 +0900 In-Reply-To: References: <016918b6653a40835d2272c3c37d05b0d7e470b6.camel@gmail.com> <6eb50919-75d8-4725-9afa-e241e4cabab6@simark.ca> <9855a27b-78f6-4d4a-b0f6-04fefcaf7a49@simark.ca> <94f77e9bfecf923cfca8caa5427de7604ebe2fd7.camel@gmail.com> <33b1b794-d592-45e7-9bb7-53a4a9c45607@simark.ca> <1ca6adbf81c1e1eabeb3360d99a1e92b0f450604.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.3 (3.54.3-2.fc41) MIME-Version: 1.0 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Ping On Sun, 2026-08-02 at 22:42 +0900, Oleg Endo wrote: > Hi, >=20 > On Tue, 2026-03-17 at 13:50 +0900, Oleg Endo wrote: > >=20 > > On Mon, 2026-03-16 at 21:19 -0400, Simon Marchi wrote: > > >=20 > > > On 2026-03-16 21:18, Oleg Endo wrote: > > > > On Wed, 2026-03-11 at 10:39 -0400, Simon Marchi wrote: > > > > >=20 > > > > > Ok, well since we're in "undefined behavior" territory we could a= rgue > > > > > that the current sim behavior is fine. But I think the patch is = still > > > > > good, traping is a more useful behavior to catch something you do= n't > > > > > want to happen. > > > >=20 > > > > Yes, the current sim behavior is not wrong per se. But like you sa= id, > > > > having it trap is more useful for sim's main purpose -- pre-verifyi= ng code.=20 > > > >=20 > > > >=20 > > > > > > > The patch LGTM, but I am not a maintainer of the sim, so: > > > > > > >=20 > > > > > > > Reviewed-By: Simon Marchi > > > > > > >=20 > > > > > > > One note, please put the relevant information (the body of yo= ur email) > > > > > > > into the commit log itself). > > > > > >=20 > > > > > > Yeah, sure I can expand the comment of the commit. Updated pat= ch/commit > > > > > > attached. > > > > >=20 > > > > > I would give it a week for Andrew or Mike to review and approve, = but > > > > > otherwise I would feel comfortable merging it. > > > > >=20 > > > >=20 > > > > Alright. Last time I've checked I had write access. I can commit = & push it > > > > myself. Just let me know. > > >=20 > > > Yes, please go ahead. > > >=20 > > >=20 > >=20 > > Thanks. Committed & pushed as 17eb89e3c1cc6098f08e77d257468486a5c04ce4= . > >=20 >=20 > This is a little late, but better than never. >=20 > I've just noticed that running >=20 > make check RUNTESTFLAGS=3D"sh.exp" >=20 > in the sim build dir throws the following errors: >=20 > FAIL: sh fabs.s (execution) > FAIL: sh fadd.s (execution) > FAIL: sh fcmpeq.s (execution) > FAIL: sh fcmpgt.s (execution) > FAIL: sh fcnvsd.s (execution) > FAIL: sh float.s (execution) > FAIL: sh fmov.s (execution) > FAIL: sh fmul.s (execution) > FAIL: sh fneg.s (execution) > FAIL: sh fsqrt.s (execution) > FAIL: sh fsub.s (execution) > FAIL: sh ftrc.s (execution) >=20 > The behavior is correct and as expected. The test cases need to be adjus= ted > to match the fli0/fldi1 behavior. The attached patch fixes this. >=20 > OK to commit & push? >=20 > Best regards, > Oleg Endo >=20 >=20