Re: Breakage on builder Solaris11-amd64-m64, revision 080363310650c93ad8e93018bcb6760ba5d32d1c

[Pedro Alves <palves@redhat.com>]

On 11/25/2018 02:55 PM, Rainer Orth wrote:
> Hi Pedro,
> 
>>>> And the actual commit failed with another reason:
>>>>
>>>> https://gdb-build.sergiodj.net/builders/Solaris11-amd64-m64/builds/411/steps/compile%20gdb/logs/stdio
>>>>
>>>> ../../binutils-gdb/gdb/procfs.c: In function ‘int procfs_notice_thread(procinfo*, procinfo*, void*)’:
>>>> ../../binutils-gdb/gdb/procfs.c:3136:41: error: ‘is_exited’ was not declared in this scope
>>>>    if (!in_thread_list (gdb_threadid) || is_exited (gdb_threadid))
>>>>                                          ^~~~~~~~~
>>>> ../../binutils-gdb/gdb/procfs.c:3136:41: note: suggested alternative: ‘inf_exited’
>>>>    if (!in_thread_list (gdb_threadid) || is_exited (gdb_threadid))
>>>>                                          ^~~~~~~~~
>>>>                                          inf_exited
>>>
>>> this is weird: I still see a declaration in gdbthread.h (and also
>>> is_running and is_stopped), which should go as well.
>>
>> That's because I meanwhile pushed this:
>>  https://sourceware.org/ml/gdb-patches/2018-11/msg00380.html
> 
> I only saw that commit after I'd sent my mail.
> 
>> So before that we got a link error, and now we get a compile
>> error, which is expected.
>>
>>>
>>> With just the typo above fixed, a local build on amd64-pc-solaris2.11
>>> has just finished; make check running...
> 
> It took me a bit to double-check, but the differences in testsuite
> results are within the (usual, mostly thread-related) variations.
> 
> So the patch is ok with the missing parenthesis added.

Thanks much.  I've merged it now.

Thanks,
Pedro Alves