From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id m1nZFapllWosOBcAWB0awg (envelope-from ) for ; Mon, 31 Aug 2026 07:29:46 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=A98ehU/N; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 452661E09B; Mon, 31 Aug 2026 07:29:46 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1F6561E09B for ; Mon, 31 Aug 2026 07:29:45 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E893C4BA7987 for ; Mon, 31 Aug 2026 11:29:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E893C4BA7987 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=A98ehU/N Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 36CD94BA2E1F for ; Mon, 31 Aug 2026 11:29:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 36CD94BA2E1F Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 36CD94BA2E1F Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788175759; cv=none; b=uL/+ij2UsOS2mQdOGoywryT6WPzRl+TW9sUNC1WgmnVVGPSJBiZYUAja9vFUqnuuA+SXTfBSBMALZdqHLxJMPSl1HJD4h6nRQJZcq9Dvw9Y7s9engQHqS7iK4cUD5Y/dF1/eiLcL58yXnn6pXutR8N3BewkdnSFVP9k6S/qxaU4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788175759; c=relaxed/simple; bh=P0qAxyagB67qhKa8mMGo51ce+42SHElAmaAcsXh5Uqk=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=uTVgvIChoNBStyZvxLHznz/4MIWzWipSOLpTzbQQtS6LM+OreSwvTTgN0y2mgC/eolnvXJRcnjkkuXUIFs5UkLl6NhMmUR2p+x4a7KLTXkK0+nC+9tdIJ516IhqYbIKp8Yu05f70wrAUgxku0mq6bP/jsopSX/toGRLqEWi4XpA= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=A98ehU/N DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 36CD94BA2E1F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788175757; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E0yADNdPagOQWOor2iFdgdQUtuGovIfBylTbOuac6pM=; b=A98ehU/Nm9piCPbY28bsnKTXYUd6vF9ao8CDve74zkJq0u88SpBUdzfmxjcmeadeSlE257 gw20+hqVBYuMQ7H1y3CGWeUzsDzyD+cac9SWIDz/DVoDmdnfUaYnaqD+YwRUQV9xwPpQM9 NCg/BxXZhjUjFWFz8RRNwFILXV0yDQQ= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-553-pDjdiB3bO_K8I1rvz1-diw-1; Mon, 31 Aug 2026 07:29:15 -0400 X-MC-Unique: pDjdiB3bO_K8I1rvz1-diw-1 X-Mimecast-MFC-AGG-ID: pDjdiB3bO_K8I1rvz1-diw_1788175754 Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-398dc3d8f0aso1708089a91.0 for ; Mon, 31 Aug 2026 04:29:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788175754; x=1788780554; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=E0yADNdPagOQWOor2iFdgdQUtuGovIfBylTbOuac6pM=; b=oSPQHwuz1Sgz30LfYma9j7230kovjNfGCpY9XC/JRTs8EodLtZ8vq0hKoPlv0SaPa+ ylqnANNb0VETSLb4DO3kNRt9MibDNT6SRhP5TWDLPWn8FGwL+hmnovfPX7VxXl1xVzmJ zEzxEsnGqXQLHrXUnc2GYRvMch+bYCg6Y6Kv72SyIZv5qnZHfO18+jxdyHtHAASgkhCn l7P8r7qATRcGq4H4mSX+l148ZSoJwcVRgmUHsjmdVBKw5SmOazYokz/jTP+fck7FEcsJ WnNYHmpbBwGrJmBx5lPLouN5dO58DHaTo/2j3JSbPxv05MGtOIUV6W9Dnh0/YruX8UdT w4Mg== X-Forwarded-Encrypted: i=1; AKwUvBwSoe7dNrkPSpkLu8cO6ckXtS1n0aYm/6e/B2cG8iJWl7eop1tG2FjVkRJskHfG+9BiQlgfKQc+IFiZRQ==@sourceware.org X-Gm-Message-State: AFuF++k7/zx/8Z2Za5tPrJl4EbWk54pikfmaV/HBcrtbceZVIhGJxR9k BP98qCs+AJWcoaC5DG8dl0amEL2YFCktCmwjcMNWXFOSDvWc94gKfICvvn4qE6b+BQpQV8xsXFR eruCb8rM2FtqS71sSZyHz9vjj1I3Crbi9kck9u0L7GfqJFFg8waBKvUhFVDkXxMI= X-Gm-Gg: AYBFou33WFbQ1GxYMuZbfpdXGleSl2stVqve4Uy3sxqTzvk37CUZQbipJFS4OFHxMGh ke7zbUtbCc0RBQ4rF2Js1roK6jSJH8oWMYrfb5X7OgE1VwwF1rGpJJ46Wzy8dyJ6Sj9LGAi/Itl VFyxrCkLi6KZTCPQY3K9AJB4k+15yjVX5/VvXJmyRDHBd6LLZozLoQRAWWwSVRdhH6Yz8BkRdlw 1JBhhyyguCSmcHa+QvVVY4wZzDEILpgA/YN38+gU867/3ZHQ0Mr53cdbROAVMeO1ZjjxNKADsFk 1SRe1lwrxsWSN/4GoO59jj5wYjwhcIxni7Ys9M094f8bTXavnV3lQH8+WV70/ZVlAfkcgu/EyoL dnT7jAzoMExnblcHrTJyo5Fs1lDl1GQmp0SAOVbqv6C6r8Ru1fw== X-Received: by 2002:a17:90b:2c87:b0:396:669c:b5f6 with SMTP id 98e67ed59e1d1-398da64ddbcmr6608656a91.12.1788175754096; Mon, 31 Aug 2026 04:29:14 -0700 (PDT) X-Received: by 2002:a17:90b:2c87:b0:396:669c:b5f6 with SMTP id 98e67ed59e1d1-398da64ddbcmr6608602a91.12.1788175753484; Mon, 31 Aug 2026 04:29:13 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:993e:22e8:4ed1:527a:55c0? ([2804:14d:8084:993e:22e8:4ed1:527a:55c0]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3286fa37fa5sm32231501eec.29.2026.08.31.04.29.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Aug 2026 04:29:12 -0700 (PDT) Message-ID: <3dd5efa0-1067-4b8c-af08-c68a34014782@redhat.com> Date: Mon, 31 Aug 2026 08:29:09 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/testsuite: Fix supplying a function name to gdb_continue_to_breakpoint To: Kevin Buettner , gdb-patches@sourceware.org References: <20260827203857.206218-1-guinevere@redhat.com> <20260827202830.75248f5e@f44-mesa-1> From: Guinevere Larsen In-Reply-To: <20260827202830.75248f5e@f44-mesa-1> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Us9OBQSKyS3-U5AMrKiiicAM5_24_ZI0e9nYP_0SS5A_1788175754 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Thanks for the quick review, I've pushed this! On 8/28/26 12:28 AM, Kevin Buettner wrote: > On Thu, 27 Aug 2026 17:38:57 -0300 > Guinevere Larsen wrote: > >> The previous regex pattern in gdb_continue_to_breakpoint expects a >> message in one of the following forms: >> Breakpoint N, in >> Breakpoint N, at >> >> And so, checks for either the "in" or the "at" keywords before the >> user-supplied pattern. However, this means that if GDB doesn't stop >> somewhere that requires printing the address, the test can't supply >> the function name when checking for the breakpoint. >> >> This commit adds the possibility of looking just for the comma before >> the user-supplied pattern, allowing the second form of the stop >> message to also accept a function name. > Makes sense to me. > > Approved-By: Kevin Buettner > -- Cheers, Guinevere Larsen it/its she/her (deprecated)