From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id DKYtFAOrHGlTIhAAWB0awg (envelope-from ) for ; Tue, 18 Nov 2025 12:21:07 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=PYma94UL; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 3C4C81E0B6; Tue, 18 Nov 2025 12:21:07 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2DE831E048 for ; Tue, 18 Nov 2025 12:21:03 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A2F833857723 for ; Tue, 18 Nov 2025 17:21:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A2F833857723 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=PYma94UL Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 084183857358 for ; Tue, 18 Nov 2025 17:20:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 084183857358 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 084183857358 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1763486410; cv=none; b=KTk/UImUqGa3/h4f0i+yDjGaiUXE1Lx1eEAeJZ/a6wTNidJ/f1g5eveRI0aZCYpwSXZoOe5BafwqxIjBOGsbyC93bjNJGOtzri1BCBOJSzY48tlnnExP77YM1XOt8gLGvFplGkFIbMeklm0afaK8A0NxqV/KC2gNBqYRtdpQdiU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1763486410; c=relaxed/simple; bh=/TGKo31Iwz6002kz0lIiR83Wo7jxyi8uAcRxYcmq8R8=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=V9X7s+ISv5zBu+Htnkn2Fh8aKphPTUQvCQt6taz0sGtLHIoiDseUOJgLCHqSxleZAZ99sja2/G94dFw4TOM28lNUNhmKhamYzwSzF2C1nFGJMCsxJ200rMKJNiy7xVjKrpD+NX0BbbYPR2FFSnuWIUgzUL1BX2wSHkoz8jQ6LZM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 084183857358 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 5AIHK2u2188445 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 18 Nov 2025 12:20:06 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 5AIHK2u2188445 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=oct2025; t=1763486407; bh=MMG1w1T7D7WKeobWOkix8H5sG0ODcnmhLWId1QawLNY=; h=Date:Subject:To:From:In-Reply-To:From; b=PYma94ULAom31wl6Fu7Ni3GUDym7Y1jnseTrGupMholMMvGyaytBUWHTR+VU32Btc U5sxeuYdnYXNbmZI36eqqJTHQnteG53nt/17kDafRDtPqDw8xF/w4zBVYtjjAaU0Yi DLjJMt85scDj6Dx95E0B+j5OqmMekSlQe8AQnt2uf1eowkK1nAsUDpLpCVFwolCZOa 1tlpweCNI6mfmTc+5EVgfdY52L6hIaYDvvBI4IX+2k0u8DaI0Vpt9wuSn9RUkrzvJI vfeukykjcIhTag6DVC8YM+gvuQ9+VIXUUXKdDvRA7gZkM5Fkr9dnZqj63vBjJTXPEm KyKvGSnBtkNtA== Received: by simark.ca (Postfix) id 5C3761E048; Tue, 18 Nov 2025 12:20:01 -0500 (EST) Message-ID: <3dcd5b63-8055-491b-a7d3-4548204134d4@polymtl.ca> Date: Tue, 18 Nov 2025 12:20:00 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/6] gdb/testsuite/dwarf: use single abbrev table in .dwo files To: Andrew Burgess , Simon Marchi , gdb-patches@sourceware.org References: <20251107211041.520697-1-simon.marchi@efficios.com> <20251107211041.520697-2-simon.marchi@efficios.com> <87zf8jth4t.fsf@redhat.com> Content-Language: fr From: Simon Marchi In-Reply-To: <87zf8jth4t.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 18 Nov 2025 17:20:02 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 11/18/25 11:55 AM, Andrew Burgess wrote: >> -# Build main file. >> -if { [build_executable "${testfile}.exp" $binfile \ >> - [list ${srcfile} ${main_asm_file}] {nodebug}] } { >> - return >> -} >> - >> -# Build DWO file. >> -set dwo_file [standard_output_file ${testfile}.dwo] >> -if { [gdb_compile_shlib $dwo_asm_file $dwo_file nodebug] != "" } { >> +set obj [standard_output_file "${testfile}-dw.o"] >> +set dwo_file [standard_output_file "${testfile}.dwo"] > > The name of the dwo file here is now wrong. The auto generated name > will be '${testfile}-dw.dwo', which is what you embed in the DWARF > above. Oh, indeed. > I was wondering why this wasn't causing problems for the later block in > this file (not touched in this patch): > > if { [is_remote host] } { > gdb_remote_download host $dwo_file > } > > But it turns out that ... > >> +if {[build_executable_and_dwo_files "$testfile.exp" "${binfile}" {} \ > > ... build_executable_and_dwo_files includes this check: > > # Must be run on local host due to use of objcopy. > if {[is_remote host]} { > return -1 > } I don't understand why that wouldn't be possible if debugging on a remote host. Here, we are building target objects, we have a toolchain for the target, so we should have an objcopy for the target that we can run. It should be possible, in theory. Am I missing something? > > So this test never gets past this point for remote host boards. > > I think you should: > > 1. Remove the 'set dwo_file ...' line. > > 2. Remove the 'gdb_remote_download host $dwo_file' line, and its > containing 'if' block. > > 3. Add a 'require {!is_remote host}' line at the start of the file. Since build_executable_and_dwo_files returns -1 if the host is remote, causing the test to exit early an cleanly (although we could perhaps add an untested call somewhere), do we really need the require at the top? If we ever lift the remote host limitation of build_executable_and_dwo_files, then we'll want the test to run. Simon