From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id pXvmM6y7+mInmCcAWB0awg (envelope-from ) for ; Mon, 15 Aug 2022 17:33:32 -0400 Received: by simark.ca (Postfix, from userid 112) id C5D591E5EA; Mon, 15 Aug 2022 17:33:32 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=R1fTmJ6m; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id ED72B1E13B for ; Mon, 15 Aug 2022 17:33:31 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 414C53858430 for ; Mon, 15 Aug 2022 21:33:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 414C53858430 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1660599211; bh=6dMXS/zm1c+ve8rHN7HEjUAEuncXs2mwycEGexDyuvc=; h=Subject:To:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=R1fTmJ6mpmsj9LBqhk/SYeRHvVLZtMdFO4L3z0Tizdp7xk7mEoxYMoZx9iytXA7fE OaX82o+gMHAiKQ7W0y8R+SpA4zAhxya68KV7ofSl0UgWWkhfWQMydTDgg5MP6mEHtU FcTZwU7CdG87AyyVRsEHbOcWazyHlddwY1b41+AY= Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 7EA5B3858C2F for ; Mon, 15 Aug 2022 21:33:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7EA5B3858C2F Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 27FKnOWV021405; Mon, 15 Aug 2022 21:33:09 GMT Received: from ppma03dal.us.ibm.com (b.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.11]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3hyt2pps69-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 15 Aug 2022 21:33:09 +0000 Received: from pps.filterd (ppma03dal.us.ibm.com [127.0.0.1]) by ppma03dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 27FLLWcM032369; Mon, 15 Aug 2022 21:33:08 GMT Received: from b03cxnp08025.gho.boulder.ibm.com (b03cxnp08025.gho.boulder.ibm.com [9.17.130.17]) by ppma03dal.us.ibm.com with ESMTP id 3hx3k9srrw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 15 Aug 2022 21:33:08 +0000 Received: from b03ledav005.gho.boulder.ibm.com (b03ledav005.gho.boulder.ibm.com [9.17.130.236]) by b03cxnp08025.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 27FLX7hR52101542 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 15 Aug 2022 21:33:07 GMT Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 594B7BE051; Mon, 15 Aug 2022 21:33:07 +0000 (GMT) Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9194BBE054; Mon, 15 Aug 2022 21:33:06 +0000 (GMT) Received: from lexx (unknown [9.160.66.1]) by b03ledav005.gho.boulder.ibm.com (Postfix) with ESMTP; Mon, 15 Aug 2022 21:33:06 +0000 (GMT) Message-ID: <3dafb824c71ea8543581549bc278204095db0f6f.camel@vnet.ibm.com> Subject: Re: [PATCH][gdb/testsuite] Fix gdb.dwarf2/dw2-dir-file-name.exp To: Thiago Jung Bauermann Date: Mon, 15 Aug 2022 16:33:05 -0500 In-Reply-To: <87r11h483h.fsf@linaro.org> References: <20220811115809.GA19509@delia> <923f93e01d32d4515014e983502c7c083c46a83d.camel@us.ibm.com> <6a7bdae3c17ffddd49843215537b9d480f85b2cf.camel@us.ibm.com> <10b3195562b41db8f77d3c0cbd984d0da270190e.camel@vnet.ibm.com> <87r11h483h.fsf@linaro.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-18.el8) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: njPOtkttcMBDrxo919VVaRBuY5ts7dWK X-Proofpoint-ORIG-GUID: njPOtkttcMBDrxo919VVaRBuY5ts7dWK X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-08-15_08,2022-08-15_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0 suspectscore=0 lowpriorityscore=0 phishscore=0 mlxscore=0 adultscore=0 priorityscore=1501 impostorscore=0 clxscore=1011 mlxlogscore=962 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000 definitions=main-2208150083 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: will schmidt via Gdb-patches Reply-To: will schmidt Cc: Ulrich Weigand , Tom de Vries , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On Mon, 2022-08-15 at 19:31 +0000, Thiago Jung Bauermann wrote: > Hello, > > will schmidt via Gdb-patches writes: > > > On Mon, 2022-08-15 at 09:54 -0700, Carl Love wrote: > > > Tom: > > > > > > OK, I took a look at how the test used to work and how it is now > > > working and I see what the issue is. > > > > > > PowerPC has two entry points, local and global. The test used to > > > set > > > the breakpoint for the function at the local entry point. With > > > your > > > changes, the breakpoint is now being set at the global breakpoint > > > which > > > is before the local breakpoint. The function is actually entered > > > at > > > the local breakpoint thus gdb never "sees" the breakpoint that > > > was > > > set. > > [ ] > > > > It looks to me that we need to make sure we set the breakpoint at > > > the > > > local address. > > > > > > Off hand, I am not sure how to get your changes to "proc > > > gdb_continue_to_breakpoint" to select the local entry point not > > > the > > > global entry point. Perhaps Ulrich has some ideas??? > > > > From a glance that the patch that updated dw2-dir-file-name.exp; > > ( commit cd919f5533cc8aa495acd75a6f059e5fcf2e6af9 ) > > the change there was effectively > > > > - gdb_breakpoint $func > > + gdb_breakpoint *$func > > > > with assorted regexp changes to match. > > > > The patch description goes into detail, but I interpret the gist of > > it > > as avoiding the aarch64 architecture prologue skipper, since that > > prologue skipper does something wrong, with entanglements in the > > line > > table info. > > > > The powerpc prologue skipper (wherever it is) was presumably > > handling > > the local/global entry points properly. Since the test now species > > a > > specific address (*$func), the prologue skipper is no longer > > involved. > > > > The patch should probably be reverted, but I defer to others if > > I've > > misunderstood part of this issue.. > > Is it possible to force the compiler to use the global entry point? No. :-) > Perhaps by calling the function via a function pointer rather than as > a > regular function call? That would allow preserving the change to the > testcase and making it work on ppc64le. >