From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [PING][PATCH v6 0/3] [gdb/exp] Fix some namespace issues
Date: Tue, 26 May 2026 12:01:09 +0200 [thread overview]
Message-ID: <3da5e999-3260-402e-acbc-3904029da480@suse.de> (raw)
In-Reply-To: <20260512102124.517642-1-tdevries@suse.de>
On 5/12/26 12:21 PM, Tom de Vries wrote:
> Hafiz Abid Qadeer reported PR34034, a problem with namespace handling using a
> Fortran program. I wrote an equivalent program in C++, and reproduced the
> reported problem with both. While investigating the problem, I ran into
> another problem, for which I filed PR34051.
>
> This series contains three patches.
>
> The first patch refactors a complex assignment in
> cp_lookup_symbol_via_imports.
>
> The second patch fixes PR34051, in that same assignment.
>
> The third patch fixes PR34034.
>
Ping.
Thanks,
- Tom
> Tested on aarch64-linux.
>
> Changes in v2 [2]:
> - updated type of directive_match to bool
>
> Changes in v3 [3]:
> - fixed top-level "return -1" in test-case
> - fixed typo in test-case
>
> Changes in v4 [4]:
> - don't use 1 to set bool
> - added approval tag to first patch
> - replaced "block->function () != nullptr" with
> "block->function_block () != nullptr" to handle the case that current block
> is not a function block, but nested in one
> - extended test-case to exercise nested block scenario
>
> Changes in v5:
> - add third patch to fix PR34034
> - update description subject to reflect that we're fixing two PRs
>
> Changes in v6:
> - extend commit message for second patch
> - fix third patch to handle inlined function correctly
>
> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34034
> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34051
>
> Versions:
> - v1 https://sourceware.org/pipermail/gdb-patches/2026-April/226370.html
> - v2 https://sourceware.org/pipermail/gdb-patches/2026-April/226375.html
> - v3 https://sourceware.org/pipermail/gdb-patches/2026-April/226433.html
> - v4 https://sourceware.org/pipermail/gdb-patches/2026-April/226488.html
> - v5 https://sourceware.org/pipermail/gdb-patches/2026-April/226628.html
>
> Tom de Vries (3):
> [gdb] Break up complex assignment in cp_lookup_symbol_via_imports
> [gdb/exp] Fix ignoring of incorrect namespace prefix
> [gdb/exp] Handle recursive namespace import
>
> gdb/cp-namespace.c | 38 +++++++++++----
> gdb/testsuite/gdb.cp/nsusing-2.cc | 62 +++++++++++++++++++++++++
> gdb/testsuite/gdb.cp/nsusing-2.exp | 74 ++++++++++++++++++++++++++++++
> 3 files changed, 164 insertions(+), 10 deletions(-)
> create mode 100644 gdb/testsuite/gdb.cp/nsusing-2.cc
> create mode 100644 gdb/testsuite/gdb.cp/nsusing-2.exp
>
>
> base-commit: 2d7f2dbbd4adadf7c388fa0d8b9ce95d9dfde641
next prev parent reply other threads:[~2026-05-26 10:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 10:21 [PATCH " Tom de Vries
2026-05-12 10:21 ` [PATCH v6 1/3] [gdb] Break up complex assignment in cp_lookup_symbol_via_imports Tom de Vries
2026-05-12 10:21 ` [PATCH v6 2/3] [gdb/exp] Fix ignoring of incorrect namespace prefix Tom de Vries
2026-05-12 10:21 ` [PATCH v6 3/3] [gdb/exp] Handle recursive namespace import Tom de Vries
2026-05-26 10:01 ` Tom de Vries [this message]
2026-07-14 8:43 ` [PING][PATCH v6 0/3] [gdb/exp] Fix some namespace issues Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3da5e999-3260-402e-acbc-3904029da480@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox