From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 0hTbNlv7BmpaBz0AWB0awg (envelope-from ) for ; Fri, 15 May 2026 06:54:19 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=QpfR26Kr; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=dX26Xp6b; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=QpfR26Kr; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=dX26Xp6b; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id BD0FD1E093; Fri, 15 May 2026 06:54:19 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3EF5E1E093 for ; Fri, 15 May 2026 06:54:18 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 96C6A4BA23EB for ; Fri, 15 May 2026 10:54:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 96C6A4BA23EB Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=QpfR26Kr; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=dX26Xp6b; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=QpfR26Kr; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=dX26Xp6b Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 9F3784BA2E07 for ; Fri, 15 May 2026 10:53:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9F3784BA2E07 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9F3784BA2E07 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778842428; cv=none; b=VPVKC7e6kWvb99f78oJQ/ruJtctMnZTybCSkizO5ehMjmu7aeVIz+60rpvMyauO1stvYqE4pm0LUQAHZbCpS6efNNobwUzj1brF8/CmwfzKV1ckjOAy36U5SkMWIdqLdaGh3I0uiWJvHuctk5JnRKgVTYlMwvz6NjMu9A8TCZM0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778842428; c=relaxed/simple; bh=YHtGJFkZP7cqL3igK7xAwMnGYCFE29U2zOBBMiCNj+o=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=OnCPJ99RvZjcTtaT1li5M/7RrmlGHl67qUlHKxQISBbesWDWiqRgFoP7Yg16eWCksk/eFmLeFckj3bEXqO8pX71XPmqicAqi5HAdhpWagNx55ipw24v9oxK9viZrd572wpWHueShtUHUAWfQmrEROAIm5eeDrWW1/Q89+AY1dSQ= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=QpfR26Kr; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=dX26Xp6b; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=QpfR26Kr; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=dX26Xp6b DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9F3784BA2E07 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id ADF905C133; Fri, 15 May 2026 10:53:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1778842427; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nBi0eHDC6cFD1AH8SJjRFg4lgpi4SkRTcvYHqwkd9d0=; b=QpfR26Krwgrx1nYrfhulr+AJzO6g1Ml2g4MP/QQ3wReI8uzk7cQeM+PsQ+BdrQLfFkvUON bPayjyt/0zNpyPA9PrJ7Bf995mjV/Wq2SnwNeILxUfb65C2EhWMDXRgvhU2Ky0SMvG7WMN hN84mH9TfNsWi7ZjUaWzbkrfWWqMPOA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1778842427; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nBi0eHDC6cFD1AH8SJjRFg4lgpi4SkRTcvYHqwkd9d0=; b=dX26Xp6b6K2lo6ApbCvW4xpLQ+eF1UqrUigAVvd1VAj0LAwhVhrYXl32wxY9uBLLNQH0EM nKeHfmZkzUz3XHDw== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=QpfR26Kr; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=dX26Xp6b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1778842427; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nBi0eHDC6cFD1AH8SJjRFg4lgpi4SkRTcvYHqwkd9d0=; b=QpfR26Krwgrx1nYrfhulr+AJzO6g1Ml2g4MP/QQ3wReI8uzk7cQeM+PsQ+BdrQLfFkvUON bPayjyt/0zNpyPA9PrJ7Bf995mjV/Wq2SnwNeILxUfb65C2EhWMDXRgvhU2Ky0SMvG7WMN hN84mH9TfNsWi7ZjUaWzbkrfWWqMPOA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1778842427; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nBi0eHDC6cFD1AH8SJjRFg4lgpi4SkRTcvYHqwkd9d0=; b=dX26Xp6b6K2lo6ApbCvW4xpLQ+eF1UqrUigAVvd1VAj0LAwhVhrYXl32wxY9uBLLNQH0EM nKeHfmZkzUz3XHDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8F658593A9; Fri, 15 May 2026 10:53:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id QoQbITv7BmqBSAAAD6G6ig (envelope-from ); Fri, 15 May 2026 10:53:47 +0000 Message-ID: <3d6a1564-932c-4628-ae32-a7840770d2d6@suse.de> Date: Fri, 15 May 2026 12:53:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] [gdb/python] Introduce py_none/py_true/py_false functions To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20260513163005.3997485-1-tdevries@suse.de> <20260513163005.3997485-2-tdevries@suse.de> <87qzndkhpd.fsf@tromey.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <87qzndkhpd.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Spamd-Result: default: False [-5.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; DWL_DNSWL_LOW(-1.00)[suse.de:dkim]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; FUZZY_RATELIMITED(0.00)[rspamd.com]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,suse.de:dkim,suse.de:mid,imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: ADF905C133 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 5/14/26 7:46 PM, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> +/* The following three functions are refcount-safe wrappers around > Tom> + Py_RETURN_{NONE,TRUE,FALSE}. Starting with python 3.12, None, True and > Tom> + False are immortal, and increasing and decreasing refcount for such object > Tom> + is a no-op, but while supporting older versions we ignore that aspect > Tom> + here. */ > > This comment is mildly incorrect in that using gdbpy_ref<> inherently > implies a decref. Immortality of Python objects isn't really a concern > at the API level. It's an implementation detail of the Python > interpreter. > Hi Tom, thank for the review. I'm not 100% sure I understand what is mildly incorrect here. In a v3 (to be submitted soonish), I've expanded the comment a bit, so hopefully it'll be either correct, or it'll be easier to point out which bit is incorrect. > The rest of the patch seems ok to me. I'm not a huge fan of > immediately-evaluated lambdas but OTOH it's probably harmless here. > I've fixed that in the v3. > + return gdbpy_ref<> ([] { Py_RETURN_FALSE; } ()); > +} > #endif /* GDB_PYTHON_PYTHON_INTERNAL_H */ > > Newline between the closing brace and the #endif please. > Fixed in the v3. Thanks, - Tom > thanks, > Tom