From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 98689 invoked by alias); 15 Jan 2019 17:50:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 98171 invoked by uid 89); 15 Jan 2019 17:50:11 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=H*i:sk:9494a3a, H*f:sk:9494a3a, Hx-languages-length:1225, HContent-Transfer-Encoding:8bit X-HELO: mail.baldwin.cx Received: from bigwig.baldwin.cx (HELO mail.baldwin.cx) (96.47.65.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 15 Jan 2019 17:50:09 +0000 Received: from John-Baldwins-MacBook-Pro-3.local (ralph.baldwin.cx [66.234.199.215]) by mail.baldwin.cx (Postfix) with ESMTPSA id D86C210B670; Tue, 15 Jan 2019 12:50:05 -0500 (EST) Subject: Re: [PATCH] Include to dis-asm.h to get strchr declaration To: Simon Marchi , Nick Clifton Cc: =?UTF-8?B?0J/QsNCy0LXQuyDQmtGA0Y7QutC+0LI=?= , gdb-patches@sourceware.org, binutils@sourceware.org References: <1da4814ae31a668a24b80e162f5941a3@polymtl.ca> <9494a3a3f1a68aeeadf94fb70632e143@polymtl.ca> From: John Baldwin Openpgp: preference=signencrypt Message-ID: <3d320117-db92-d62a-5db1-a794427343d7@FreeBSD.org> Date: Tue, 15 Jan 2019 17:50:00 -0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <9494a3a3f1a68aeeadf94fb70632e143@polymtl.ca> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2019-01/txt/msg00351.txt.bz2 On 1/15/19 6:14 AM, Simon Marchi wrote: > On 2019-01-15 09:01, Nick Clifton wrote: >> Hi Simon, >> >>>> Include to dis-asm.h to get strchr declaration >> >>>>  #include >>>> +#include >>>>  #include "bfd.h" >> >>> I took the liberty of pushing this patch which touches code in >>> include/, since it seemed obvious enough to me. >> >> Do we need to worry about systems that have rather than >> ? >> >> There are various places in the binutils sources (eg binutils/sysdep.h) >> which >> check for configure macros for these headers, which makes me wonder... > > From what I understand, these systems (BSDs, mostly) have strings.h in > addition to string.h, where strings.h provide additional, non-standard > functions. But strchr would still be found in string.h. Yes, that is true on both FreeBSD and OS X at least (both of which have ). On those, defines prototypes for things like bzero() and bcmp(). -- John Baldwin                                                                            Â