From: Simon Marchi <simon.marchi@polymtl.ca>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 0/4] C++ify varobj a little bit
Date: Wed, 22 Nov 2017 20:10:00 -0000 [thread overview]
Message-ID: <3d29ff25f968182b8c48a0b2e2c279aa@polymtl.ca> (raw)
In-Reply-To: <20171121213631.dgdswpfud3fegput@localhost>
On 2017-11-21 16:36, Yao Qi wrote:
> On 17-11-18 16:46:02, Simon Marchi wrote:
>> This patch series does a basic C++ification of the varobj code, enough
>> to get rid of the VECs. It looks regression free according to the
>> buildbot.
>
> I go through them quickly, and they look good to me.
Thanks, I pushed the series, including the "explicit" suggested by
Pedro.
Simon
prev parent reply other threads:[~2017-11-22 20:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-18 21:46 Simon Marchi
2017-11-18 21:46 ` [PATCH 4/4] Remove DEF_VEC_P (varobj_p) Simon Marchi
2017-11-18 21:46 ` [PATCH 2/4] Make varobj::children an std::vector Simon Marchi
2017-11-18 21:46 ` [PATCH 3/4] Replace VEC (varobj_update_result) with std::vector Simon Marchi
2017-11-18 21:57 ` [PATCH 1/4] Basic c++ification of varobj Simon Marchi
2017-11-21 21:31 ` Yao Qi
2017-11-22 20:04 ` Simon Marchi
2017-11-22 10:44 ` Pedro Alves
2017-11-22 20:05 ` Simon Marchi
2017-11-21 21:36 ` [PATCH 0/4] C++ify varobj a little bit Yao Qi
2017-11-22 20:10 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d29ff25f968182b8c48a0b2e2c279aa@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox