From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8/ETD78gZmAsOQAAWB0awg (envelope-from ) for ; Thu, 01 Apr 2021 15:36:31 -0400 Received: by simark.ca (Postfix, from userid 112) id 30D6E1EF4F; Thu, 1 Apr 2021 15:36:31 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 942901E783 for ; Thu, 1 Apr 2021 15:36:30 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4238D385781C; Thu, 1 Apr 2021 19:36:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4238D385781C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1617305790; bh=3LQ+6suXUMyWJCgYCujbMcZT+zDrJ73QXRUy4qXnGCA=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=r0c2EPdIUqHliZO4caQZT4TAcRYUuUZykjJsZSJIsnJJAq9YBW78yWexjlnywyR0C A3dv6dHn2HL89BAUrt0tHSRZR6X5natBVhhItGFsSUYD1XQu1CNMw91ppaic0DWBFf AoHRallb4TjE8qISa2lZhTSxY3Eb1sUk8W/wXvAM= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 0D20F3857812 for ; Thu, 1 Apr 2021 19:36:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0D20F3857812 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-15-ccOgr8K4Mve-iuHv_s444Q-1; Thu, 01 Apr 2021 15:36:23 -0400 X-MC-Unique: ccOgr8K4Mve-iuHv_s444Q-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0527781627 for ; Thu, 1 Apr 2021 19:36:23 +0000 (UTC) Received: from theo.uglyboxes.com (ovpn-113-66.phx2.redhat.com [10.3.113.66]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D40D461F20 for ; Thu, 1 Apr 2021 19:36:22 +0000 (UTC) Subject: Re: [PATCH 9/9] C++ compile support To: gdb-patches@sourceware.org References: <20180810232534.481-1-keiths@redhat.com> <20180810232534.481-10-keiths@redhat.com> <87pmzdopai.fsf@tromey.com> Message-ID: <3d28af7f-6372-8b21-7989-9c66e6dc23bb@redhat.com> Date: Thu, 1 Apr 2021 12:36:22 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <87pmzdopai.fsf@tromey.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Keith Seitz via Gdb-patches Reply-To: Keith Seitz Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 4/1/21 11:03 AM, Tom Tromey wrote: >>> + { >>> + const char *what = TYPE_DECLARED_CLASS (type) ? "struct" : "class"; > > Simon> I don't know if this matters, but the condition above looks reversed, > Simon> can you confirm? > > FWIW, last time I tried, at least one of the c++ compile tests causes a > gcc crash, then lots of timeouts. Are these working for anyone? Sadly there's a lot of bitrot "here." The last time I took a good look at this ($long time ago), there was a bug that was preventing much of this from working, but it was entirely on GDB's side (https://sourceware.org/bugzilla/show_bug.cgi?id=23749 *). Keith * I have not recently assessed if this is still a problem.