Re: [PATCH 09/10] Move register_dump to regcache-dump.c

Yao Qi
2018-02-21T13:59:03Z

On Wed, Feb 21, 2018 at 12:57 PM, Simon Marchi <simon.marchi@polymtl.ca> wrote:
>>
>> register_dump::dump accesses 'struct regcache_desc', which is declared in
>> regcache.c, so that register_dump::dump can't be moved to
>> regcache-dump.c.
>
>
> Is there any reason we can't move struct regcache_descr to regcache.h?

The reason I didn't move is that I want to keep regcache_descr opaque.
To be clear, I don't mind moving regcache_descr to regcache.h and move
all regcache dump stuff into regcache-dump.{c,h}.

--
Yao (齐尧)