From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 75023 invoked by alias); 4 May 2018 18:11:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 75001 invoked by uid 89); 4 May 2018 18:11:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=guidelines X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 04 May 2018 18:11:34 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 56AE6411030F; Fri, 4 May 2018 18:11:33 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id C9EC82026DFD; Fri, 4 May 2018 18:11:32 +0000 (UTC) Subject: Re: [RFA 03/12] Update core-related help strings To: Tom Tromey , gdb-patches@sourceware.org References: <20180430143731.30007-1-tom@tromey.com> <20180430143731.30007-4-tom@tromey.com> From: Pedro Alves Message-ID: <3cfb1618-6bf4-e92b-b841-b80bba1e553e@redhat.com> Date: Fri, 04 May 2018 18:11:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180430143731.30007-4-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-05/txt/msg00117.txt.bz2 On 04/30/2018 03:37 PM, Tom Tromey wrote: > diff --git a/gdb/gcore.c b/gdb/gcore.c > index 5ff4e6dc77..c53810049c 100644 > --- a/gdb/gcore.c > +++ b/gdb/gcore.c > @@ -611,7 +611,8 @@ _initialize_gcore (void) > { > add_com ("generate-core-file", class_files, gcore_command, _("\ > Save a core file with the current state of the debugged process.\n\ > -Argument is optional filename. Default filename is 'core.'.")); > +Usage: generate-core-file [FILENAME]\n\ > +Argument is optional filename. Default filename is 'core.PROCESS_ID'.")); Do the guidelines say anything about this? I mean, PROCESS_ID is not user input, so I'm wondering whether it should be all caps, or whether it was better as it was. Otherwise looks fine. Thanks, Pedro Alves