Re: [PATCH 01/13] New regcache_raw_get_signed

[Luis Machado <lgustavo@codesourcery.com>]

On 11/14/2016 11:42 AM, Yao Qi wrote:
> This patch adds a new regcache api regcache_raw_get_signed.
>
> gdb:
>
> 2016-11-14  Yao Qi  <yao.qi@linaro.org>
>
> 	* regcache.c (regcache_raw_get_signed): New function.
> 	* regcache.h (regcache_raw_get_signed): Declare.
> ---
>  gdb/regcache.c | 13 +++++++++++++
>  gdb/regcache.h |  3 +++
>  2 files changed, 16 insertions(+)
>
> diff --git a/gdb/regcache.c b/gdb/regcache.c
> index a5c90a6..1fcf933 100644
> --- a/gdb/regcache.c
> +++ b/gdb/regcache.c
> @@ -742,6 +742,19 @@ regcache_raw_write_unsigned (struct regcache *regcache, int regnum,
>    regcache_raw_write (regcache, regnum, buf);
>  }
>
> +LONGEST
> +regcache_raw_get_signed (struct regcache *regcache, int regnum)
> +{

I don't quite like the name, but it is debatable whether it is 
appropriate or not. :-)

Making it shorter and to the point since it gets used so much?

> +  LONGEST value;
> +  enum register_status status;
> +
> +  status = regcache_raw_read_signed (regcache, regnum, &value);
> +  if (status == REG_UNAVAILABLE)
> +    throw_error (NOT_AVAILABLE_ERROR,
> +		 _("Register %d is not available"), regnum);
> +  return value;
> +}
> +
>  enum register_status
>  regcache_cooked_read (struct regcache *regcache, int regnum, gdb_byte *buf)
>  {
> diff --git a/gdb/regcache.h b/gdb/regcache.h
> index 1bb0ce0..19ea976 100644
> --- a/gdb/regcache.h
> +++ b/gdb/regcache.h
> @@ -66,6 +66,9 @@ extern void regcache_raw_write_signed (struct regcache *regcache,
>  extern void regcache_raw_write_unsigned (struct regcache *regcache,
>  					 int regnum, ULONGEST val);
>
> +extern LONGEST regcache_raw_get_signed (struct regcache *regcache,
> +					int regnum);
> +
>  /* Set a raw register's value in the regcache's buffer.  Unlike
>     regcache_raw_write, this is not write-through.  The intention is
>     allowing to change the buffer contents of a read-only regcache
>

I understand this command just mimics what get_frame_register_signed 
does, but is it worth having some documentation to make it clear what 
this does and that it throws when a register is not available?