Re: [PATCH v2 02/24] Don't rely on inferior_ptid in record_full_wait

Tom Tromey
2019-12-20T18:57:20Z

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> How does this sound?

Pedro> diff --git i/gdb/target.h w/gdb/target.h
Pedro> index 1bb7276673..14a7d3e61f 100644
Pedro> --- i/gdb/target.h
Pedro> +++ w/gdb/target.h
Pedro> @@ -478,6 +478,13 @@ struct target_ops
Pedro> TARGET_DEFAULT_NORETURN (noprocess ());
Pedro> virtual void commit_resume ()
Pedro> TARGET_DEFAULT_IGNORE ();
Pedro> + /* See target_wait's description. Note that implementations of
Pedro> + this method must not assume that inferior_ptid on entry is
Pedro> + pointing at the thread or inferior that ends up reporting an
Pedro> + event. The reported event could be for some other thread in
Pedro> + the current inferior or even for a different process of the
Pedro> + current target. inferior_ptid may also be null_ptid on
Pedro> + entry. */
Pedro> virtual ptid_t wait (ptid_t, struct target_waitstatus *,
Pedro> int TARGET_DEBUG_PRINTER (target_debug_print_options))
Pedro> TARGET_DEFAULT_FUNC (default_target_wait);

Looks good, thanks.

Tom