Re: [PATCH v2 18/24] Multi-target support

Simon Marchi
2020-01-13T15:59:45Z

On 2020-01-13 10:10 a.m., Pedro Alves wrote:
> On 1/12/20 7:57 PM, Simon Marchi wrote:
>> On 2019-10-17 6:50 p.m., Pedro Alves wrote:
>>> This commit adds multi-target support to GDB. What this means is that
>>> with this commit, GDB can now be connected to different targets at the
>>> same time. E.g., you can debug a live native process and a core dump
>>> at the same time, connect to multiple gdbservers, etc.
>>>
>>> ...
>>
>> remote-sim.c needs to be updated to. The patch below makes it build, although
>> I have not tried it (I don't have time right now to re-figure out again how do
>> do it :)).
>>
>
> Sorry about this. I don't know how I missed it.
>
> The patch look good to me. One nit:
>
>> /* Callback for iterate_over_inferiors. Called (indirectly) by
>> gdbsim_close(). */
>
> This comment is now stale.

I changed it to:

/* Helper for gdbsim_target::close. */

The comment on gdbsim_target::close already explains what is done when closing.

Pushed with that fixed, thanks.

Simon