Re: [PATCH v2 18/24] Multi-target support

Simon Marchi
2020-01-11T03:12:07Z

On 2019-10-17 6:50 p.m., Pedro Alves wrote:
> @@ -539,14 +574,14 @@ extern void exit_inferior_num_silent (int num);
>
> extern void inferior_appeared (struct inferior *inf, int pid);
>
> -/* Get rid of all inferiors. */
> -extern void discard_all_inferiors (void);

I'm rebasing my -Wmissing-declarations patch series and see this:

CXX inferior.o
/home/simark/src/binutils-gdb/gdb/inferior.c:264:1: error: no previous declaration for ‘void discard_all_inferiors()’ [-Werror=missing-declarations]
264 | discard_all_inferiors (void)
| ^~~~~~~~~~~~~~~~~~~~~

The declaration of discard_all_inferiors was removed, but not the definition, I
guess the intent was to remove the definition as well?

Also grepping for it finds one remaining use:

bsd-kvm.c:159: discard_all_inferiors ();

I presume that this call should just be removed too?

Simon