From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id MNkvJjFHwma3uAsAWB0awg (envelope-from ) for ; Sun, 18 Aug 2024 15:10:41 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=cAsHSmcZ; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=aiJpFaI3; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=cAsHSmcZ; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=aiJpFaI3; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 95CFD1E0D0; Sun, 18 Aug 2024 15:10:41 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7A4701E08C for ; Sun, 18 Aug 2024 15:10:39 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3B00D384F01B for ; Sun, 18 Aug 2024 19:10:39 +0000 (GMT) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 3D8E63858429 for ; Sun, 18 Aug 2024 19:10:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3D8E63858429 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3D8E63858429 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1724008220; cv=none; b=fwZ+9h4dMpymsq7gJF+mBaY65hD2d30LZvChu8i4M+f2Fo6d5TXco+exQ+0+TFUm84SvyXA64m6s3Xe7uFT+BwjqvaqIpyHMWB1RFoKHLGH2d2B3Erom8vFFOS3viEUeQ9N0j6NsMTsgXRwzfE1pydqfEmqujVxRjPsLYaz2ZdQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1724008220; c=relaxed/simple; bh=XM9J5vvb2Z8Q7ak9htkmczxyckFjwseAGRXdjpuOKQI=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:From:To; b=UpBUD1HDqDbcG+jV0FZ7lvt1D3WuS/mhJNXDkFfWxCgS+9HZY1o2F6AxSfq4Dwy04x8+diDNWo81nPLPU4BNuqjEo2riEu5lpuV4aFj8/TChWxzFB/huywj/uMFU6AIZKOh1uy1vD3FJJCDhrvTgDDlqeHVViFBqu/Bc8sG6I4U= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4117722812; Sun, 18 Aug 2024 19:10:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1724008216; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pZtjYKwXf795hM4n00GviAV7qfSr7+/lXd7hNNPGDrU=; b=cAsHSmcZSGgLriabnI59k3cUDVFe+GEiGoGa+rx67fQzfAaNCQOSVQ0QQheeKDGbu5QjUn PKUomyzXoT5/4FZwjtyGofD7ieGwaetx2MPFz73XFEhGHvmnZj/bbC8BJFUl7LZgG5ody5 MbzeDGV69NY+YaRWkVkI2viRrFxT+E8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1724008216; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pZtjYKwXf795hM4n00GviAV7qfSr7+/lXd7hNNPGDrU=; b=aiJpFaI34+aXZwc9sht3oSe1v4SbS516F3zWmrWXajBxoT5wV+OSWKajmNjG7X2PZE7G6+ IA5H0tgg8oRkR8AA== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=cAsHSmcZ; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=aiJpFaI3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1724008216; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pZtjYKwXf795hM4n00GviAV7qfSr7+/lXd7hNNPGDrU=; b=cAsHSmcZSGgLriabnI59k3cUDVFe+GEiGoGa+rx67fQzfAaNCQOSVQ0QQheeKDGbu5QjUn PKUomyzXoT5/4FZwjtyGofD7ieGwaetx2MPFz73XFEhGHvmnZj/bbC8BJFUl7LZgG5ody5 MbzeDGV69NY+YaRWkVkI2viRrFxT+E8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1724008216; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pZtjYKwXf795hM4n00GviAV7qfSr7+/lXd7hNNPGDrU=; b=aiJpFaI34+aXZwc9sht3oSe1v4SbS516F3zWmrWXajBxoT5wV+OSWKajmNjG7X2PZE7G6+ IA5H0tgg8oRkR8AA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 19D5E1397F; Sun, 18 Aug 2024 19:10:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id mjWgBBhHwmbmWAAAD6G6ig (envelope-from ); Sun, 18 Aug 2024 19:10:16 +0000 Content-Type: multipart/mixed; boundary="------------znWBW07WUWMM2y10PuA0klP1" Message-ID: <3c44e27f-22fe-49ce-ad64-a48ad5cff9f0@suse.de> Date: Sun, 18 Aug 2024 21:11:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/dwarf2: Check for missing abbrev From: Tom de Vries To: Aaron Merey , Tom Tromey Cc: Simon Marchi , gdb-patches@sourceware.org References: <20240313201827.1853989-1-amerey@redhat.com> <878r2lm1un.fsf@tromey.com> <22883d8d-b634-4e71-802c-239114d01279@simark.ca> <87r0gclw9w.fsf@tromey.com> Content-Language: en-US In-Reply-To: X-Rspamd-Action: no action X-Rspamd-Queue-Id: 4117722812 X-Spam-Level: X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-3.41 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MIME_BASE64_TEXT_BOGUS(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_BASE64_TEXT(0.10)[]; MIME_GOOD(-0.10)[multipart/mixed,text/plain,text/x-patch]; MX_GOOD(-0.01)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; ARC_NA(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCPT_COUNT_THREE(0.00)[4]; RCVD_VIA_SMTP_AUTH(0.00)[]; HAS_ATTACHMENT(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; DBL_BLOCKED_OPENRESOLVER(0.00)[gnu.org:url, suse.de:mid, suse.de:dkim, suse.de:email, imap1.dmz-prg2.suse.org:rdns, imap1.dmz-prg2.suse.org:helo] X-Spam-Score: -3.41 X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org This is a multi-part message in MIME format. --------------znWBW07WUWMM2y10PuA0klP1 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 8/14/24 16:47, Tom de Vries wrote: > On 3/14/24 18:45, Aaron Merey wrote: >> We should be able to reproduce this in a testcase by overwriting part of >> a small binary with zeros.  I'll resubmit the patch with a testcase. > > I ran into this problem as well via PR32081 (where correct debuginfo is > read incorrectly). After writing the test-case for this patch ( https://sourceware.org/pipermail/gdb-patches/2024-August/211114.html ) I realized it would be easy to modify it to trigger (a form of) this problem. Result attached. Feel free to ignore this, incorporate this into a v2, or suggest to me to submit a v2 in case you don't have the bandwidth to work on this any time soon. Thanks, - Tom --------------znWBW07WUWMM2y10PuA0klP1 Content-Type: text/x-patch; charset=UTF-8; name="0001-gdb-testsuite-Add-gdb.dwarf2-dw2-inter-cu-error.exp.patch" Content-Disposition: attachment; filename*0="0001-gdb-testsuite-Add-gdb.dwarf2-dw2-inter-cu-error.exp.pat"; filename*1="ch" Content-Transfer-Encoding: base64 RnJvbSAzN2NmNzMzNTQzYzU1NDcxYzc2ZjIxNjY3NWNlMTAzMDMzNWI2MjExIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBUb20gZGUgVnJpZXMgPHRkZXZyaWVzQHN1c2UuZGU+ CkRhdGU6IFN1biwgMTggQXVnIDIwMjQgMjA6NTY6NTQgKzAyMDAKU3ViamVjdDogW1BBVENI XSBbZ2RiL3Rlc3RzdWl0ZV0gQWRkIGdkYi5kd2FyZjIvZHcyLWludGVyLWN1LWVycm9yLmV4 cAoKLS0tCiAuLi4vZ2RiLmR3YXJmMi9kdzItaW50ZXItY3UtZXJyb3IuZXhwICAgICAgICAg fCA0OSArKysrKysrKysrKysrKysrKysrCiAxIGZpbGUgY2hhbmdlZCwgNDkgaW5zZXJ0aW9u cygrKQogY3JlYXRlIG1vZGUgMTAwNjQ0IGdkYi90ZXN0c3VpdGUvZ2RiLmR3YXJmMi9kdzIt aW50ZXItY3UtZXJyb3IuZXhwCgpkaWZmIC0tZ2l0IGEvZ2RiL3Rlc3RzdWl0ZS9nZGIuZHdh cmYyL2R3Mi1pbnRlci1jdS1lcnJvci5leHAgYi9nZGIvdGVzdHN1aXRlL2dkYi5kd2FyZjIv ZHcyLWludGVyLWN1LWVycm9yLmV4cApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAw MDAwMDAwMC4uMmMyMDZlNzUxOTcKLS0tIC9kZXYvbnVsbAorKysgYi9nZGIvdGVzdHN1aXRl L2dkYi5kd2FyZjIvZHcyLWludGVyLWN1LWVycm9yLmV4cApAQCAtMCwwICsxLDQ5IEBACisj IENvcHlyaWdodCAyMDI0IEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbiwgSW5jLgorCisjIFRo aXMgcHJvZ3JhbSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBh bmQvb3IgbW9kaWZ5CisjIGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIEdlbmVyYWwg UHVibGljIExpY2Vuc2UgYXMgcHVibGlzaGVkIGJ5CisjIHRoZSBGcmVlIFNvZnR3YXJlIEZv dW5kYXRpb247IGVpdGhlciB2ZXJzaW9uIDMgb2YgdGhlIExpY2Vuc2UsIG9yCisjIChhdCB5 b3VyIG9wdGlvbikgYW55IGxhdGVyIHZlcnNpb24uCisjCisjIFRoaXMgcHJvZ3JhbSBpcyBk aXN0cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0IGl0IHdpbGwgYmUgdXNlZnVsLAorIyBidXQg V0lUSE9VVCBBTlkgV0FSUkFOVFk7IHdpdGhvdXQgZXZlbiB0aGUgaW1wbGllZCB3YXJyYW50 eSBvZgorIyBNRVJDSEFOVEFCSUxJVFkgb3IgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBV UlBPU0UuICBTZWUgdGhlCisjIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZvciBtb3Jl IGRldGFpbHMuCisjCisjIFlvdSBzaG91bGQgaGF2ZSByZWNlaXZlZCBhIGNvcHkgb2YgdGhl IEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlCisjIGFsb25nIHdpdGggdGhpcyBwcm9ncmFt LiAgSWYgbm90LCBzZWUgPGh0dHA6Ly93d3cuZ251Lm9yZy9saWNlbnNlcy8+LgorCitsb2Fk X2xpYiBkd2FyZi5leHAKKworIyBUaGlzIHRlc3QgY2FuIG9ubHkgYmUgcnVuIG9uIHRhcmdl dHMgd2hpY2ggc3VwcG9ydCBEV0FSRi0yIGFuZCB1c2UgZ2FzLgorcmVxdWlyZSBkd2FyZjJf c3VwcG9ydAorCitzdGFuZGFyZF90ZXN0ZmlsZSBtYWluLmMgLlMKKworIyBDcmVhdGUgdGhl IERXQVJGLgorc2V0IGFzbV9maWxlIFtzdGFuZGFyZF9vdXRwdXRfZmlsZSAkc3JjZmlsZTJd CitEd2FyZjo6YXNzZW1ibGUgJGFzbV9maWxlIHsKKyAgICBkZWNsYXJlX2xhYmVscyBsYWJl bDEKKworICAgIGN1IHt9IHsKKwljb21waWxlX3VuaXQge3tsYW5ndWFnZSBARFdfTEFOR19D fX0geworCSAgICBzdWJwcm9ncmFtIHsKKwkJe01BQ1JPX0FUX3JhbmdlIHsgbWFpbiB9fQor CQl7RFdfQVRfc3BlY2lmaWNhdGlvbiAlJGxhYmVsMX0KKwkgICAgfQorCX0KKyAgICB9CisK KyAgICBjdSB7fSB7CisJY29tcGlsZV91bml0IHt7bGFuZ3VhZ2UgQERXX0xBTkdfQ319IHsK KwkgICAgbGFiZWwxOgorCX0KKyAgICB9Cit9CisKK2lmIFtwcmVwYXJlX2Zvcl90ZXN0aW5n ICJmYWlsZWQgdG8gcHJlcGFyZSIgJHRlc3RmaWxlIFwKKwlbbGlzdCAkYXNtX2ZpbGUgJHNy Y2ZpbGVdIHtub2RlYnVnfV0geworICAgIHJldHVybiAtMQorfQorCitnZGJfYXNzZXJ0IHsg W3JlZ2V4cCAiRHdhcmYgRXJyb3I6IiAkZ2RiX2ZpbGVfY21kX21zZ10gfSAiRXJyb3IgbWVz c2FnZSIKCmJhc2UtY29tbWl0OiA5NzQ3ZTM3ZWQ0YTZiMTY3YjhkMWIwNDY4ZmM2NjU3YzA3 ODE3NDNmCi0tIAoyLjM1LjMKCg== --------------znWBW07WUWMM2y10PuA0klP1--