From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id YELYNJrOHmVgnSUAWB0awg (envelope-from ) for ; Thu, 05 Oct 2023 10:56:26 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=ZQadQHup; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D54A41E0C3; Thu, 5 Oct 2023 10:56:26 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C4D131E028 for ; Thu, 5 Oct 2023 10:56:24 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 50D7D3882AE1 for ; Thu, 5 Oct 2023 14:56:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 50D7D3882AE1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1696517784; bh=2Pnz1wq3DrYx5TJMK9KRMDIRXVyKNkl0QyaDn4sUrmM=; h=Date:Subject:To:Cc:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=ZQadQHupMMGxm2R7J6qGhSXjS5KE7fSLgD/8eB3JPCiItQrsev4otQUggUZOD/MpJ Oh/rAxLsLwg6b//zZR4uFeQZYokYe+0VE1ENOdhDVJyR2GSsjpUFLSTLlH0u79jSXb Os9fYUQZZfOFX9+lKbLi90jQ+TPkDFTZ9mdZdZ6c= Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2065.outbound.protection.outlook.com [40.107.101.65]) by sourceware.org (Postfix) with ESMTPS id B4FF738618CB for ; Thu, 5 Oct 2023 14:56:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B4FF738618CB ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UjmG8Nt0cV/0bMzOYoF7OuTJuttW3jotAFqMJnbCtnGnwRt2oQl4Sb+UDVLgLMRCnXGYR1jfcZjcHMKzKEa1dDEh2ttOgmopKK4NtpE6rRPVXD60cQevf3ycBu251w7AbI1V17fJkeYD3ZEfg0TKgLlatPkD0VVJuWBQTA/UunylOCKktEKah8a/1GTbfH9A/VSWCECVBtP5dwtJU1lSJkwryR90mMWrRHm9n8L51tdRcWXrx8PmwXKw20mPh7Gm2rCPTEnSEajwpb3r89Qh5lO8ZfUvGRoKyTPKrLdtri7MFjqrPm3b0EkK2WLeYtw33SsxnEoe3qe7Kx9zYR6gYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2Pnz1wq3DrYx5TJMK9KRMDIRXVyKNkl0QyaDn4sUrmM=; b=LtT3TfJK2DcbgPQEL51u+Ra60JphWvZWG3oG5Z8v7WiHbKbv3zKZFuwzc8ceiECOSFs6dEj1ZYz/nspa9+ztgVssx+F1AvUknCvtk6kjl8dys2f2hz8vbQMYUKh06QT6lye4y63pZ940EGGq3CQfYA896sxHPz2lrs0Fs4jZUtOGDRS3ViuJyuduR/y9RZeffEj4blqyBiwgGR1KZjBKPlg8Ra2A6RVc4kQX+U8R5wgcex/JVdzN/1V2T8JSg6Fo0zEQqVFPCdtnllpY9+BSVCqWL17dnvzB6tz+IBqon3SvbL7WX79LWVjhpk2OiFcmtpe0Xl14m/zPTrZFHZXECw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from CH3PR12MB9079.namprd12.prod.outlook.com (2603:10b6:610:1a1::9) by CY8PR12MB7145.namprd12.prod.outlook.com (2603:10b6:930:5f::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.37; Thu, 5 Oct 2023 14:55:58 +0000 Received: from CH3PR12MB9079.namprd12.prod.outlook.com ([fe80::3120:8014:c770:9f8f]) by CH3PR12MB9079.namprd12.prod.outlook.com ([fe80::3120:8014:c770:9f8f%7]) with mapi id 15.20.6838.033; Thu, 5 Oct 2023 14:55:56 +0000 Message-ID: <3c031ebd-4011-48f7-9cf5-0bd87797808c@amd.com> Date: Thu, 5 Oct 2023 15:55:50 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC] Require c++17 compiler Content-Language: en-US To: Simon Marchi , Andrew Burgess , Tom de Vries Cc: gdb-patches@sourceware.org References: <20231005065449.32643-1-tdevries@suse.de> <20231005103354.5loeki67slszfrcy@hpe6u-23> <87h6n5tfu9.fsf@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0262.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b5::8) To CH3PR12MB9079.namprd12.prod.outlook.com (2603:10b6:610:1a1::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR12MB9079:EE_|CY8PR12MB7145:EE_ X-MS-Office365-Filtering-Correlation-Id: c44be46b-30df-41de-1c9f-08dbc5b32de2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: favyVKunUe1LXPDNXL07VSqirV0vUANFL5+go4fPCMBlhTr7/at7wyxwASXh7YjLDGQ9Cs6rSJKEjJ04YEOWDs+FPcwhzBSkacDWfCanjDNoJtvhsywELRsr6gFNUUcjxRUAdSrTJhLsmtBgZI0N+baLPVPgbcn7vFB7O/H9J8kajwVAQnRuU8GrfzLynt0hLwqwyqcqPZswM+9x/jwQM/gA3w55vq9DKPC/BR/Q1galDCBJY2IFwN+nHocZkrpFB0c30/pogBpag1xql78e8Q4Acm5wnOub4MP7HKeTnEulmVKUqQxKQ+STFLxkXUl2JOW/XHKV4WeIGoAeEJCGgJ45foAlh17Bwsk/cTneG5QvZHwoGrec9L+ZLGEYJiizew1EMuR8UooZQOJ0klh70pV5miu6QfkMLUavDplKDzVga4mltX9GU1PztWI8DDYiEoj2zE3YrtgrOPwYu6GLU1wgPioPSSPk8ICKZfyi5fpUv/J2ffITW5c0Iwb3BBsGZ3Gw8VgVxdtEbqwxfKK9RdVgegovGd6woGrAxvqCR/RczA2XmcJZqglfs5jxLZIM8RLdAb6S5ryM9hUYaqpN2zpOEdsJ3ZAqBQeDf3uGrzKEp2X0kxUCyV6LeZAuFlu7rlA8b+NFsXPmA6C79Pym/Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR12MB9079.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(366004)(376002)(39860400002)(346002)(396003)(230922051799003)(186009)(64100799003)(1800799009)(451199024)(6506007)(6512007)(6666004)(6486002)(478600001)(2616005)(26005)(2906002)(4744005)(316002)(110136005)(8936002)(66476007)(66556008)(66946007)(8676002)(4326008)(5660300002)(41300700001)(36756003)(38100700002)(86362001)(31696002)(31686004)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bEdNaTdtNmFmVWMyRFVBZmpNUFk2cTZsQ2RSVCtZVnQ2Sy8xNUtxOVZ5UktG?= =?utf-8?B?VUdNUlU1dm9ZaXNUNW1zQnFWcUZjZ2dEOUhkdVdSemZtQXJidHBBc3haN1Zw?= =?utf-8?B?cGF5UlZpZFViRDRVU2hFMis1U2lxSGdiUVY2OStYWmoxdFh5NGNaYUhLaDVS?= =?utf-8?B?RVlnU2xPTlV2WlpWbFNwbExVaXljN0JtQ2c5SjhvOGliS1JFRVBLOENVN0xU?= =?utf-8?B?WUlKWWRXaUE4OUtNTnBhZFR3SEZnbDBOL1M5TlMzVnJ5bUZteGJIcm5OM1Vm?= =?utf-8?B?M2QrUUxVNmlLWklNU1ZDSUhFNGlEOGROSEtnU2FRMHZib1ptWU9GUVdrNVZO?= =?utf-8?B?VGlVaDdsU1l3S3NGR3dWWlhMZEJ6dlp0ZGNvRUtJVk83YUdRLzdVTHEwWG1S?= =?utf-8?B?VHF6S1Zxd1NFbFhwRzJzbWU0YnRPdTlhQVJmeG43bEQrZE95cjVXZ0lZSVVS?= =?utf-8?B?ZTlnR1BObEpqSnVSMlRFUDcvYnpWT3NabGZYd1JLYjNnRHlzdEcrZ1RCV1pk?= =?utf-8?B?ZDhWVnFEc1hBaFJQdnhmY2l5bGVta1R3eCtzeGhKV1VxVFBvaVFPWUpub3JZ?= =?utf-8?B?d0RucVJCT0dxcDVRWDdqbWhvMHdMaE1NZENpZE5BS25ualR0bEJQSWlsSE56?= =?utf-8?B?WGFrT1B5YitickpIOEVJL0VXcjBqTTZnNnNtRCtVOE1oU3NkOStqam5NQWtT?= =?utf-8?B?OVljN0x5dlZEQXNVQm5UUnRhQ095Tk10M0Y2SGp5VTJaSXNJSWtUMXROM1pM?= =?utf-8?B?M0I2RWpnQ2FHa3ByRHgrbmljQVlpVGVjcUEwMXR3TUJOZk1pY2t4M0szRUx2?= =?utf-8?B?dHBDdTFyUGlUakFGbG85dDRJN3hKWjVoV203N0VmYlRWOGw3eUNpRUoyQjJP?= =?utf-8?B?RktwR2JHMjJOK3RLRFp3S01kWXg5NDZ6RFozejBFYkpoUmxHMzhhNHJFTTFo?= =?utf-8?B?VkV2NVNyUDB1bllObXdkblhKZmk2WkJPSFVWRzIvcktHdVQwQ01zUytqUjV2?= =?utf-8?B?TTRTSjl1WDROVzFKMzhCSzFDdUZZUGtyKzg2L1lKbS9KTytSbVYzaHY0OEJy?= =?utf-8?B?UFlyS09XQzZPWG12cjdDUFZ1blhNV3RoUUx0dUY3aEh5bFhzZjVLeUJsR0w5?= =?utf-8?B?d3pldHJ6c1Byd0U0Q3BHRlM1ZGNIeFg5bkJwN3dhMEJCbllKTkwyMTR5NmR3?= =?utf-8?B?NVJud01IazBhVnExV1YrOTdrcEFZMXBWZ05CV1EzMU80azlWdXFUaHpCemVF?= =?utf-8?B?WFJCUUhweWFrblE1UGNaSTFPaWVlRjN3NWN0cFV1ZVNUMkFPaDlXT3JTY2lk?= =?utf-8?B?VG8wL0M5YXlxTjY5ZHYyTVU5YUxULzVPb1NVdGxjSFpNOVR1SUNlVi96T1VO?= =?utf-8?B?clBWcWhlWE9HQ3h6SHVyWFdLQ1krSFpUR2Z5TE9tSlhJOGlLakhhNUhrRGtJ?= =?utf-8?B?aldMK1YzNUFLNjNGN1JEa2lYQzYyRE1IbFNVWXJ2RVNSZlNkL3NwNHd1dndx?= =?utf-8?B?MUxoSzJXNHlsT2w1WnBlQkx2WWFUNkFvZHo5TE9YVGRMR1ZrM0lJWHBFMVU3?= =?utf-8?B?cFQ5Qk53RTAyZjZjaU5IaG1ULzRhRnBWdUZtbndUcTVhVE1Ha25NUTZXUFdL?= =?utf-8?B?LzlZTzlURmxyNXBzSXpQOW1aUC9RK1crazVBY3R1eS9PWFFEVTlpK0Evd2pB?= =?utf-8?B?NklkT28zYWNzU0szN3cva25mblFSS29rcUhNdkZlT2ZDWHJYdEkwZmd0ZXZp?= =?utf-8?B?dHErbHl3VnZBWXc3ZGp0Y2tUdWlBL3hjakppNmdFZkl5UDJHKy9CTTBXMlZI?= =?utf-8?B?emFYTUJHSWgyWDF0RkFJQVIwREROUktDUGs3a0JObHc4YklEcytnWWxWWnZr?= =?utf-8?B?RmJaRW5ZcDV5UnIxWkpGVW5mZDJhUTlySFVIdjV1REI0VXlrQldQQk1DS001?= =?utf-8?B?cHVJaFU1UExSMDhoU3pSa01ZL2x2UFhQVEV1NFk2aUxCeFpReWtJOXhoaWNr?= =?utf-8?B?b1BzWXBlc0MxekN5WTYvRHM0YUJDYmZ6V3ZDOGd3NjZvWWJSRFpvOWVjMVN1?= =?utf-8?B?Rk9MM1QvdWxBMmZrMllCcXQ0YnNnbXBZYlZNUnRLOTRtTkhFYkhHZExEZHFa?= =?utf-8?Q?WVdBRBtEOgtFHXCofmIARCC04?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: c44be46b-30df-41de-1c9f-08dbc5b32de2 X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB9079.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2023 14:55:56.5379 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: amdGXK47W0UqU1xpw15x5yaaeUHU9D5hp3kVXJ4D5Bi/dLc0DRXvF2FaTkGBcr890W8m1oP9oO5Y2zy3Hyo3XA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7145 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FORGED_SPF_HELO, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Lancelot SIX via Gdb-patches Reply-To: Lancelot SIX Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > > Wouldn't it be a simple find and replace, gdb::optional to > std::optional? Conveniently, it's the same number of characters, so it > doesn't even affect line-wrapping. > > Simon I guess it is mostly true, there could be some cases where one can do namespace gdb { optional f; } But I really don't think we have many of such occurrences. So in the end, I agree that that is a viable option with a big-ish patch. Best, Lancelot.