From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120454 invoked by alias); 28 Sep 2017 09:46:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 119586 invoked by uid 89); 28 Sep 2017 09:46:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 28 Sep 2017 09:46:47 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DA036C3A95; Thu, 28 Sep 2017 09:46:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com DA036C3A95 Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 20FA91797C; Thu, 28 Sep 2017 09:46:44 +0000 (UTC) Subject: Re: [RFA 07/11] Use gdb::byte_vector in mi_cmd_data_write_memory_bytes To: Tom Tromey , gdb-patches@sourceware.org References: <20170912185736.20436-1-tom@tromey.com> <20170912185736.20436-8-tom@tromey.com> From: Pedro Alves Message-ID: <3be26d1e-e048-b45c-e274-609d6e9651c6@redhat.com> Date: Thu, 28 Sep 2017 09:46:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170912185736.20436-8-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-09/txt/msg00857.txt.bz2 On 09/12/2017 07:57 PM, Tom Tromey wrote: > This changes mi_cmd_data_write_memory_bytes to use gdb::byte_vector, > removing some cleanups. Thanks. > > + gdb::byte_vector data; > if (len_units < count_units) > { > /* Pattern is made of less units than count: > repeat pattern to fill memory. */ > - data = (gdb_byte *) xmalloc (count_units * unit_size); > - make_cleanup (xfree, data); > + data = gdb::byte_vector (count_units * unit_size); I think I'd have written instead: data.resize (count_units * unit_size) But OK either way. Thanks, Pedro Alves