From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 76118 invoked by alias); 2 Dec 2016 11:11:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 76108 invoked by uid 89); 2 Dec 2016 11:11:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.0 required=5.0 tests=BAYES_00,KAM_ASCII_DIVIDERS,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 02 Dec 2016 11:11:12 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 742338E66B; Fri, 2 Dec 2016 11:11:11 +0000 (UTC) Received: from [127.0.0.1] (ovpn03.gateway.prod.ext.phx2.redhat.com [10.5.9.3]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uB2BBADW016514; Fri, 2 Dec 2016 06:11:10 -0500 Subject: Re: [PATCH 1/2 v2] Add unit test to aarch64 prologue analyzer To: Yao Qi References: <1480428758-2481-1-git-send-email-yao.qi@linaro.org> <1480591000-19457-1-git-send-email-yao.qi@linaro.org> <20161201152115.GB19289@E107787-LIN> <20161201160412.GC19289@E107787-LIN> <505a5ab1-fce2-8ad1-3f10-62dfef6be4f4@redhat.com> <20161202094012.GD19289@E107787-LIN> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <3b8cc428-0b99-ce5e-9937-1f0a73bca6ce@redhat.com> Date: Fri, 02 Dec 2016 11:11:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161202094012.GD19289@E107787-LIN> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-12/txt/msg00074.txt.bz2 On 12/02/2016 09:40 AM, Yao Qi wrote: > On Thu, Dec 01, 2016 at 06:05:30PM +0000, Pedro Alves wrote: >>> >>> I managed to get emacs indent at column 0 with the following changes in >>> gdb/.dir-locals.el. >> >> That unfortunately somehow makes emacs indent members of classes >> (even if not in a namespace) at column 0, like: >> >> struct foo >> { >> int a; >> }; >> >> Do you get that too? >> > > Yes, :( > >> BTW, the don't-indent-body-of-namespace guideline is here: >> >> https://gcc.gnu.org/codingconventions.html#Namespace_Form >> >> and it does look like GCC generally follows it. > > I still can't get me emacs indent code inside namespace that way, but > I manually fixed it. I'll ask gcc people how do they set emacs. I have a custom c-mode on my ~/.emacs (predating gdb/.dir-locals.el), and adding the namespace tweak there works correctly. Eh. Like this: ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ (defun gdb-c-mode () "C mode with adjusted defaults for use with GDB." (interactive) (c++-mode) (c-set-style "gnu") (setq tab-width 8) (setq indent-tabs-mode 1) (setq c-basic-offset 2) (c-set-offset 'innamespace 0) ) (setq auto-mode-alist (cons '(".*/gdb.*/.*\\.[ch]$" . gdb-c-mode) auto-mode-alist)) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ So if .dir-locals.el can't work for some reason, we could put something like that in gdb/gdb-code-style.el. Thanks, Pedro Alves