From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-131722-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 125593 invoked by alias); 24 May 2016 16:10:27 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 125575 invoked by uid 89); 24 May 2016 16:10:26 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 24 May 2016 16:10:25 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id AEC8563164;	Tue, 24 May 2016 16:10:24 +0000 (UTC)
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u4OGANkp008074;	Tue, 24 May 2016 12:10:24 -0400
Subject: Re: [PATCH 3/8] Pass breakpoint type in set_breakpoint_at
To: Yao Qi <qiyaoltc@gmail.com>, gdb-patches@sourceware.org
References: <1463757161-25850-1-git-send-email-yao.qi@linaro.org> <1463757161-25850-4-git-send-email-yao.qi@linaro.org>
From: Pedro Alves <palves@redhat.com>
Message-ID: <3b0fa4ae-9d8f-ea1d-b16d-d6c8489e319a@redhat.com>
Date: Tue, 24 May 2016 16:10:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0
MIME-Version: 1.0
In-Reply-To: <1463757161-25850-4-git-send-email-yao.qi@linaro.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2016-05/txt/msg00428.txt.bz2

On 05/20/2016 04:12 PM, Yao Qi wrote:

>  
> -/* See mem-break.h  */
> +/* Set breakpoint of TYPE on address WHERE with handler HANDLER.  */
>  
> -struct breakpoint *
> -set_breakpoint_at (CORE_ADDR where, int (*handler) (CORE_ADDR))
> +static struct breakpoint *
> +set_breakpoint_at_1 (enum bkpt_type type, CORE_ADDR where,
> +		     int (*handler) (CORE_ADDR))

Maybe avoid the bland "_1", like:

 set_breakpoint_type_at (enum bkpt_type type, CORE_ADDR where,
 		        int (*handler) (CORE_ADDR))

But LGTM.

Thanks,
Pedro Alves