From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id nrGdAJGbR2oInCMAWB0awg (envelope-from ) for ; Fri, 03 Jul 2026 07:22:57 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=XhKgwzbz; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E38E11E098; Fri, 03 Jul 2026 07:22:56 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0FBA41E024 for ; Fri, 03 Jul 2026 07:22:56 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5EF214BA2E11 for ; Fri, 3 Jul 2026 11:22:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5EF214BA2E11 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=XhKgwzbz Received: from BN1PR04CU002.outbound.protection.outlook.com (mail-eastus2azon11010008.outbound.protection.outlook.com [52.101.56.8]) by sourceware.org (Postfix) with ESMTPS id 26D6E4BA2E09 for ; Fri, 3 Jul 2026 11:22:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 26D6E4BA2E09 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 26D6E4BA2E09 Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=52.101.56.8 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1783077748; cv=pass; b=UHeM0FHHI6NwFDaklXur2p/sg7Oqx/eYkRw+XDy7HaFp5c4ozI2b9pjoxoyrek689cKN6NH5RwmMNK82JlZzSYSnQuIMUJzVF2deZZUJqSuhEEEeLee9B+/5IsAkCi69sfI4Op2ROv65jrEZiLLHu0PSqN0eSPG1A9qCMHU8OsM= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1783077748; c=relaxed/simple; bh=bhK36llhGfsFTBRrWOF8WOha5ypdXsy1AOswUzJNZdQ=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=QRea+x1YEgonpJGcFkGlJXEkcjmM5yCnSk1nv2KxDhNZOBpHBaOWEeALBJERHVafO1aj2sO359BFgyqdsY/UfGPdPKGN8mBfYOL39wD3NLgP5+SO05xBkJ+8iGES3jjxVMm0oDY89vK9trXKIlnOi7uAPY0I0k/+9dx0yBonOP0= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=XhKgwzbz DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 26D6E4BA2E09 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tYZrnRZJB4AAkIn2hrC+ZHr9JGMEkJQ30Yb/P2q4MVtn9czu+mwGKEci9mWCv3VOubhZTbJhq8B2zC2ALM8WHkzJnMkHSeLOKlgZD9qqKGdxWfDFzkK81nh7ap1EiJ8OqjtbmAjqlmO8yKrEsIEeNq9+8XvlvGyf5EhKPB3++yWt1D36pv9a1j04fBPFg2PFMwif6LrBG5xS50NGx0PxfFatb21hRE8r/OhKe/pjy1GXWW1BhvPx+lAP3JILC24cw4rR3BDl8P/emPLk7CuOYY6nRMGdRpQX4J5r1WNFp9KJaoF4kQZczCbXiCA+c4IJIi3iBy5h44HJ5TaPXxOIdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FK3iRos4l9SVowxNNjAUlPAGu8JjPLWrFMJGzXHOVcM=; b=fX9LAx09tRV3eebxm3CcNMmgVV0GXSESG+o2UI4fykq91dtLJX9rqjSzNTLXFJE2UVH6UT3OSrTZ5nyWdzzoGNyeVW2FZU32Q9bXBOs+1kNZE3LACoxCvXnbwl71oQfkIp8UNbvYWHnX03puIE/PqDA1jW+JWIyagJObT5+98s0PmUOmyWj1Cotx5odviYJOz8TCCwfZ3RW24tfPAPBqrZfiYC30UXIcQ22j41Nce3/2OJjKGZERyPqAna92oWzozxrh5TaUoUxr23XoCmdHZdh3W39nwaHU51V5EFazJ2DK5YyAGOJGIWK7m+b5P5Ok4pau+VIL+5vARGhKV52CRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FK3iRos4l9SVowxNNjAUlPAGu8JjPLWrFMJGzXHOVcM=; b=XhKgwzbz7XcYXdmrLXDZV5T6fCoL1T9ABJG44XuzoydpR7i7YUYAWzm/AZ7YTPjwqRum79AO1EmgHHs4NYDlJrQkdm3rDP6lkW7k3JJ3p2gkE1YfBMd/UZxg6o/l6vZLrYf0qvxGf7rMGkXtJwcQd5Z0UnJS24R0HB5OTKXLT5M= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH3PR12MB9079.namprd12.prod.outlook.com (2603:10b6:610:1a1::9) by LV0PR12MB999091.namprd12.prod.outlook.com (2603:10b6:408:32c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.10; Fri, 3 Jul 2026 11:22:25 +0000 Received: from CH3PR12MB9079.namprd12.prod.outlook.com ([fe80::5a7a:2adf:1862:35c3]) by CH3PR12MB9079.namprd12.prod.outlook.com ([fe80::5a7a:2adf:1862:35c3%5]) with mapi id 15.21.0181.009; Fri, 3 Jul 2026 11:22:24 +0000 Message-ID: <3b0fa30b-2405-41eb-a215-b137597cb8a7@amd.com> Date: Fri, 3 Jul 2026 12:22:20 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] gdb, amd-dbgapi-target: use pulongest to print id handles To: Tankut Baris Aktemur , gdb-patches@sourceware.org References: <20260703110353.1635073-1-tankutbaris.aktemur@amd.com> Content-Language: en-US From: Lancelot SIX In-Reply-To: <20260703110353.1635073-1-tankutbaris.aktemur@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0068.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9a::12) To CH3PR12MB9079.namprd12.prod.outlook.com (2603:10b6:610:1a1::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR12MB9079:EE_|LV0PR12MB999091:EE_ X-MS-Office365-Filtering-Correlation-Id: 4a74c72c-7721-4eb7-f6f1-08ded8f55b72 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|23010399003|376014|366016|1800799024|22082099003|18002099003|11063799006|56012099006; X-Microsoft-Antispam-Message-Info: iTEuacyap9RR5VCTmw+j1ZAWwEtwJ929ZepoYJ6a0/DSAKGW49xAbuSB36hlsxz5qIemSTIB7LCea4UiwkkLP7kBp0pHHI7EJPyi7HImtSyRQCYV8bW3WcteeD9qGSFfL3kbiVgQIrvHS+DF8xdGcOpMNUN0jQ+/0wm/mVuKKaAAiiZ4iwasbTHz9oCoV8a0GZixX6CqKpBv8v1c0xsB5cILtW8cISpDWCe8tVoJ02qkDfDl/+75TM1IZFtbksfuFomPp9Kkhy5T56apfd8I4YXYE0cEFv4n6tV41ShnBm7Cc/ZxqfB1OCLOKHtBTh8DsA44wrrbq5fyv6sanBWOL1kc8j9FmdGxCAlQAqlt/dd0OBqHUYvRYIfi/XI7HPao5cuytg7g01oSLXqYOz7kGmTSJBPY6KmG/2y+h30JD5gL/nmnNX0elnyKdEzkdHEH6xR4f2CcbIHgFkF91Pb1TpB3LbYJ6sTPzlW93kBIktas/02UIaLpha7sEvtrYq7EZQMH3IQyQ3mqf8cGr1Ei2l+s8JXDep7KhLN4Xgwgq0PWY2qGEEulcJBIdWXD2QuAlykIQ5tAdW8EtbQNpSm+t8RWYV81Wtf4vMT+Pdi8t0gZoIc3DX0iZtMgkyx8rPAJFnMiq21Ga8gU8oR5Cjl6uRmsLEeE4sMgLrvsDaFa/I4= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR12MB9079.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(23010399003)(376014)(366016)(1800799024)(22082099003)(18002099003)(11063799006)(56012099006); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZEgvQUw1QzVNYXd3eEpBRU0ySDVuc20zMEhRK1NCaE0vTXdNa05PVFV6Y3Z0?= =?utf-8?B?ZjVHK3JPNjlGVVpGUkJSNjRTYnFZb3hUci8yUzcvRk80R2MyN0EwZnZiYWdt?= =?utf-8?B?OHphVUpQT0ZGdWZaSTREdExUUUtNdmhiMk5BNFg0VVR3ampqdi9wMGtyYUVs?= =?utf-8?B?OGxVVW5Uamw2eFBmVVpiUTZ1L3NudG0wK3NnS1dYZGhseExuQ3kzQWZhSXRZ?= =?utf-8?B?WVo3anp4VU9XVTBvMDlqanI2MzE2RW90RjJIZWwwRXhqYVQ3ODBEY29xSWpR?= =?utf-8?B?ZWs4c1laMjdVdllGbFZidmUwb2pLZ0prbjZzb3R1QTQzOVZURGNtQnp2ZTFH?= =?utf-8?B?dGdlczArOWgyZWlaY1FJKzlyalY1bmg2VUxxK3VMNEdIR3ZybXh1SnlYeUE1?= =?utf-8?B?MnljRXUycmViZ1IyWmFoOWxoQVVvUVhsdlVrK2RJWGhCSjlaamttY1RIQmtk?= =?utf-8?B?NWFxY08vaGM2bEs5OHJuSWZLcldhT0dsUTM3OEJ0ZjNtV3M0S0dPRVdoSW9u?= =?utf-8?B?NUNKSSsxREp5emJVdFVBdE1FNWNFMTM5aTJDbk5Ib0RUai9Tak51L3RxM3NH?= =?utf-8?B?SXE4Rzd5QW9tcnB1SUtPNW5uUXFOU0ZJQUlvUzhWOE1ZM05wWFdyS25Fdk9K?= =?utf-8?B?a1FVUDNIdk9zbDhnSlpKeXJjYXN6VzdxeVcrMXBSTG9hRytGNUhJb2d3M2tN?= =?utf-8?B?NUV5TkpzTEg0RUNyZGp3cVhRVkdvVjZRRUhuRUVWWnAyUFRSV3JGL3Z2WXhF?= =?utf-8?B?SzRRNjBRRGl5aVpSOFpISmtCRllMM0xTYkhWOTE3cXBxakpZU09hVTVxWGFh?= =?utf-8?B?WWtSRlNUMjVYc3liTjcxSFVveUJaYk1qd2czdW9DUzVQNGM4TjdKN0hEOHlq?= =?utf-8?B?VFRYeVRTWWRJQVNtODZzT0M3VXRrRDFIMUxhUVgwckU4MkNMcWJKWk0xS2dw?= =?utf-8?B?K0Z5UFRoY3VzTzMzT0VpZlNjSEVJYTR3MW5mUWxPam9hR3c1cDdROU81a2h5?= =?utf-8?B?Nk1ScWpoRkxJRUtCUjdBeERoQ0pOQ3dQZ0VUanBCM05sTU5vcmNrdUtUbWxB?= =?utf-8?B?TnZVdEtoWldwSWdvTkJJYzN1WFZsNHlpL05BckQzMDN6RjQrVy96Z0RQZkp6?= =?utf-8?B?NDhGYnl4MmVUVFpKcjZCZC9QMnNCUDNsekNjeUd6OE5UUWhyOWx0ZCtVRWRH?= =?utf-8?B?di9sOEMrQjZmSHVySlhEUEJEZ2tXSko2blhDR0ZXQjlFOE5SV05jNjFIU2FM?= =?utf-8?B?TnFmN2pXSE40cHVaNXJIYTN5Mkg0akNlb3kwYm5kNUJ2K01mL3FhakhqQ2Vp?= =?utf-8?B?WVV1UmlIemtLRkc4dE12L3M0b0VsTnpFREVSZTlkWHcvcW96cWFXbjM1REEw?= =?utf-8?B?YVdYS2hXN3hpcEE3Zi8xYXBnZ2VUZ2hIS3FkSDloYnJHWDVja285QkpzajJR?= =?utf-8?B?b2NjSytlSlRwSTFCQ012Ung2TGM0OGpXdkxocEFvbmRFMk9HUFVSUXZVSEIy?= =?utf-8?B?R2NiQ2MrRlZRdjQ4bFFtUktSOHVNK3crUWZLSWJpV00rVFAyMlRoN0ZpcEZW?= =?utf-8?B?SEdUSnJscENoeVVQc3dhODZJM2hlY0NRWUZFc3BLYTRxNEM1MHJGazArbnNw?= =?utf-8?B?SWZHOVJGL0x2Sit2OVMwU29qNzRmNFR6NzdDMnkxUy9pS0VnZEhqdHNqTzBI?= =?utf-8?B?VUlLcFJHek5uWHAweUVqK1F2Y2JkTldZak91VmY1THlwaVlrN1cxcVpqVE1E?= =?utf-8?B?RE9vM0xsN0lkaW9jWDdxeTJmbnFCdDhheTIrM0FBV2k3MW1TbFlMeTFXdHBC?= =?utf-8?B?Wm1PRG5tUm0yVmJhMmI0RzhERThiNTkvdEU3U0taVHVCS2R5RElRMHlnT0lk?= =?utf-8?B?aGx5VUpuYU9XVFFYT1FqRFRDR2Z5VUo4ZU0yOVh1MXQ0SzRQeUI3bkxyVzRN?= =?utf-8?B?T3NHQlRzZzZ6dG5ScTAxWkxvN1BOQXlZL2MvY1hRRFlQSURMRXlJYW1TdGJv?= =?utf-8?B?dzBnT0tYcEUyODg1di9RcXdFeGRTODZreHRqNXJ6RXZHL2hUOTZ3MGRxbUNz?= =?utf-8?B?cnVPMDJhWDhyc0JINFFOZzN3b1RaYVRGbzJwanlpQkd1TGs4WnhjUTRkZWlZ?= =?utf-8?B?dnJYT05KS3F0MStzSzVNbUNWSW03QTBORGNUWmQ2bEpGYmYydUN5aktwOGIz?= =?utf-8?B?SE5lK0VxNkcxOXBtVFd4bHlaYTRCdVlXTEFRWm53Yjd1LzFTQ21mc2lWNWN0?= =?utf-8?B?dW9wUC9GUjhxbTNyeXo0UldHNzdXTnJHd3NxQm1wcjlQVjZWWlFrKzgyUjhN?= =?utf-8?Q?5e61griMlFDNbl+AQm?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4a74c72c-7721-4eb7-f6f1-08ded8f55b72 X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB9079.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2026 11:22:24.8133 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uPhCbmXFhFA2MeHjqyL916DlpsCCEz0kW4ie51n57Gs+JR5/0TeN7UyMkuGzd5OQoQzWFnh0A7ZUuKqV/2ukNA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV0PR12MB999091 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 03/07/2026 12:03, Tankut Baris Aktemur wrote: > In amd-dbgapi-target, there are a number of cases where identifier > handles that are obtained from dbgapi are being printed. Those > handles are defined to have type uint64_t. Use pulongest when > printing them for improved portability. > > In one case, `ptid.tid ()` was being printed for the wave id. Change > this to use `wave_id.handle` for consistency with the other cases. Hi Baris, This looks good to me, thanks. Approved-by: Lancelot Six (amdgpu) Best, Lancelot. > --- > gdb/amd-dbgapi-target.c | 87 +++++++++++++++++++++-------------------- > 1 file changed, 45 insertions(+), 42 deletions(-) > > diff --git a/gdb/amd-dbgapi-target.c b/gdb/amd-dbgapi-target.c > index d0424044e0c..caae9a98501 100644 > --- a/gdb/amd-dbgapi-target.c > +++ b/gdb/amd-dbgapi-target.c > @@ -392,18 +392,18 @@ wave_coordinates::to_string () const > std::string str = "AMDGPU Wave"; > > str += (agent_id != AMD_DBGAPI_AGENT_NONE > - ? string_printf (" %ld", agent_id.handle) > + ? string_printf (" %s", pulongest (agent_id.handle)) > : " ?"); > > str += (queue_id != AMD_DBGAPI_QUEUE_NONE > - ? string_printf (":%ld", queue_id.handle) > + ? string_printf (":%s", pulongest (queue_id.handle)) > : ":?"); > > str += (dispatch_id != AMD_DBGAPI_DISPATCH_NONE > - ? string_printf (":%ld", dispatch_id.handle) > + ? string_printf (":%s", pulongest (dispatch_id.handle)) > : ":?"); > > - str += string_printf (":%ld", wave_id.handle); > + str += string_printf (":%s", pulongest (wave_id.handle)); > > str += (group_ids[0] != UINT32_MAX > ? string_printf (" (%d,%d,%d)", group_ids[0], group_ids[1], > @@ -591,9 +591,10 @@ amd_dbgapi_target_breakpoint::check_status (struct bpstat *bs) > &action); > > if (status != AMD_DBGAPI_STATUS_SUCCESS) > - error (_("amd_dbgapi_report_breakpoint_hit failed for breakpoint %ld " > + error (_("amd_dbgapi_report_breakpoint_hit failed for breakpoint %s " > "at %s (%s)"), > - breakpoint_id.handle, paddress (inf->arch (), bs->bp_location_at->address), > + pulongest (breakpoint_id.handle), > + paddress (inf->arch (), bs->bp_location_at->address), > get_status_string (status)); > > if (action == AMD_DBGAPI_BREAKPOINT_ACTION_RESUME) > @@ -624,8 +625,9 @@ amd_dbgapi_target_breakpoint::check_status (struct bpstat *bs) > for our breakpoint_id. */ > if (resume_breakpoint_id != breakpoint_id) > error (_("breakpoint resume event is not for this breakpoint. " > - "Expected breakpoint_%ld, got breakpoint_%ld"), > - breakpoint_id.handle, resume_breakpoint_id.handle); > + "Expected breakpoint_%s, got breakpoint_%s"), > + pulongest (breakpoint_id.handle), > + pulongest (resume_breakpoint_id.handle)); > > amd_dbgapi_event_processed (resume_event_id); > } > @@ -1055,8 +1057,8 @@ amd_dbgapi_target::resume (ptid_t scope_ptid, int step, enum gdb_signal signo) > indicate that the process has exited. GDB treats resuming a > thread that no longer exists as being successful. */ > && status != AMD_DBGAPI_STATUS_ERROR_INVALID_WAVE_ID) > - error (_("wave_resume for wave_%ld failed (%s)"), wave_id.handle, > - get_status_string (status)); > + error (_("wave_resume for wave_%s failed (%s)"), > + pulongest (wave_id.handle), get_status_string (status)); > > wi.stopping = false; > } > @@ -1130,12 +1132,12 @@ amd_dbgapi_target::stop (ptid_t ptid) > } > > if (status != AMD_DBGAPI_STATUS_ERROR_INVALID_WAVE_ID) > - error (_("wave_stop for wave_%ld failed (%s)"), wave_id.handle, > - get_status_string (status)); > + error (_("wave_stop for wave_%s failed (%s)"), > + pulongest (wave_id.handle), get_status_string (status)); > } > else if (status != AMD_DBGAPI_STATUS_ERROR_INVALID_WAVE_ID) > - error (_("wave_get_info for wave_%ld failed (%s)"), wave_id.handle, > - get_status_string (status)); > + error (_("wave_get_info for wave_%s failed (%s)"), > + pulongest (wave_id.handle), get_status_string (status)); > > /* The status is AMD_DBGAPI_STATUS_ERROR_INVALID_WAVE_ID. The wave > could have terminated since the last time the wave list was > @@ -1145,9 +1147,9 @@ amd_dbgapi_target::stop (ptid_t ptid) > wi.stopping = true; > > amd_dbgapi_debug_printf ("got AMD_DBGAPI_STATUS_ERROR_INVALID_WAVE_ID " > - "for wave_%ld, last_resume_mode=%s, " > + "for wave_%s, last_resume_mode=%s, " > "report_thread_events=%d", > - wave_id.handle, > + pulongest (wave_id.handle), > resume_mode_to_string (wi.last_resume_mode), > m_report_thread_events); > > @@ -1212,8 +1214,8 @@ struct scoped_amd_dbgapi_event_processed > { > amd_dbgapi_status_t status = amd_dbgapi_event_processed (m_event_id); > if (status != AMD_DBGAPI_STATUS_SUCCESS) > - warning (_("Failed to acknowledge amd-dbgapi event %" PRIu64), > - m_event_id.handle); > + warning (_("Failed to acknowledge amd-dbgapi event %s"), > + pulongest (m_event_id.handle)); > } > > DISABLE_COPY_AND_ASSIGN (scoped_amd_dbgapi_event_processed); > @@ -1268,8 +1270,8 @@ dbgapi_notifier_handler (int err, gdb_client_data client_data) > sizeof (runtime_state), > &runtime_state); > if (status != AMD_DBGAPI_STATUS_SUCCESS) > - error (_("event_get_info for event_%ld failed (%s)"), > - event_id.handle, get_status_string (status)); > + error (_("event_get_info for event_%s failed (%s)"), > + pulongest (event_id.handle), get_status_string (status)); > > switch (runtime_state) > { > @@ -1404,7 +1406,7 @@ add_gpu_thread (inferior *inf, ptid_t wave_ptid) > > if (!info.wave_info_map.try_emplace (wave_id.handle, > wave_info (wave_id)).second) > - internal_error ("wave ID %ld already in map", wave_id.handle); > + internal_error ("wave ID %s already in map", pulongest (wave_id.handle)); > > /* Create new GPU threads silently to avoid spamming the terminal > with thousands of "[New Thread ...]" messages. */ > @@ -1436,8 +1438,8 @@ process_one_event (amd_dbgapi_inferior_info &info, > = amd_dbgapi_event_get_info (event_id, AMD_DBGAPI_EVENT_INFO_WAVE, > sizeof (wave_id), &wave_id); > if (status != AMD_DBGAPI_STATUS_SUCCESS) > - error (_("event_get_info for event_%ld failed (%s)"), > - event_id.handle, get_status_string (status)); > + error (_("event_get_info for event_%s failed (%s)"), > + pulongest (event_id.handle), get_status_string (status)); > > ptid_t event_ptid = make_gpu_ptid (info.inf->pid, wave_id); > target_waitstatus ws; > @@ -1502,8 +1504,8 @@ process_one_event (amd_dbgapi_inferior_info &info, > } > } > else > - error (_("wave_get_info for wave_%ld failed (%s)"), > - wave_id.handle, get_status_string (status)); > + error (_("wave_get_info for wave_%s failed (%s)"), > + pulongest (wave_id.handle), get_status_string (status)); > > info.wave_events.emplace_back (event_ptid, ws); > break; > @@ -1542,8 +1544,8 @@ process_one_event (amd_dbgapi_inferior_info &info, > AMD_DBGAPI_EVENT_INFO_RUNTIME_STATE, > sizeof (runtime_state), &runtime_state); > if (status != AMD_DBGAPI_STATUS_SUCCESS) > - error (_("event_get_info for event_%ld failed (%s)"), > - event_id.handle, get_status_string (status)); > + error (_("event_get_info for event_%s failed (%s)"), > + pulongest (event_id.handle), get_status_string (status)); > > gdb_assert (runtime_state == AMD_DBGAPI_RUNTIME_STATE_UNLOADED); > gdb_assert > @@ -1620,9 +1622,9 @@ process_event_queue (amd_dbgapi_inferior_info &info, > > if (event_kind != AMD_DBGAPI_EVENT_KIND_NONE) > amd_dbgapi_debug_printf ("Pulled event from dbgapi: " > - "event_id.handle = %" PRIu64 ", " > + "event_id.handle = %s, " > "event_kind = %s", > - event_id.handle, > + pulongest (event_id.handle), > event_kind_str (event_kind)); > > if (event_id == AMD_DBGAPI_EVENT_NONE || event_kind == until_event_kind) > @@ -1860,8 +1862,8 @@ attach_amd_dbgapi (inferior *inf) > /* Are we already attached? */ > if (info.process_id != AMD_DBGAPI_PROCESS_NONE) > { > - amd_dbgapi_debug_printf > - ("already attached: process_id = %" PRIu64, info.process_id.handle); > + amd_dbgapi_debug_printf ("already attached: process_id = %s", > + pulongest (info.process_id.handle)); > return; > } > > @@ -1895,8 +1897,8 @@ attach_amd_dbgapi (inferior *inf) > return; > } > > - amd_dbgapi_debug_printf ("process_id = %" PRIu64 ", notifier fd = %d", > - info.process_id.handle, > + amd_dbgapi_debug_printf ("process_id = %s, notifier fd = %d", > + pulongest (info.process_id.handle), > amd_dbgapi_notifier_get_fd (info.notifier)); > > set_process_memory_precision (info); > @@ -2069,15 +2071,16 @@ amd_dbgapi_target::thread_architecture (ptid_t ptid) > sizeof (architecture_id), > &architecture_id); > if (status != AMD_DBGAPI_STATUS_SUCCESS) > - error (_("Couldn't get architecture for wave_%ld"), ptid.tid ()); > + error (_("Couldn't get architecture for wave_%s"), > + pulongest (wave_id.handle)); > > uint32_t elf_amdgpu_machine; > status = amd_dbgapi_architecture_get_info > (architecture_id, AMD_DBGAPI_ARCHITECTURE_INFO_ELF_AMDGPU_MACHINE, > sizeof (elf_amdgpu_machine), &elf_amdgpu_machine); > if (status != AMD_DBGAPI_STATUS_SUCCESS) > - error (_("Couldn't get elf_amdgpu_machine for architecture_%ld"), > - architecture_id.handle); > + error (_("Couldn't get elf_amdgpu_machine for architecture_%s"), > + pulongest (architecture_id.handle)); > > struct gdbarch_info info; > info.bfd_arch_info = bfd_lookup_arch (bfd_arch_amdgcn, elf_amdgpu_machine); > @@ -2154,16 +2157,16 @@ amd_dbgapi_target::update_thread_list () > || wi.stopping) > { > amd_dbgapi_debug_printf > - ("wave_%ld disappeared, keeping it" > + ("wave_%s disappeared, keeping it" > " (last_resume_mode=%s, stopping=%d)", > - wave_id.handle, > + pulongest (wave_id.handle), > resume_mode_to_string (wi.last_resume_mode), > wi.stopping); > } > else > { > - amd_dbgapi_debug_printf ("wave_%ld disappeared, deleting it", > - wave_id.handle); > + amd_dbgapi_debug_printf ("wave_%s disappeared, deleting it", > + pulongest (wave_id.handle)); > delete_thread_silent (&tp); > } > } > @@ -2283,8 +2286,8 @@ amd_dbgapi_target::displaced_step_finish (thread_info *thread, > sizeof (stop_reason), &stop_reason); > > if (status != AMD_DBGAPI_STATUS_SUCCESS) > - error (_("wave_get_info for wave_%ld failed (%s)"), wave_id.handle, > - get_status_string (status)); > + error (_("wave_get_info for wave_%s failed (%s)"), > + pulongest (wave_id.handle), get_status_string (status)); > > status = amd_dbgapi_displaced_stepping_complete (wave_id, stepping_id); >