From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id oEO/OVmoBWZdwBkAWB0awg (envelope-from ) for ; Thu, 28 Mar 2024 13:26:49 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=freebsd.org header.i=@freebsd.org header.a=rsa-sha256 header.s=dkim header.b=PC3WnB32; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E74B31E0C0; Thu, 28 Mar 2024 13:26:49 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D1F661E030 for ; Thu, 28 Mar 2024 13:26:47 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 658753858D28 for ; Thu, 28 Mar 2024 17:26:47 +0000 (GMT) Received: from mx2.freebsd.org (mx2.freebsd.org [96.47.72.81]) by sourceware.org (Postfix) with ESMTPS id 1132B3858D1E for ; Thu, 28 Mar 2024 17:26:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1132B3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1132B3858D1E Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=96.47.72.81 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1711646791; cv=pass; b=u1rK9CPqHBhcXJSJd+wzigVeAI0xmcttWMKUcC83BztbAk0BiGxkxuov3zISSdJ4pCpC+/IWlFQKQCcS1TDxWBYB4t9UbqN0vtDkBOH33PHpjHurvljzpimOQex14aZmbQImpM+lN/LNjtQQsij6QtrMUeBhPipwIfkUqPQXDjQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1711646791; c=relaxed/simple; bh=2aLPNVzWFY/fFbB9fZgxOfd4O60TtWmuk5X+f5x9Hlc=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=WF4wmRQ6AEY+LS/PIXLdd7vHHcO7ofYK3SG1Efk0J/+mlZ7qJw7tKobjx0UEuDhE/BXRjOJ04sMNP25cabKv2JSb7TZdu2FYBdimW+hS9DHLmttU/xzC2t5h6iv7oZXVC3iyotv/EC6rECFtWlDE5rsFrKUNoaAFJritXCc0RvQ= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4V59SP6dPrz48dS; Thu, 28 Mar 2024 17:26:29 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4V59SP5hrkz44Jq; Thu, 28 Mar 2024 17:26:29 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1711646789; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fSul5yywLF+//+a7etXW0nRPWDNLPaKi4JRaguKd6CY=; b=PC3WnB32XDNrpIaCHw3+MvOHvKVrC4jSgy839MVzgiyDMzi/Tdwm5YMTxLZfnAvS+I7xuP 0GWjBiWUKYKxzEExPjEDr453nvxTz7ds0VtH9zd+G0iKlvi8OQlONj3erqaq5xdgrlppjy 9W1xOLwvw3b1qgIzds9rfKQPo9x9QF7svpZVcX5xNgPv3R+Wk7XzvcQe6SV46XE5u1bTLP 4Cb93u/Li/SVImeJggmV5QtTsWFFc8AZy+4+i459MLSRxwCOinfKtqJRu+Ft1CupWVunU7 G06QEy1lFX5fO4I9KJVa2ZNfZFyMRtVAIQv2PJIuP42ivV/GIgZxSs0KF6dW7A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1711646789; a=rsa-sha256; cv=none; b=vw1YefcuFnxO5S19Hg2Q5biR18VsnFX0gv59VecOAkiX5T5macUTL6g2+7GVK0vp10RhDd xWV3aCv1BvhleENehYztpR3+s6UbzQWGbx5mok69UhKsTbS/PM2IBO8MqRAPmxTReaJ+Pd 7worMWAjTV7rc++3a0UbywHIevPU9BKsouh1oDbFMM44q8pT+O5PYbsuZ+ofR10khH+AX/ UucjnkdACjcDCZDGQY+h3nuMAAOGbzx1kB0Vq1Lb/ZP6Ar9Woi0ZOU86xd2O2+RCAixZRz oFBN92+JVudqRjwueCxB48Ch4lS7tlDslMe+3ZThldRPFXF0xCvPZYZ4Lzeeuw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1711646789; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fSul5yywLF+//+a7etXW0nRPWDNLPaKi4JRaguKd6CY=; b=I0KcixJqZC6ei0jxgVDYm75tvqYbhN5ea1jvFcusS3n7pQoBp5xL+fWc88koejY3P633QJ wwZ5/6RHoSNzCryqFAQwhlHhp0MsjUccgTquLV0I5mBCErrXfRizdCR+S9fsyQO0PUXaXL ZTqduirCaprwCAXIYSPrRWLW3+je1l73fl4OIfb4JpfudMXTllgdXhLs50cni6fCunpAOf lEUVvy7cn8k6HP+7VUkWNiMBB+7Db5g3V51xIetFJ2iCfaL0lcSkm6K6AGRMSCBtOl5rDK FXH6lJqZm7yPyFkGXlGeWk4qjTkKGjIOmCYCr/TO4EyrUnFN9PmvC/eBzNWIpQ== Received: from [10.255.0.190] (unknown [208.118.171.245]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4V59SP4VmKz1Hk5; Thu, 28 Mar 2024 17:26:29 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <3b02c34b-3604-48dd-93e9-c90d749c28f0@FreeBSD.org> Date: Thu, 28 Mar 2024 13:26:29 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb/testsuite] Add missing include in gdb.base/rtld-step.exp Content-Language: en-US To: Tom de Vries , gdb-patches@sourceware.org References: <20240327162329.2242-1-tdevries@suse.de> From: John Baldwin In-Reply-To: <20240327162329.2242-1-tdevries@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On 3/27/24 12:23 PM, Tom de Vries wrote: > On fedora rawhide, with test-case gdb.base/rtld-step.exp I get: > ... > static-pie-static-libc.c: In function '_start':^M > static-pie-static-libc.c:1:22: error: \ > implicit declaration of function '_exit' [-Wimplicit-function-declaration]^M > 1 | void _start (void) { _exit (0); }^M > | ^~~~~^M > compiler exited with status 1 > ... > UNTESTED: gdb.base/rtld-step.exp: failed to compile \ > (-static-pie not supported or static libc missing) > ... > > Fix this by adding the missing include. > > Tested on aarch64-linux. Approved-By: John Baldwin -- John Baldwin