From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id G9TJJxrRgWAnZQAAWB0awg (envelope-from ) for ; Thu, 22 Apr 2021 15:40:10 -0400 Received: by simark.ca (Postfix, from userid 112) id 98FBD1E783; Thu, 22 Apr 2021 15:40:10 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id EB1C01E783 for ; Thu, 22 Apr 2021 15:40:09 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9680E3844036; Thu, 22 Apr 2021 19:40:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9680E3844036 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1619120409; bh=nvvaMS8sVYmWmgnVyDfRisDU7vSoUgPpuwcOrhhXAOE=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=HhQ++dTFNhnXLxQNZ2E0RQc8Z8qOTMEJk/wR7foDVrs5gQLZpig1pGuGudr4Pxg42 JaqFazt2GvqN8qEgVbpg/vNGZtvJN8CdpYbQOVgUCXjiZvNWgiyvvh/4AoiBXajuxX PJLcPIRNmamx5BvE9/ofKp96ZipqJ/vcCml1+ZeQ= Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) by sourceware.org (Postfix) with ESMTPS id 59D2C384B821 for ; Thu, 22 Apr 2021 19:40:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 59D2C384B821 Received: by mail-qt1-x82c.google.com with SMTP id f12so34765720qtf.2 for ; Thu, 22 Apr 2021 12:40:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=nvvaMS8sVYmWmgnVyDfRisDU7vSoUgPpuwcOrhhXAOE=; b=sM+rNqjtDPNa2W3Nanz9rBKpzpReP8odouVgXiysXfwxJbO/3ntkwAnvyrb0ak6kBs IxklwMS2UtCgw2XmrfFoOGCEgmD89eGHcMgga26okYLdmg2AMLyc4sNWZw22ZJ5dOY5B qQV6ZJ8H0OneV59sx6A9bgDdhFTJ5f7eZ+CH0cge+a7ShXJsjN+WmXSlGjZRcZ/NZO0b mgTmY2CCl30eURr84vQZPcATBUcgT+C418ivou2ESBnCK8QMUhKnxRBlzSuHkBoPVR7G DNyFE4pO+4/+hhF/DBNC5/+FkSDw/WBsoQI0sObgnd2Ohpsm6osNxKbDxDW6d/43vwNy NkbQ== X-Gm-Message-State: AOAM533oxTFjs0ILdwf8eAtWE7zxG0k4z0wEuCQnLfAfIZKCfO8BBQBk P6Cf8S95plvumrt8efHRtm2IN1qK9gQNcw== X-Google-Smtp-Source: ABdhPJwHaEbDCzpess2nl9n7RI2yVoTgqZsf5G088IYSnUBeG0HjBCHCa/CxbcYguRxMDBc9nRpJ1Q== X-Received: by 2002:a05:622a:18a:: with SMTP id s10mr73385qtw.237.1619120406947; Thu, 22 Apr 2021 12:40:06 -0700 (PDT) Received: from ?IPv6:2804:7f0:4841:2d9e:8049:2b74:ae14:70d0? ([2804:7f0:4841:2d9e:8049:2b74:ae14:70d0]) by smtp.gmail.com with ESMTPSA id b4sm2906043qkf.64.2021.04.22.12.40.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Apr 2021 12:40:06 -0700 (PDT) Subject: Re: [PATCH master + gdb-10-branch] gdb: fix getting range of flexible array member in Python To: Simon Marchi , Andrew Burgess References: <20210422155950.3520038-1-simon.marchi@polymtl.ca> <20210422164830.GQ2610@embecosm.com> <20210422175027.GR2610@embecosm.com> <994f03c4-d497-efa9-e01f-dabdf7082d3e@polymtl.ca> Message-ID: <3ac122fc-234a-9131-fe23-95962bf9d8ef@linaro.org> Date: Thu, 22 Apr 2021 16:40:03 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <994f03c4-d497-efa9-e01f-dabdf7082d3e@polymtl.ca> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Luis Machado via Gdb-patches Reply-To: Luis Machado Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Hi Simon, On 4/22/21 4:07 PM, Simon Marchi via Gdb-patches wrote: > On 2021-04-22 1:50 p.m., Andrew Burgess wrote: >>> diff --git a/gdb/testsuite/gdb.python/flexible-array-member.c b/gdb/testsuite/gdb.python/flexible-array-member.c >>> new file mode 100644 >>> index 000000000000..79815e2d38e0 >>> --- /dev/null >>> +++ b/gdb/testsuite/gdb.python/flexible-array-member.c >>> @@ -0,0 +1,70 @@ >>> +/* This testcase is part of GDB, the GNU debugger. >>> + >>> + Copyright 2020-2021 Free Software Foundation, Inc. >> >> In this file and the .exp the date range is 2020-2021, is this >> correct? > > Since I copied it from gdb.base/flexible-array-member.c, it should > retain the original copyright date. > >> Otherwise, looks good. > > Thanks, pushed to both branches! > > Simon > I notice this test being executed without python support. I think we need this guard: # Skip all tests if Python scripting is not enabled. if { [skip_python_tests] } { continue }