From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 92264 invoked by alias); 20 Oct 2016 04:20:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 92241 invoked by uid 89); 20 Oct 2016 04:20:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=H*r:112, H*u:1.2.0, H*UA:1.2.0 X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 20 Oct 2016 04:20:32 +0000 Received: by simark.ca (Postfix, from userid 112) id 0CC5A1E486; Thu, 20 Oct 2016 00:20:31 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 8F8651E0F5; Thu, 20 Oct 2016 00:20:29 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 20 Oct 2016 04:20:00 -0000 From: Simon Marchi To: Marc-Andre Laperle Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/3] Remove unused parameter in solib_add and update_solib_list In-Reply-To: <1473712054-30417-1-git-send-email-marc-andre.laperle@ericsson.com> References: <1473712054-30417-1-git-send-email-marc-andre.laperle@ericsson.com> Message-ID: <3a94d8030171c40e172013013ba95fdd@simark.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.0 X-IsSubscribed: yes X-SW-Source: 2016-10/txt/msg00597.txt.bz2 On 2016-09-12 16:27, Marc-Andre Laperle wrote: > The target parameter in both solib_add and update_solib_list > functions is not used anymore and as not been used for a while. This > change removes the parameter to clean up the code a little bit. > > gdb/ChangeLog: > > * infcmd.c (post_create_inferior): Remove unused argument in > call to solib_add. > * remote.c (remote_start_remote): Likewise. > * solib-frv.c (frv_fetch_objfile_link_map): Likewise. > * solib-svr4.c: (svr4_fetch_objfile_link_map): Likewise. > (enable_break): Likewise. > * solib.c (update_solib_list): Remove unused target argument > and its documentation. > (solib_add): Remove unused target argument. Remove unused > argument in call to update_solib_list. > (info_sharedlibrary_command): Remove unused argument in call > to update_solib_list. > (sharedlibrary_command): Remove unused argument in call to > solib_add. > (handle_solib_event): Likewise. > (reload_shared_libraries): Likewise. > * solib.h (solib_add): Remove unused target argument. > > Signed-off-by: Marc-Andre Laperle This patch looks good to me.