From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 122687 invoked by alias); 5 Jun 2017 17:22:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 122677 invoked by uid 89); 5 Jun 2017 17:22:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:493 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 05 Jun 2017 17:22:11 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0D5B91293; Mon, 5 Jun 2017 17:22:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 0D5B91293 Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 0D5B91293 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6AD475DD60; Mon, 5 Jun 2017 17:22:13 +0000 (UTC) Subject: Re: [RFA 2/5] Let print_decimal_chars handle signed values To: Tom Tromey , gdb-patches@sourceware.org References: <20170602193651.3173-1-tom@tromey.com> <20170602193651.3173-3-tom@tromey.com> From: Pedro Alves Message-ID: <3a7c7f3e-6e5a-55d0-9d0a-978b382f9cc4@redhat.com> Date: Mon, 05 Jun 2017 17:22:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170602193651.3173-3-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-06/txt/msg00128.txt.bz2 On 06/02/2017 08:36 PM, Tom Tromey wrote: > + out_vec->reserve (len); std::vector::reserve() != std::vector::resize() ... > + > + /* Compute -x == 1 + ~x. */ > + if (byte_order == BFD_ENDIAN_LITTLE) > + { > + unsigned carry = 1; > + for (unsigned i = 0; i < len; ++i) > + { > + unsigned tem = (0xff & ~bytes[i]) + carry; > + (*out_vec)[i] = tem & 0xff; ... so this is accessing beyond the std::vector's size. Thanks, Pedro Alves