From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 42874 invoked by alias); 3 Oct 2019 12:40:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 42866 invoked by uid 89); 3 Oct 2019 12:40:12 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 03 Oct 2019 12:40:10 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 3FDF11E592; Thu, 3 Oct 2019 08:40:08 -0400 (EDT) Subject: Re: [PATCH v2] gdb: CTF support To: Wei-min Pan , gdb-patches@sourceware.org References: <1564530195-27659-1-git-send-email-weimin.pan@oracle.com> <5377c457-52b0-583d-15b5-47024eae1f48@simark.ca> <895f47d4-3e01-4d5a-474b-43dd2dd037b4@oracle.com> <0fe82814-46b8-79c2-6a25-5f5d51b158e1@simark.ca> <1055d18f-9e5c-3344-114a-3777876c9c63@oracle.com> From: Simon Marchi Message-ID: <3a67839f-73d0-06ed-4140-073306fc618d@simark.ca> Date: Thu, 03 Oct 2019 12:40:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <1055d18f-9e5c-3344-114a-3777876c9c63@oracle.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-10/txt/msg00108.txt.bz2 On 2019-10-02 7:09 p.m., Wei-min Pan wrote: > It doesn't seem using gdb::unique_xmalloc_pointer is appropriate in > these cases > because we want to keep these symbol/type names around in the symbol table. I mean, instead of calling `free` by hand, that copy could be managed with a gdb::unique_xmalloc_pointer. The name duplicated into the symbol table won't change. Simon