From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71631 invoked by alias); 8 Jul 2018 16:52:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 71622 invoked by uid 89); 8 Jul 2018 16:52:44 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:282 X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 08 Jul 2018 16:52:43 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 483801E059; Sun, 8 Jul 2018 12:52:42 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=simark.ca; s=mail; t=1531068762; bh=HYB0RDiTF2mS0/TG/TFQZCKmo728+Nj8nxqCZ/mDKpw=; h=Subject:To:References:From:Date:In-Reply-To:From; b=HnNsnJfYBqjs897NPLAPJeHQ97K7tn2udg6xDG0pGp+mSDvNmiqB7DvVn7jgt4Qnu qTCTevKnIQ9U2hVVij9ODUlUto+1fbw5R9RJ9Lap8TFZwI9HTlqEpl4RXBK3VwBayr E6syGmQq4AMjPKQ3jiGtOtQh6WdZiF86rkaupp7s= Subject: Re: [RFA 14/42] Move scan_file_globals declaration to stabsread.h To: Tom Tromey , gdb-patches@sourceware.org References: <20180523045851.11660-1-tom@tromey.com> <20180523045851.11660-15-tom@tromey.com> From: Simon Marchi Message-ID: <3a592482-4a95-78c9-e81d-e8220895d687@simark.ca> Date: Sun, 08 Jul 2018 16:52:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180523045851.11660-15-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-07/txt/msg00198.txt.bz2 On 2018-05-23 12:58 AM, Tom Tromey wrote: > scan_file_globals is defined in stabsread.c, so move its declaration > to stabsread.h. LGTM, though can you move the comment to the .h and add the usual "See..."? Simon