From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-163304-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 17153 invoked by alias); 21 Jan 2020 01:31:36 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 17145 invoked by uid 89); 21 Jan 2020 01:31:36 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-5.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=H*r:172.16.0, HX-Languages-Length:861
X-HELO: simark.ca
Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 21 Jan 2020 01:31:35 +0000
Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net [192.222.181.218])	(using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)	 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)	(No client certificate requested)	by simark.ca (Postfix) with ESMTPSA id 67D871E47D;	Mon, 20 Jan 2020 20:31:32 -0500 (EST)
Subject: Re: [PATCH] riscv: add gdbserver support
To: "Maciej W. Rozycki" <macro@wdc.com>, Jim Wilson <jimw@sifive.com>
Cc: jiangshuai_li@c-sky.com, Andrew Burgess <andrew.burgess@embecosm.com>, guoren@kernel.org, gdb-patches@sourceware.org, =?UTF-8?B?5aSP56uL5pa5?= <lifang_xia@c-sky.com>, yunhai_shang <yunhai_shang@c-sky.com>
References: <00e401d5cb52$63a4d000$2aee7000$@c-sky.com> <CAFyWVaa7ADP_SmBVoan9AOkWK9parEz5EENZZL5vY+_GcD9SrA@mail.gmail.com> <alpine.LFD.2.21.2001202307240.15714@redsun52.ssa.fujisawa.hgst.com>
From: Simon Marchi <simark@simark.ca>
Message-ID: <3a15e9f5-099f-3be0-e3f1-0e17c2959158@simark.ca>
Date: Tue, 21 Jan 2020 02:13:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2
MIME-Version: 1.0
In-Reply-To: <alpine.LFD.2.21.2001202307240.15714@redsun52.ssa.fujisawa.hgst.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2020-01/txt/msg00618.txt.bz2

On 2020-01-20 6:33 p.m., Maciej W. Rozycki wrote:
>  Offhand I can see the proposal fails to implement XML register 
> descriptions, which I think every modern port is expected to do (we also 
> need to disallow non-XML-enabled RISC-V stubs in GDB proper, as we 
> discussed before; I fail to understand why it wasn't done right away with 
> the initial implementation, as it's quite straightforward and would have 
> set the policy for debug stubs right from the beginning).

I would also expect new ports to use XML target descriptions.  And I see
that there is already code in arch/riscv.c to build target descriptions based
on detected features... so should gdbserver use it?

Simon

[1] https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=blob;f=gdb/arch/riscv.c;h=a3ab8a92909f082754dfd6eb9a70f19153b8684f;hb=HEAD